From 0e111125d596e3da2ac52f5317e7417d353844e8 Mon Sep 17 00:00:00 2001 From: Victor Sosa Date: Sun, 3 Jan 2016 08:05:03 -0400 Subject: [PATCH] A proper way to close the db connection --- .../struts2/views/jasperreports/JasperReportsResult.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/plugins/jasperreports/src/main/java/org/apache/struts2/views/jasperreports/JasperReportsResult.java b/plugins/jasperreports/src/main/java/org/apache/struts2/views/jasperreports/JasperReportsResult.java index 921a010c0..e0ea121f6 100644 --- a/plugins/jasperreports/src/main/java/org/apache/struts2/views/jasperreports/JasperReportsResult.java +++ b/plugins/jasperreports/src/main/java/org/apache/struts2/views/jasperreports/JasperReportsResult.java @@ -386,7 +386,11 @@ public class JasperReportsResult extends StrutsResultSupport implements JasperRe LOG.error("Error producing {} report for uri {}", format, systemId, e); throw new ServletException(e.getMessage(), e); } finally { - conn.close(); + try { + conn.close(); + } catch (Exception e) { + LOG.warn("Could not close db connection properly", e); + } } response.setContentLength(output.size());