diff --git a/apps/portlet/pom.xml b/apps/portlet/pom.xml index 5e46e4f97..b2be1f0d8 100644 --- a/apps/portlet/pom.xml +++ b/apps/portlet/pom.xml @@ -93,8 +93,8 @@ - portlet-api - portlet-api + javax.portlet + portlet-api provided diff --git a/apps/portlet/src/main/webapp/WEB-INF/portlet.xml b/apps/portlet/src/main/webapp/WEB-INF/portlet.xml index 85a6cefda..99815426c 100644 --- a/apps/portlet/src/main/webapp/WEB-INF/portlet.xml +++ b/apps/portlet/src/main/webapp/WEB-INF/portlet.xml @@ -73,7 +73,7 @@ StrutsPortlet2 Struts Test Portlet2 - org.apache.struts2.portlet.dispatcher.Jsr168Dispatcher + org.apache.struts2.portlet.dispatcher.Jsr286Dispatcher diff --git a/apps/portlet/src/main/webapp/WEB-INF/web.xml b/apps/portlet/src/main/webapp/WEB-INF/web.xml index c8d3dcf8a..ff7019458 100644 --- a/apps/portlet/src/main/webapp/WEB-INF/web.xml +++ b/apps/portlet/src/main/webapp/WEB-INF/web.xml @@ -8,11 +8,8 @@ /WEB-INF/applicationContext*.xml + + org.springframework.web.context.ContextLoaderListener + - - - diff --git a/archetypes/struts2-archetype-dbportlet/src/main/resources/archetype-resources/pom.xml b/archetypes/struts2-archetype-dbportlet/src/main/resources/archetype-resources/pom.xml index 5a9c0c3b8..d469925b5 100644 --- a/archetypes/struts2-archetype-dbportlet/src/main/resources/archetype-resources/pom.xml +++ b/archetypes/struts2-archetype-dbportlet/src/main/resources/archetype-resources/pom.xml @@ -59,7 +59,7 @@ org.springframework spring-jdbc - 2.5.6 + 3.0.5.RELEASE @@ -85,9 +85,9 @@ - portlet-api + javax.portlet portlet-api - 1.0 + 2.0 provided @@ -117,9 +117,9 @@ - portlet-api + javax.portlet portlet-api - 1.0 + 2.0 diff --git a/archetypes/struts2-archetype-dbportlet/src/main/resources/archetype-resources/src/main/webapp/WEB-INF/portlet.xml b/archetypes/struts2-archetype-dbportlet/src/main/resources/archetype-resources/src/main/webapp/WEB-INF/portlet.xml index f9153019b..db63369a8 100644 --- a/archetypes/struts2-archetype-dbportlet/src/main/resources/archetype-resources/src/main/webapp/WEB-INF/portlet.xml +++ b/archetypes/struts2-archetype-dbportlet/src/main/resources/archetype-resources/src/main/webapp/WEB-INF/portlet.xml @@ -6,7 +6,7 @@ xsi:schemaLocation="http://java.sun.com/xml/ns/portlet/portlet-app_1_0.xsd http: StrutsDBPortlet Struts Database Portlet - org.apache.struts2.portlet.dispatcher.Jsr168Dispatcher + org.apache.struts2.portlet.dispatcher.Jsr286Dispatcher actionPackages diff --git a/archetypes/struts2-archetype-portlet/src/main/resources/archetype-resources/pom.xml b/archetypes/struts2-archetype-portlet/src/main/resources/archetype-resources/pom.xml index c242eed7e..0424c4da8 100644 --- a/archetypes/struts2-archetype-portlet/src/main/resources/archetype-resources/pom.xml +++ b/archetypes/struts2-archetype-portlet/src/main/resources/archetype-resources/pom.xml @@ -37,7 +37,7 @@ javax.portlet portlet-api - 1.0 + 2.0 provided diff --git a/archetypes/struts2-archetype-portlet/src/main/resources/archetype-resources/src/main/webapp/WEB-INF/portlet.xml b/archetypes/struts2-archetype-portlet/src/main/resources/archetype-resources/src/main/webapp/WEB-INF/portlet.xml index 02fea5354..6eb30b3e0 100644 --- a/archetypes/struts2-archetype-portlet/src/main/resources/archetype-resources/src/main/webapp/WEB-INF/portlet.xml +++ b/archetypes/struts2-archetype-portlet/src/main/resources/archetype-resources/src/main/webapp/WEB-INF/portlet.xml @@ -12,7 +12,7 @@ HelloPortlet ${artifactId} - org.apache.struts2.portlet.dispatcher.Jsr168Dispatcher + org.apache.struts2.portlet.dispatcher.Jsr286Dispatcher diff --git a/plugins/portlet/pom.xml b/plugins/portlet/pom.xml index 6ac02e7dc..40e50b450 100644 --- a/plugins/portlet/pom.xml +++ b/plugins/portlet/pom.xml @@ -1,66 +1,62 @@ - - - 4.0.0 - - org.apache.struts - struts2-plugins - 2.3.1-SNAPSHOT - - org.apache.struts - struts2-portlet2-plugin - jar - Struts 2 Portlet 2.0 Plugin + + + 4.0.0 + + org.apache.struts + struts2-plugins + 2.3.1-SNAPSHOT + + org.apache.struts + struts2-portlet-plugin + jar + Struts 2 Portlet Plugin - - scm:svn:http://svn.apache.org/repos/asf/struts/sandbox/trunk/struts2-portlet2-plugin/ - scm:svn:https://svn.apache.org/repos/asf/struts/sandbox/trunk/struts2-portlet2-plugin/ - - http://svn.apache.org/repos/asf/struts/sandbox/trunk/struts2-portlet2-plugin/ - + + scm:svn:http://svn.apache.org/repos/asf/struts/struts2/trunk/plugins/portlet/ + scm:svn:https://svn.apache.org/repos/asf/struts/struts2/trunk/plugins/portlet/ + http://svn.apache.org/viewcvs.cgi/struts/struts2/trunk/plugins/portlet/ + - - - asm - asm - 3.3 - test - - - asm - asm-commons - 3.3 - test - + + + junit + junit + test + + + ${project.groupId} + struts2-junit-plugin + ${project.version} + test + - - junit - junit - test - 4.8.2 - - - - javax.servlet.jsp - jsp-api - 2.1 - provided - + + javax.servlet + jsp-api + provided + commons-lang @@ -71,140 +67,84 @@ org.apache.velocity velocity - 1.6.3 true org.apache.velocity velocity-tools - 1.3 true - - - velocity - velocity - - - struts - struts - - - - - javax.portlet - portlet-api - 2.0 - true - + + + javax.portlet + portlet-api + provided + - - mockobjects - mockobjects-jdk1.3-j2ee1.3 - 0.09 - test - + + mockobjects + mockobjects-jdk1.3-j2ee1.3 + test + - - org.easymock - easymock - 2.4 - test - + + org.easymock + easymock + test + + + jmock + jmock + test + - - org.easymock - easymockclassextension - 2.4 - test - + + jmock + jmock-cglib + test + - - jmock - jmock - 1.2.0 - test - + + mockobjects + mockobjects-core + test + - - jmock - jmock-cglib - 1.2.0 - test - + + log4j + log4j + test + - - mockobjects - mockobjects-core - 0.09 - test - - - - log4j - log4j - 1.2.9 - test - - - - - org.springframework - spring-mock - 2.0.7 - test - - - org.springframework - spring-portlet - 2.0.7 - test - - - org.springframework - spring-core - 2.5.6 - test - - - commons-fileupload - commons-fileupload - 1.2.2 - test - - - ${project.groupId} - struts2-junit-plugin - ${project.version} - test - - - - - - apache.snapshots - Apache Maven Repository (Snapshots and Test Builds) - http://people.apache.org/repo/m2-snapshot-repository - - false - - - true - - - - exo - Exlolab repository - http://maven2.exoplatform.org/maven/ - - true - - - false - - - - + + + org.springframework + spring-mock + 2.0.7 + test + + + org.springframework + spring-portlet + 2.0.8 + test + + + org.springframework + spring-core + test + + + commons-fileupload + commons-fileupload + test + + + cglib + cglib + test + + diff --git a/plugins/portlet/src/test/java/org/apache/struts2/portlet/PortletRequestMapTest.java b/plugins/portlet/src/test/java/org/apache/struts2/portlet/PortletRequestMapTest.java index 0e420dea7..19bff7a5f 100644 --- a/plugins/portlet/src/test/java/org/apache/struts2/portlet/PortletRequestMapTest.java +++ b/plugins/portlet/src/test/java/org/apache/struts2/portlet/PortletRequestMapTest.java @@ -83,25 +83,27 @@ public class PortletRequestMapTest extends MockObjectTestCase { PortletRequestMap map = new PortletRequestMap(request); Set entries = map.entrySet(); - assertEquals(2, entries.size()); + assertEquals(3, entries.size()); Iterator it = entries.iterator(); - Map.Entry entry = (Map.Entry)it.next(); - checkEntry(entry); - entry = (Map.Entry)it.next(); - checkEntry(entry); - + for (Iterator iterator = entries.iterator(); iterator.hasNext();) { + Map.Entry entry = (Map.Entry) iterator.next(); + checkEntry(entry); + } } - private void checkEntry(Map.Entry entry) { - if(entry.getKey().equals("testAttribute1")) { + private void checkEntry(Map.Entry entry) { + if(entry.getKey().equals("testAttribute1")) { assertEquals("testValue1", entry.getValue()); } else if(entry.getKey().equals("testAttribute2")) { assertEquals("testValue2", entry.getValue()); } - else { - fail("Unexpected entry in etry set: " + entry); + else if(entry.getKey().equals("javax.portlet.lifecycle_phase")) { + assertNull(entry.getValue()); } - } + else { + fail("Unexpected entry in entry set: " + entry); + } + } } diff --git a/pom.xml b/pom.xml index f02ef85e1..6a6bf52e0 100644 --- a/pom.xml +++ b/pom.xml @@ -87,7 +87,7 @@ ${project.version} 3.0.5.RELEASE 3.0.2 - 3.1 + 3.3 2.0.6 @@ -625,14 +625,14 @@ jmock jmock - 1.0.1 + 1.2.0 test jmock jmock-cglib - 1.0.1 + 1.2.0 test @@ -682,9 +682,9 @@ - portlet-api + javax.portlet portlet-api - 1.0 + 2.0