diff --git a/xwork-core/src/main/java/com/opensymphony/xwork2/validator/AnnotationValidationConfigurationBuilder.java b/xwork-core/src/main/java/com/opensymphony/xwork2/validator/AnnotationValidationConfigurationBuilder.java index c6b3adc4b..6e0449d15 100644 --- a/xwork-core/src/main/java/com/opensymphony/xwork2/validator/AnnotationValidationConfigurationBuilder.java +++ b/xwork-core/src/main/java/com/opensymphony/xwork2/validator/AnnotationValidationConfigurationBuilder.java @@ -779,6 +779,7 @@ public class AnnotationValidationConfigurationBuilder { .shortCircuit(v.shortCircuit()) .defaultMessage(v.message()) .messageKey(v.key()) + .messageParams(v.messageParams()) .build(); } diff --git a/xwork-core/src/main/java/com/opensymphony/xwork2/validator/annotations/EmailValidator.java b/xwork-core/src/main/java/com/opensymphony/xwork2/validator/annotations/EmailValidator.java index 7ee9515dd..7b40811c5 100644 --- a/xwork-core/src/main/java/com/opensymphony/xwork2/validator/annotations/EmailValidator.java +++ b/xwork-core/src/main/java/com/opensymphony/xwork2/validator/annotations/EmailValidator.java @@ -55,6 +55,12 @@ import java.lang.annotation.Target; * i18n key from language specific properties file. * * + * messageParams + * no + *   + * Additional params to be used to customize message - will be evaluated against the Value Stack + * + * * fieldName * no *   @@ -101,6 +107,11 @@ public @interface EmailValidator { */ String key() default ""; + /** + * Additional params to be used to customize message - will be evaluated against the Value Stack + */ + String[] messageParams() default {}; + /** * The optional fieldName for SIMPLE validator types. */ diff --git a/xwork-core/src/main/java/com/opensymphony/xwork2/validator/validators/EmailValidator.java b/xwork-core/src/main/java/com/opensymphony/xwork2/validator/validators/EmailValidator.java index 285b54c47..d0dcf756e 100644 --- a/xwork-core/src/main/java/com/opensymphony/xwork2/validator/validators/EmailValidator.java +++ b/xwork-core/src/main/java/com/opensymphony/xwork2/validator/validators/EmailValidator.java @@ -59,6 +59,8 @@ package com.opensymphony.xwork2.validator.validators; * </field> * * <!-- Field Validator Syntax with expressions --> + * <!-- Only available when used with xml based configuration, if you want to have the same + * flexibility with annotations use @RegexFieldValidator instead --> * <field name="myEmail"> * <field-validator type="email"> * <param name="regexExpression">${emailPattern}</param> <!-- will be evaluated as: String getEmailPattern() --> @@ -77,11 +79,11 @@ package com.opensymphony.xwork2.validator.validators; public class EmailValidator extends RegexFieldValidator { // see XW-371 - public static final String emailAddressPattern = + public static final String EMAIL_ADDRESS_PATTERN = "\\b^['_a-z0-9-\\+]+(\\.['_a-z0-9-\\+]+)*@[a-z0-9-]+(\\.[a-z0-9-]+)*\\.([a-z]{2}|aero|arpa|asia|biz|com|coop|edu|gov|info|int|jobs|mil|mobi|museum|name|nato|net|org|pro|tel|travel|xxx)$\\b"; public EmailValidator() { - setRegex(emailAddressPattern); + setRegex(EMAIL_ADDRESS_PATTERN); setCaseSensitive(false); } diff --git a/xwork-core/src/test/java/com/opensymphony/xwork2/validator/AnnotationValidationAction.java b/xwork-core/src/test/java/com/opensymphony/xwork2/validator/AnnotationValidationAction.java index 612708a9e..afc9eee9c 100644 --- a/xwork-core/src/test/java/com/opensymphony/xwork2/validator/AnnotationValidationAction.java +++ b/xwork-core/src/test/java/com/opensymphony/xwork2/validator/AnnotationValidationAction.java @@ -6,6 +6,7 @@ import com.opensymphony.xwork2.validator.annotations.ConversionErrorFieldValidat import com.opensymphony.xwork2.validator.annotations.CustomValidator; import com.opensymphony.xwork2.validator.annotations.DateRangeFieldValidator; import com.opensymphony.xwork2.validator.annotations.DoubleRangeFieldValidator; +import com.opensymphony.xwork2.validator.annotations.EmailValidator; import com.opensymphony.xwork2.validator.annotations.RegexFieldValidator; import com.opensymphony.xwork2.validator.annotations.ValidationParameter; @@ -33,6 +34,8 @@ public class AnnotationValidationAction extends ActionSupport { @DoubleRangeFieldValidator(minExclusive = "1.2", maxExclusive = "1.4", minInclusive = "0", maxInclusive = "0.1", fieldName = "foo", key = "double.key", message = "Foo is out of range!", shortCircuit = true, messageParams = {"one", "two", "three"}) + @EmailValidator(message = "Foo isn't a valid e-mail!", fieldName = "foo", key = "email.key", + messageParams = {"one", "two", "three"}, shortCircuit = true) public String execute() { return SUCCESS; } diff --git a/xwork-core/src/test/java/com/opensymphony/xwork2/validator/AnnotationValidationConfigurationBuilderTest.java b/xwork-core/src/test/java/com/opensymphony/xwork2/validator/AnnotationValidationConfigurationBuilderTest.java index a5288f21c..167481b3d 100644 --- a/xwork-core/src/test/java/com/opensymphony/xwork2/validator/AnnotationValidationConfigurationBuilderTest.java +++ b/xwork-core/src/test/java/com/opensymphony/xwork2/validator/AnnotationValidationConfigurationBuilderTest.java @@ -18,6 +18,7 @@ import com.opensymphony.xwork2.validator.validators.ConditionalVisitorFieldValid import com.opensymphony.xwork2.validator.validators.ConversionErrorFieldValidator; import com.opensymphony.xwork2.validator.validators.DateRangeFieldValidator; import com.opensymphony.xwork2.validator.validators.DoubleRangeFieldValidator; +import com.opensymphony.xwork2.validator.validators.EmailValidator; import com.opensymphony.xwork2.validator.validators.RegexFieldValidator; import java.text.ParseException; @@ -40,7 +41,7 @@ public class AnnotationValidationConfigurationBuilderTest extends XWorkTestCase List validators = manager.getValidators(AnnotationValidationAction.class, null); // then - assertEquals(validators.size(), 6); + assertEquals(validators.size(), 7); for (Validator validator : validators) { validate(validator); } @@ -57,7 +58,7 @@ public class AnnotationValidationConfigurationBuilderTest extends XWorkTestCase ValueStack valueStack = container.getInstance(ValueStackFactory.class).createValueStack(); valueStack.push(new AnnotationValidationExpAction()); - assertEquals(validators.size(), 6); + assertEquals(validators.size(), 7); for (Validator validator : validators) { validator.setValueStack(valueStack); validate(validator); @@ -77,9 +78,22 @@ public class AnnotationValidationConfigurationBuilderTest extends XWorkTestCase validateDateRangeFieldValidator((DateRangeFieldValidator) validator); } else if (validator.getValidatorType().equals("double")) { validateDoubleRangeFieldValidator((DoubleRangeFieldValidator) validator); + } else if (validator.getValidatorType().equals("email")) { + validateEmailValidator((EmailValidator) validator); } } + private void validateEmailValidator(EmailValidator validator) { + assertEquals("foo", validator.getFieldName()); + assertEquals(EmailValidator.EMAIL_ADDRESS_PATTERN, validator.getRegex()); + assertEquals("Foo isn't a valid e-mail!", validator.getDefaultMessage()); + assertEquals("email.key", validator.getMessageKey()); + assertTrue(Arrays.equals(new String[]{"one", "two", "three"}, validator.getMessageParameters())); + assertEquals(true, validator.isShortCircuit()); + assertEquals(false, validator.isCaseSensitive()); + assertEquals(true, validator.isTrimed()); + } + private void validateDoubleRangeFieldValidator(DoubleRangeFieldValidator validator) { assertEquals("foo", validator.getFieldName()); assertEquals("double.key", validator.getMessageKey()); diff --git a/xwork-core/src/test/java/com/opensymphony/xwork2/validator/AnnotationValidationExpAction.java b/xwork-core/src/test/java/com/opensymphony/xwork2/validator/AnnotationValidationExpAction.java index 5f627f204..15dd7821f 100644 --- a/xwork-core/src/test/java/com/opensymphony/xwork2/validator/AnnotationValidationExpAction.java +++ b/xwork-core/src/test/java/com/opensymphony/xwork2/validator/AnnotationValidationExpAction.java @@ -6,6 +6,7 @@ import com.opensymphony.xwork2.validator.annotations.ConversionErrorFieldValidat import com.opensymphony.xwork2.validator.annotations.CustomValidator; import com.opensymphony.xwork2.validator.annotations.DateRangeFieldValidator; import com.opensymphony.xwork2.validator.annotations.DoubleRangeFieldValidator; +import com.opensymphony.xwork2.validator.annotations.EmailValidator; import com.opensymphony.xwork2.validator.annotations.RegexFieldValidator; import com.opensymphony.xwork2.validator.annotations.ValidationParameter; @@ -38,6 +39,8 @@ public class AnnotationValidationExpAction extends ActionSupport { minInclusiveExpression = "${doubleMinInclusiveExpression}", maxInclusiveExpression = "${doubleMaxInclusiveExpression}", fieldName = "foo", key = "double.key", message = "Foo is out of range!", shortCircuit = true, messageParams = {"one", "two", "three"}) + @EmailValidator(message = "Foo isn't a valid e-mail!", fieldName = "foo", key = "email.key", + messageParams = {"one", "two", "three"}, shortCircuit = true) public String execute() { return SUCCESS; }