From 87b2bd81387ac9fd1eaf7ea40fd07e1adae69671 Mon Sep 17 00:00:00 2001 From: Hedju Hor Date: Thu, 11 Jan 2018 21:04:22 +0100 Subject: [PATCH] fixed some Logger calls. Hint:https://logging.apache.org/log4j/2.0/manual/api.html --- .../interceptor/BeanValidationInterceptor.java | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/plugins/bean-validation/src/main/java/org/apache/struts/beanvalidation/validation/interceptor/BeanValidationInterceptor.java b/plugins/bean-validation/src/main/java/org/apache/struts/beanvalidation/validation/interceptor/BeanValidationInterceptor.java index f2b2e9b0b..7c93710ae 100644 --- a/plugins/bean-validation/src/main/java/org/apache/struts/beanvalidation/validation/interceptor/BeanValidationInterceptor.java +++ b/plugins/bean-validation/src/main/java/org/apache/struts/beanvalidation/validation/interceptor/BeanValidationInterceptor.java @@ -94,13 +94,11 @@ public class BeanValidationInterceptor extends MethodFilterInterceptor { ActionProxy actionProxy = invocation.getProxy(); String methodName = actionProxy.getMethod(); - if (LOG.isDebugEnabled()) { - LOG.debug("Validating [{}/{}] with method [{}]", invocation.getProxy().getNamespace(), invocation.getProxy().getActionName(), methodName); - } Class[] validationGroup = getValidationGroups(action, methodName); if (null == MethodUtils.getAnnotation(getActionMethod(action.getClass(), methodName), SkipValidation.class, true, true)) { + LOG.debug("Validating [{}/{}] with method [{}] and groups [{}]", invocation.getProxy().getNamespace(), invocation.getProxy().getActionName(), methodName, Arrays.toString(validationGroup)); // performing bean validation on action performBeanValidation(action, validator, validationGroup); } @@ -115,7 +113,7 @@ public class BeanValidationInterceptor extends MethodFilterInterceptor { protected void performBeanValidation(Object action, Validator validator, Class[] groups) { - LOG.trace("Initiating bean validation.. with groups [{}]", Arrays.toString(groups)); + LOG.trace("Initiating bean validation.."); Set> constraintViolations; @@ -156,9 +154,7 @@ public class BeanValidationInterceptor extends MethodFilterInterceptor { if (action instanceof ModelDriven && fieldName.startsWith(ValidatorConstants.MODELDRIVEN_PREFIX)) { fieldName = fieldName.replace("model.", ValidatorConstants.EMPTY_SPACE); } - if (LOG.isDebugEnabled()) { - LOG.debug("Adding field error [{}] with message [{}]", fieldName, validationError.getMessage()); - } + LOG.debug("Adding field error [{}] with message [{}]", fieldName, validationError.getMessage()); validatorContext.addFieldError(fieldName, validationError.getMessage()); } }