From c36dfd6a2630ff7e3835781026bb2c86fe94b077 Mon Sep 17 00:00:00 2001 From: Maurizio Cucchiara Date: Tue, 20 Sep 2011 16:26:44 +0000 Subject: [PATCH] Partial upgrade to java 5 git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@1173225 13f79535-47bb-0310-9956-ffa450edef68 --- .../apache/struts2/sitegraph/model/Graph.java | 5 ++--- .../struts2/sitegraph/model/SubGraph.java | 21 +++++++------------ 2 files changed, 10 insertions(+), 16 deletions(-) diff --git a/plugins/sitegraph/src/main/java/org/apache/struts2/sitegraph/model/Graph.java b/plugins/sitegraph/src/main/java/org/apache/struts2/sitegraph/model/Graph.java index c91cb83e1..6f85e96e4 100644 --- a/plugins/sitegraph/src/main/java/org/apache/struts2/sitegraph/model/Graph.java +++ b/plugins/sitegraph/src/main/java/org/apache/struts2/sitegraph/model/Graph.java @@ -32,7 +32,7 @@ import java.util.TreeSet; */ public class Graph extends SubGraph { private Set links; - public static Map nodeMap = new LinkedHashMap(); + public static Map nodeMap = new LinkedHashMap(); public Graph() { super(""); @@ -52,8 +52,7 @@ public class Graph extends SubGraph { writer.write("edge [fontsize=10, fontname=helvetica]"); // render all the subgraphs - for (Iterator iterator = subGraphs.iterator(); iterator.hasNext();) { - SubGraph subGraph = (SubGraph) iterator.next(); + for (SubGraph subGraph : subGraphs) { subGraph.render(new IndentWriter(writer)); } diff --git a/plugins/sitegraph/src/main/java/org/apache/struts2/sitegraph/model/SubGraph.java b/plugins/sitegraph/src/main/java/org/apache/struts2/sitegraph/model/SubGraph.java index fd7a26124..444252915 100644 --- a/plugins/sitegraph/src/main/java/org/apache/struts2/sitegraph/model/SubGraph.java +++ b/plugins/sitegraph/src/main/java/org/apache/struts2/sitegraph/model/SubGraph.java @@ -23,7 +23,6 @@ package org.apache.struts2.sitegraph.model; import java.io.IOException; import java.util.ArrayList; -import java.util.Iterator; import java.util.List; /** @@ -31,13 +30,13 @@ import java.util.List; public class SubGraph implements Render { protected String name; protected SubGraph parent; - protected List subGraphs; - protected List nodes; + protected List subGraphs; + protected List nodes; public SubGraph(String name) { this.name = name; - this.subGraphs = new ArrayList(); - this.nodes = new ArrayList(); + this.subGraphs = new ArrayList(); + this.nodes = new ArrayList(); } public String getName() { @@ -67,14 +66,12 @@ public class SubGraph implements Render { writer.write("label=\"" + name + "\";"); // write out the subgraphs - for (Iterator iterator = subGraphs.iterator(); iterator.hasNext();) { - SubGraph subGraph = (SubGraph) iterator.next(); + for (SubGraph subGraph : subGraphs) { subGraph.render(new IndentWriter(writer)); } // write out the actions - for (Iterator iterator = nodes.iterator(); iterator.hasNext();) { - SiteGraphNode siteGraphNode = (SiteGraphNode) iterator.next(); + for (SiteGraphNode siteGraphNode : nodes) { siteGraphNode.render(writer); } @@ -102,8 +99,7 @@ public class SubGraph implements Render { String[] parts = namespace.split("\\/"); SubGraph last = this; - for (int i = 0; i < parts.length; i++) { - String part = parts[i]; + for (String part : parts) { if (part.equals("")) { continue; } @@ -121,8 +117,7 @@ public class SubGraph implements Render { } private SubGraph findSubGraph(String name) { - for (Iterator iterator = subGraphs.iterator(); iterator.hasNext();) { - SubGraph subGraph = (SubGraph) iterator.next(); + for (SubGraph subGraph : subGraphs) { if (subGraph.getName().equals(name)) { return subGraph; }