From c84810ff8233c953146d52731e92090eb07746f5 Mon Sep 17 00:00:00 2001 From: Lukasz Lenart Date: Wed, 22 Jun 2016 10:46:09 +0200 Subject: [PATCH] Adds test to guard pre-evaulation of name attribute --- .../struts2/views/jsp/ui/TextfieldTest.java | 16 ++++++++++++++++ .../apache/struts2/views/jsp/ui/Textfield-12.txt | 4 ++++ 2 files changed, 20 insertions(+) create mode 100644 core/src/test/resources/org/apache/struts2/views/jsp/ui/Textfield-12.txt diff --git a/core/src/test/java/org/apache/struts2/views/jsp/ui/TextfieldTest.java b/core/src/test/java/org/apache/struts2/views/jsp/ui/TextfieldTest.java index e1a81c40b..5ccfe3218 100644 --- a/core/src/test/java/org/apache/struts2/views/jsp/ui/TextfieldTest.java +++ b/core/src/test/java/org/apache/struts2/views/jsp/ui/TextfieldTest.java @@ -281,4 +281,20 @@ public class TextfieldTest extends AbstractUITagTest { verify(TextFieldTag.class.getResource("Textfield-11.txt")); } + public void testNameEvaluation() throws Exception { + TestAction testAction = (TestAction) action; + testAction.setArray(new String[]{"test", "bar"}); + testAction.setFooInt(1); + + TextFieldTag tag = new TextFieldTag(); + tag.setPageContext(pageContext); + tag.setName("array[%{fooInt}]"); + + tag.doStartTag(); + tag.doEndTag(); + + verify(TextFieldTag.class.getResource("Textfield-12.txt")); + } + + } diff --git a/core/src/test/resources/org/apache/struts2/views/jsp/ui/Textfield-12.txt b/core/src/test/resources/org/apache/struts2/views/jsp/ui/Textfield-12.txt new file mode 100644 index 000000000..44e9eb373 --- /dev/null +++ b/core/src/test/resources/org/apache/struts2/views/jsp/ui/Textfield-12.txt @@ -0,0 +1,4 @@ + + + + \ No newline at end of file