diff --git a/plugins/junit/pom.xml b/plugins/junit/pom.xml index 1aec449fc..e72b5bd78 100644 --- a/plugins/junit/pom.xml +++ b/plugins/junit/pom.xml @@ -65,26 +65,6 @@ struts2-convention-plugin test - - - - javax.portlet - portlet-api - compile - true - - - - org.apache.struts - struts2-portlet-plugin - true - - - - org.apache.struts - struts2-portlet-mocks-plugin - true - diff --git a/plugins/pom.xml b/plugins/pom.xml index 6ee8c4ba0..b931eeec6 100644 --- a/plugins/pom.xml +++ b/plugins/pom.xml @@ -50,6 +50,7 @@ pell-multipart plexus portlet + portlet-junit portlet-mocks portlet-tiles rest diff --git a/plugins/portlet-junit/README.md b/plugins/portlet-junit/README.md new file mode 100644 index 000000000..afb10b76a --- /dev/null +++ b/plugins/portlet-junit/README.md @@ -0,0 +1,5 @@ +# Struts 2 Portlet JUnit plugin +The Portlet JUnit Plugin supports testing applications that use the Portlet Plugin. + +## Installation +Just drop this plugin JAR into `WEB-INF/lib` folder or add it as a Maven dependency. diff --git a/plugins/portlet-junit/pom.xml b/plugins/portlet-junit/pom.xml new file mode 100644 index 000000000..8f0a9e93c --- /dev/null +++ b/plugins/portlet-junit/pom.xml @@ -0,0 +1,58 @@ + + + + 4.0.0 + + org.apache.struts + struts2-plugins + 6.3.0-SNAPSHOT + + + struts2-portlet-junit-plugin + jar + DEPRECATED: Struts 2 Portlet JUnit Plugin - since 6.4.0 + + + + org.apache.struts + struts2-junit-plugin + + + junit + junit + + + + org.apache.struts + struts2-portlet-plugin + provided + + + org.apache.struts + struts2-portlet-mocks-plugin + + + + + UTF-8 + + diff --git a/plugins/junit/src/main/java/org/apache/struts2/junit/StrutsPortletTestCase.java b/plugins/portlet-junit/src/main/java/org/apache/struts2/junit/StrutsPortletTestCase.java similarity index 82% rename from plugins/junit/src/main/java/org/apache/struts2/junit/StrutsPortletTestCase.java rename to plugins/portlet-junit/src/main/java/org/apache/struts2/junit/StrutsPortletTestCase.java index de7d8da91..ad6fbeefa 100644 --- a/plugins/junit/src/main/java/org/apache/struts2/junit/StrutsPortletTestCase.java +++ b/plugins/portlet-junit/src/main/java/org/apache/struts2/junit/StrutsPortletTestCase.java @@ -35,19 +35,6 @@ import javax.portlet.PortletMode; import java.util.HashMap; import java.util.Map; -/* - * Changes: This is a copy of org.apache.struts2.StrutsPortletTestCase from the Struts 2 portlet-plugin, moved - * into the junit-plugin (same package org.apache.struts2). - * The import order above was changed to alphabetical. - * - * Note: The assumption is that anyone utilizing StrutsPortletTestCase currently from the portlet-plugin will almost - * certainly be using the junit-plugin. Under that assumption, the refactored-move of StrutsPortletTestCase - * should not cause issues for pre-existing usage of StrutsPortletTestCase. - */ - -/** - * Base class used to test action in portlet environment - */ public abstract class StrutsPortletTestCase extends StrutsTestCase { private static final Logger LOG = LogManager.getLogger(StrutsPortletTestCase.class); @@ -95,7 +82,7 @@ public abstract class StrutsPortletTestCase extends StrutsTestCase { * @return Map with session parameters */ private Map createSession() { - return new HashMap(portletRequest.getPortletSession().getAttributeMap()); + return new HashMap<>(portletRequest.getPortletSession().getAttributeMap()); } } diff --git a/plugins/portlet-junit/src/site/site.xml b/plugins/portlet-junit/src/site/site.xml new file mode 100644 index 000000000..54fdcf4f4 --- /dev/null +++ b/plugins/portlet-junit/src/site/site.xml @@ -0,0 +1,56 @@ + + + + + org.apache.maven.skins + maven-fluido-skin + ${fluido-skin.version} + + + Apache Software Foundation + http://www.apache.org/images/asf-logo.gif + http://www.apache.org/ + + + Apache Struts + http://struts.apache.org/img/struts-logo.svg + http://struts.apache.org/ + + + + + + + + + + + + +
+ + Apache Struts, Struts, Apache, the Apache feather logo, and the Apache Struts project + logos are trademarks of The Apache Software Foundation. + ]]> +
+ + diff --git a/plugins/portlet/pom.xml b/plugins/portlet/pom.xml index 025daa863..64e7066e0 100644 --- a/plugins/portlet/pom.xml +++ b/plugins/portlet/pom.xml @@ -66,7 +66,6 @@ javax.portlet portlet-api - provided