From 1efcc938cfd4674db7fa16b260d17e574b4842fc Mon Sep 17 00:00:00 2001 From: Greg Huber Date: Fri, 4 Sep 2020 13:23:15 +0100 Subject: [PATCH] Empty file upload, storeLocation null gives wrong error message. --- .../apache/struts2/interceptor/FileUploadInterceptor.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/core/src/main/java/org/apache/struts2/interceptor/FileUploadInterceptor.java b/core/src/main/java/org/apache/struts2/interceptor/FileUploadInterceptor.java index b6a0fa966..2dba50874 100644 --- a/core/src/main/java/org/apache/struts2/interceptor/FileUploadInterceptor.java +++ b/core/src/main/java/org/apache/struts2/interceptor/FileUploadInterceptor.java @@ -343,6 +343,14 @@ public class FileUploadInterceptor extends AbstractInterceptor { validation.addFieldError(inputName, errMsg); } + if (LOG.isWarnEnabled()) { + LOG.warn(errMsg); + } + } else if (file.getContent() == null) { + String errMsg = getTextMessage(action, "struts.messages.error.uploading", new String[]{filename}); + if (validation != null) { + validation.addFieldError(inputName, errMsg); + } if (LOG.isWarnEnabled()) { LOG.warn(errMsg); }