diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml index 1a7ffde46..b977f9585 100644 --- a/.github/workflows/maven.yml +++ b/.github/workflows/maven.yml @@ -30,18 +30,25 @@ env: jobs: build: - name: Build and Test + name: Build and Test (JDK ${{ matrix.java }})${{ matrix.profile == '-Pjakartaee11' && ' with Jakarta EE 11' || matrix.profile }} runs-on: ubuntu-latest strategy: matrix: - java: [ '17', '21' ] + include: + - java: '17' + profile: '' + - java: '21' + profile: '' + - java: '21' + profile: '-Pjakartaee11' steps: - name: Checkout code uses: actions/checkout@v4 - - uses: actions/setup-java@v4 + - name: Setup Java ${{ matrix.java }} + uses: actions/setup-java@v4 with: distribution: temurin java-version: ${{ matrix.java }} cache: 'maven' - - name: Build with Maven on Java ${{ matrix.java }} - run: mvn -B -V -DskipAssembly verify --no-transfer-progress + - name: Maven Verify on Java ${{ matrix.java }}${{ matrix.profile == '-Pjakartaee11' && ' (Jakarta EE 11)' || matrix.profile }} + run: mvn -B -V -DskipAssembly verify ${{ matrix.profile }} --no-transfer-progress diff --git a/core/src/test/java/org/apache/struts2/dispatcher/multipart/AbstractMultiPartRequestTest.java b/core/src/test/java/org/apache/struts2/dispatcher/multipart/AbstractMultiPartRequestTest.java index 22625cdf9..0b4bd8e56 100644 --- a/core/src/test/java/org/apache/struts2/dispatcher/multipart/AbstractMultiPartRequestTest.java +++ b/core/src/test/java/org/apache/struts2/dispatcher/multipart/AbstractMultiPartRequestTest.java @@ -417,7 +417,6 @@ abstract class AbstractMultiPartRequestTest { assertThat(JakartaServletDiskFileUpload.isMultipartContent(mockRequest)).isTrue(); // when - mockRequest.setCharacterEncoding(null); multiPart.setDefaultEncoding(StandardCharsets.ISO_8859_1.name()); multiPart.parse(mockRequest, tempDir); diff --git a/plugins/tiles/src/main/java/org/apache/tiles/el/ScopeELResolver.java b/plugins/tiles/src/main/java/org/apache/tiles/el/ScopeELResolver.java index bb34179ba..3059c1d41 100644 --- a/plugins/tiles/src/main/java/org/apache/tiles/el/ScopeELResolver.java +++ b/plugins/tiles/src/main/java/org/apache/tiles/el/ScopeELResolver.java @@ -57,7 +57,7 @@ public class ScopeELResolver extends ELResolver { /** * {@inheritDoc} */ - @Override + // @Override // To allow compilation with Maven profile jakartaee11 where this interface method does not exist public Iterator getFeatureDescriptors(ELContext context, Object base) { if (base != null) { return Collections.emptyIterator(); diff --git a/plugins/tiles/src/main/java/org/apache/tiles/el/TilesContextBeanELResolver.java b/plugins/tiles/src/main/java/org/apache/tiles/el/TilesContextBeanELResolver.java index 8412b0574..e7a85e942 100644 --- a/plugins/tiles/src/main/java/org/apache/tiles/el/TilesContextBeanELResolver.java +++ b/plugins/tiles/src/main/java/org/apache/tiles/el/TilesContextBeanELResolver.java @@ -47,7 +47,7 @@ public class TilesContextBeanELResolver extends ELResolver { } /** {@inheritDoc} */ - @Override + // @Override // To allow compilation with Maven profile jakartaee11 where this interface method does not exist public Iterator getFeatureDescriptors(ELContext context, Object base) { List list = new ArrayList<>(); diff --git a/plugins/tiles/src/main/java/org/apache/tiles/el/TilesContextELResolver.java b/plugins/tiles/src/main/java/org/apache/tiles/el/TilesContextELResolver.java index 3fc6738b6..82f0942b7 100644 --- a/plugins/tiles/src/main/java/org/apache/tiles/el/TilesContextELResolver.java +++ b/plugins/tiles/src/main/java/org/apache/tiles/el/TilesContextELResolver.java @@ -70,7 +70,7 @@ public class TilesContextELResolver extends ELResolver { /** * {@inheritDoc} */ - @Override + // @Override // To allow compilation with Maven profile jakartaee11 where this interface method does not exist public Iterator getFeatureDescriptors(ELContext context, Object base) { // only resolve at the root of the context diff --git a/pom.xml b/pom.xml index 5cbe15d48..8cb68b6d4 100644 --- a/pom.xml +++ b/pom.xml @@ -150,6 +150,13 @@ assembly + + jakartaee11 + + 11.0.0-M5 + 7.0.0-M2 + + dependency-check