Commit Graph

2527 Commits

Author SHA1 Message Date
Stefaan Dutry 2fd2cb5f97 add test for parameter with name "value"
Verified that the value parameter is added as the nameValue parameter.
2018-01-04 23:20:45 +01:00
Stefaan Dutry 7df1e67bac add test for setting acceskey
Verified that the value is added to the parameters after they have
been evaluated.
2018-01-04 23:08:12 +01:00
Stefaan Dutry dd76d39224 add tests for getTemplateDir method
Verified that:
- explicit templateDirectory gets precedence
- attribute templateDir gets picked if no explitit one is given
- defaultTemplateDirectory gets picked if there is no explicit one and
    an attribute templateDid
- "template" is returned as default value
2018-01-04 19:39:48 +01:00
Stefaan Dutry 476697f99a add test for buildTemplateName method
Verified that:
- default template name gets picked when no specific one is given
- specific template gets precedence over default one
2018-01-04 18:39:48 +01:00
Stefaan Dutry 0bfdc5e643 add test for mergeTemplate method
Test that a ConfigurationException is thrown when the
TemplateEngineManager returns null instead of a TemplateEngine
instance.
2018-01-04 16:32:21 +01:00
Stefaan Dutry a29051c835 add missing @Override annotation 2018-01-03 22:59:52 +01:00
Stefaan Dutry 7a251ddca9 add curly brackets (formatting)
- add curly brackets around single line conditional statements
2018-01-03 22:53:02 +01:00
Stefaan Dutry 38e3734930 change tabs into spaces (formatting) 2018-01-03 22:50:23 +01:00
Stefaan Dutry fe65910e0e change tabs into spaces (formatting) 2018-01-03 22:44:07 +01:00
Stefaan Dutry 1d0b375afd add curly brackets (formatting)
- add curly brackets around single line conditional statements
- place finally statement on same line as closing catch bracket
2018-01-03 22:26:36 +01:00
Stefaan Dutry 0713da431c add missing @Override annotations 2018-01-03 22:15:54 +01:00
Stefaan Dutry 79951db2aa change tabs into spaces (formatting) 2018-01-03 22:14:07 +01:00
Lukasz Lenart 809d8968ca WW-4903 Adds missing header with license 2018-01-01 09:52:31 +01:00
Lukasz Lenart 033573e8fb WW-4903 Reverts to previous initialise mechanism 2018-01-01 09:50:53 +01:00
Lukasz Lenart 7cdc319b41 WW-4903 Extends test of empty prefix 2017-12-31 15:36:59 +01:00
Lukasz Lenart 7116ac8801 WW-4903 Uses StrutsActionProxyFactory as a default factory 2017-12-28 17:35:27 +01:00
Lukasz Lenart a2710a6f04 WW-4903 Covers fallback to default factory with unit test 2017-12-28 17:34:28 +01:00
Lukasz Lenart 457f7c2f57 WW-4903 Adds a unit test to cover the new functionality 2017-12-28 16:56:30 +01:00
Lukasz Lenart 6fc695970f WW-4903 Uses Initializable to properly initialise the factory 2017-12-28 16:56:09 +01:00
Lukasz Lenart 15e6be1d66 WW-4903 Drops injecting defined factory to avoid mapping exception 2017-12-28 16:24:48 +01:00
Stefaan Dutry fb23b719f2 used char instead of a single character string 2017-12-20 22:08:33 +01:00
Yasser Zamani 004b4981a1 Increases the coverage of DefaultActionInvocation 2017-12-16 19:57:39 +03:30
Lukasz Lenart 8b608e334a Merge pull request #192 from yasserzamani/WW-4873_2
WW-4873 Makes ActionInvocation not serializable and InvocationSessionStore$InvocationContext transient
2017-12-16 10:44:52 +01:00
Lukasz Lenart 278a2112b9 Merge pull request #190 from yasserzamani/WW-4901
WW-4901 Decouples from URL.openConnection implementation of container
2017-12-14 09:18:28 +01:00
Yasser Zamani 2941416a18 WW-4873 Makes InvocationSessionStore$InvocationContext transient 2017-12-14 11:05:05 +03:30
Yasser Zamani 4738d1d802 WW-4873 Makes ActionInvocation not serializable 2017-12-13 19:34:54 +03:30
Yasser Zamani a8ecd9bd29 WW-4900 Fixes BackgroundProcessTest via synchronization 2017-12-13 14:58:54 +03:30
Yasser Zamani 6b131550a6 WW-4900 Reverts BackgroundProcess access modifiers 2017-12-13 13:11:35 +03:30
Yasser Zamani dda3facc26 WW-4900 Makes BackgroundProcess transient 2017-12-13 12:41:22 +03:30
Yasser Zamani d082aaca2a WW-4901 Falls back if JarURLConnection was present already 2017-12-12 16:24:17 +03:30
Yasser Zamani 94758b699c WW-4901 Decouples Struts from URL.openConnection implementation of container 2017-12-12 00:26:44 +03:30
Stefaan Dutry 80698ed516 Merge pull request #186 from sdutry/sonar-entrySet
changed Map iterations to use entrySet when both key and value are used
2017-12-01 20:46:00 +01:00
Lukasz Lenart 9b9bd212ed [maven-release-plugin] prepare for next development iteration 2017-11-29 08:35:58 +01:00
Lukasz Lenart 0856157e27 [maven-release-plugin] prepare release STRUTS_2_5_14_1 2017-11-29 08:35:37 +01:00
Stefaan Dutry 00b5f43c8a changed tabs into spaces 2017-11-15 13:58:15 +01:00
Stefaan Dutry 87967b9f84 changed Map iteration to use entrySet 2017-11-15 13:54:20 +01:00
Lukasz Lenart d36ec579fc [maven-release-plugin] prepare for next development iteration 2017-11-14 07:43:35 +01:00
Lukasz Lenart 04db841358 [maven-release-plugin] prepare release STRUTS_2_5_14 2017-11-14 07:43:14 +01:00
Stefaan Dutry 0bde78cc36 changed Map iterations to use entrySet when both key and value are used 2017-11-13 21:13:27 +01:00
Lukasz Lenart 09ede58150 Merge pull request #185 from yasserzamani/WW-4876-improvement
WW-4876 WW-4841 Parses validators after all injections done
2017-11-13 07:26:21 +01:00
Yasser Zamani 9418cb5e89 WW-4876 WW-4841 Parses validators after all injections done 2017-11-12 15:48:30 +03:30
Stefaan Dutry bfbc17e1ad WW-4713 Added deprecation warnings as preparation to drop searchValueStack attribute from the <s:text/> tag 2017-11-11 15:33:25 +01:00
Lukasz Lenart f5f53a9f82 Merge pull request #173 from yasserzamani/WW-4871
WW-4871 Fixes StringConverter and improves it's tests
2017-11-09 18:05:11 +01:00
Stefaan Dutry a512f98eaa reverted accidental change 2017-11-08 23:08:11 +01:00
Stefaan Dutry cde63169f0 WW-4888 add escaping options to text tag 2017-11-08 23:01:46 +01:00
Yasser Zamani a5db288130 WW-4871 Removes assignment to value parameter 2017-11-08 14:06:57 +03:30
Yasser Zamani e0d83b840f WW-4871 Tests if StringConverter changes float input parameter 2017-11-07 18:06:51 +03:30
Lukasz Lenart d781f71816 Adds missing header with a license 2017-11-07 13:09:10 +01:00
Lukasz Lenart d35ab6d945 Merge pull request #172 from yasserzamani/WW-4869
WW-4869 Fixes JarEntryRevision
2017-11-07 12:48:19 +01:00
Yasser Zamani b60425e534 WW-4871 Documents our manual jdk fix by a TODO 2017-11-05 20:57:31 +03:30