1
0
mirror of synced 2026-08-05 09:47:05 +00:00

Hide utility class constructors

Update all utility classes so that they have a private constructor. This
prevents users from accidentally creating an instance, when they should
just use the static methods directly.

Issue gh-8945
This commit is contained in:
Phillip Webb
2020-07-29 15:15:15 -07:00
committed by Rob Winch
parent 8559447357
commit 01d90c9881
61 changed files with 213 additions and 52 deletions
@@ -30,7 +30,7 @@ import org.springframework.security.web.access.channel.ChannelDecisionManagerImp
* @author Luke Taylor
* @since 3.0
*/
public class ChannelAttributeFactory {
public final class ChannelAttributeFactory {
private static final String OPT_REQUIRES_HTTP = "http";
@@ -38,6 +38,9 @@ public class ChannelAttributeFactory {
private static final String OPT_ANY_CHANNEL = "any";
private ChannelAttributeFactory() {
}
public static List<ConfigAttribute> createChannelAttributes(String requiredChannel) {
String channelConfigAttribute;
@@ -37,6 +37,9 @@ final class OAuth2ClientBeanDefinitionParserUtils {
private static final String ATT_AUTHORIZED_CLIENT_SERVICE_REF = "authorized-client-service-ref";
private OAuth2ClientBeanDefinitionParserUtils() {
}
static BeanMetadataElement getClientRegistrationRepository(Element element) {
BeanMetadataElement clientRegistrationRepository;
String clientRegistrationRepositoryRef = element.getAttribute(ATT_CLIENT_REGISTRATION_REPOSITORY_REF);
@@ -29,7 +29,10 @@ import org.springframework.security.saml2.credentials.Saml2X509Credential.Saml2X
/**
* Preconfigured SAML credentials for SAML integration tests.
*/
public class TestSaml2Credentials {
public final class TestSaml2Credentials {
private TestSaml2Credentials() {
}
static Saml2X509Credential verificationCertificate() {
String certificate = "-----BEGIN CERTIFICATE-----\n"
@@ -26,7 +26,10 @@ import org.springframework.security.core.userdetails.ReactiveUserDetailsService;
* @author Rob Winch
* @since 5.0
*/
public class ServerHttpSecurityConfigurationBuilder {
public final class ServerHttpSecurityConfigurationBuilder {
private ServerHttpSecurityConfigurationBuilder() {
}
public static ServerHttpSecurity http() {
return new ServerHttpSecurityConfiguration().httpSecurity();
@@ -29,13 +29,15 @@ import static org.assertj.core.api.Assertions.assertThat;
*
* @author Josh Cummings
*/
public class SecurityFiltersAssertions {
public final class SecurityFiltersAssertions {
private static Collection<SecurityFilters> ordered = Arrays.asList(SecurityFilters.values());
private SecurityFiltersAssertions() {
}
public static void assertEquals(List<String> filters) {
List<String> expected = ordered.stream().map(SecurityFilters::name).collect(Collectors.toList());
assertThat(filters).isEqualTo(expected);
}