From 1081066d60017f77c8224d2114b59892d4b68e2e Mon Sep 17 00:00:00 2001
From: Isaac Cummings <josh.cummings+zac@gmail.com>
Date: Wed, 16 Oct 2019 09:57:27 -0600
Subject: [PATCH] Polish AuthorityUtils

Changed parameter name to authorities
Added JavaDoc

Fixes gh-4805

Co-authored-by: Everett Irwin <everettirwin77@gmail.com>
---
 .../security/core/authority/AuthorityUtils.java  | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/core/src/main/java/org/springframework/security/core/authority/AuthorityUtils.java b/core/src/main/java/org/springframework/security/core/authority/AuthorityUtils.java
index 4cfe410067..df67a2aba1 100644
--- a/core/src/main/java/org/springframework/security/core/authority/AuthorityUtils.java
+++ b/core/src/main/java/org/springframework/security/core/authority/AuthorityUtils.java
@@ -66,13 +66,19 @@ public abstract class AuthorityUtils {
 		return set;
 	}
 
-	public static List<GrantedAuthority> createAuthorityList(String... roles) {
-		List<GrantedAuthority> authorities = new ArrayList<>(roles.length);
+	/**
+	 * Converts authorities into a List of GrantedAuthority objects.
+	 *
+	 * @param authorities the authorities to convert
+	 * @return a List of GrantedAuthority objects
+	 */
+	public static List<GrantedAuthority> createAuthorityList(String... authorities) {
+		List<GrantedAuthority> grantedAuthorities = new ArrayList<>(authorities.length);
 
-		for (String role : roles) {
-			authorities.add(new SimpleGrantedAuthority(role));
+		for (String authority : authorities) {
+			grantedAuthorities.add(new SimpleGrantedAuthority(authority));
 		}
 
-		return authorities;
+		return grantedAuthorities;
 	}
 }