diff --git a/access/src/main/java/org/springframework/security/access/annotation/Jsr250MethodSecurityMetadataSource.java b/access/src/main/java/org/springframework/security/access/annotation/Jsr250MethodSecurityMetadataSource.java index fc19138609..60d8985e41 100644 --- a/access/src/main/java/org/springframework/security/access/annotation/Jsr250MethodSecurityMetadataSource.java +++ b/access/src/main/java/org/springframework/security/access/annotation/Jsr250MethodSecurityMetadataSource.java @@ -108,7 +108,7 @@ public class Jsr250MethodSecurityMetadataSource extends AbstractFallbackMethodSe if (role == null) { return role; } - if (this.defaultRolePrefix == null || this.defaultRolePrefix.length() == 0) { + if (this.defaultRolePrefix == null || this.defaultRolePrefix.isEmpty()) { return role; } if (role.startsWith(this.defaultRolePrefix)) { diff --git a/cas/src/main/java/org/springframework/security/cas/web/authentication/DefaultServiceAuthenticationDetails.java b/cas/src/main/java/org/springframework/security/cas/web/authentication/DefaultServiceAuthenticationDetails.java index cbfe9825cc..65724b91f7 100644 --- a/cas/src/main/java/org/springframework/security/cas/web/authentication/DefaultServiceAuthenticationDetails.java +++ b/cas/src/main/java/org/springframework/security/cas/web/authentication/DefaultServiceAuthenticationDetails.java @@ -111,7 +111,7 @@ final class DefaultServiceAuthenticationDetails extends WebAuthenticationDetails return null; } String result = artifactPattern.matcher(query).replaceFirst(""); - if (result.length() == 0) { + if (result.isEmpty()) { return null; } // strip off the trailing & only if the artifact was the first query param diff --git a/crypto/src/main/java/org/springframework/security/crypto/password/AbstractValidatingPasswordEncoder.java b/crypto/src/main/java/org/springframework/security/crypto/password/AbstractValidatingPasswordEncoder.java index 930770e4b2..69458a6b64 100644 --- a/crypto/src/main/java/org/springframework/security/crypto/password/AbstractValidatingPasswordEncoder.java +++ b/crypto/src/main/java/org/springframework/security/crypto/password/AbstractValidatingPasswordEncoder.java @@ -32,8 +32,7 @@ public abstract class AbstractValidatingPasswordEncoder implements PasswordEncod @Override public final boolean matches(@Nullable CharSequence rawPassword, @Nullable String encodedPassword) { - if (rawPassword == null || rawPassword.length() == 0 || encodedPassword == null - || encodedPassword.length() == 0) { + if (rawPassword == null || rawPassword.isEmpty() || encodedPassword == null || encodedPassword.isEmpty()) { return false; } return matchesNonNull(rawPassword.toString(), encodedPassword); @@ -43,7 +42,7 @@ public abstract class AbstractValidatingPasswordEncoder implements PasswordEncod @Override public final boolean upgradeEncoding(@Nullable String encodedPassword) { - if (encodedPassword == null || encodedPassword.length() == 0) { + if (encodedPassword == null || encodedPassword.isEmpty()) { return false; } return upgradeEncodingNonNull(encodedPassword); diff --git a/web/src/main/java/org/springframework/security/web/authentication/rememberme/AbstractRememberMeServices.java b/web/src/main/java/org/springframework/security/web/authentication/rememberme/AbstractRememberMeServices.java index bf21ce6a54..8f6fa1b3b2 100644 --- a/web/src/main/java/org/springframework/security/web/authentication/rememberme/AbstractRememberMeServices.java +++ b/web/src/main/java/org/springframework/security/web/authentication/rememberme/AbstractRememberMeServices.java @@ -130,7 +130,7 @@ public abstract class AbstractRememberMeServices return null; } this.logger.debug("Remember-me cookie detected"); - if (rememberMeCookie.length() == 0) { + if (rememberMeCookie.isEmpty()) { this.logger.debug("Cookie was empty"); cancelCookie(request, response); return null; @@ -383,7 +383,7 @@ public abstract class AbstractRememberMeServices private String getCookiePath(HttpServletRequest request) { String contextPath = request.getContextPath(); - return (contextPath.length() > 0) ? contextPath : "/"; + return contextPath.isEmpty() ? "/" : contextPath; } /** diff --git a/web/src/main/java/org/springframework/security/web/firewall/RequestWrapper.java b/web/src/main/java/org/springframework/security/web/firewall/RequestWrapper.java index 59cbab7559..8d35f7a705 100644 --- a/web/src/main/java/org/springframework/security/web/firewall/RequestWrapper.java +++ b/web/src/main/java/org/springframework/security/web/firewall/RequestWrapper.java @@ -57,7 +57,7 @@ final class RequestWrapper extends FirewalledRequest { super(request); this.strippedServletPath = strip(request.getServletPath()); String pathInfo = strip(request.getPathInfo()); - if (pathInfo != null && pathInfo.length() == 0) { + if (pathInfo != null && pathInfo.isEmpty()) { pathInfo = null; } this.strippedPathInfo = pathInfo; diff --git a/web/src/main/java/org/springframework/security/web/savedrequest/DefaultSavedRequest.java b/web/src/main/java/org/springframework/security/web/savedrequest/DefaultSavedRequest.java index a20ade9de3..4cb37019a7 100644 --- a/web/src/main/java/org/springframework/security/web/savedrequest/DefaultSavedRequest.java +++ b/web/src/main/java/org/springframework/security/web/savedrequest/DefaultSavedRequest.java @@ -321,7 +321,7 @@ public class DefaultSavedRequest implements SavedRequest { if (matchingRequestParameterName == null) { return queryString; } - if (queryString == null || queryString.length() == 0) { + if (queryString == null || queryString.isEmpty()) { return matchingRequestParameterName; } return UriComponentsBuilder.newInstance() diff --git a/web/src/main/java/org/springframework/security/web/util/TextEscapeUtils.java b/web/src/main/java/org/springframework/security/web/util/TextEscapeUtils.java index cdca910549..2e0a7d04a9 100644 --- a/web/src/main/java/org/springframework/security/web/util/TextEscapeUtils.java +++ b/web/src/main/java/org/springframework/security/web/util/TextEscapeUtils.java @@ -25,7 +25,7 @@ package org.springframework.security.web.util; public abstract class TextEscapeUtils { public static String escapeEntities(String s) { - if (s == null || s.length() == 0) { + if (s == null || s.isEmpty()) { return s; } StringBuilder sb = new StringBuilder(); diff --git a/web/src/test/java/org/springframework/security/web/firewall/RequestWrapperTests.java b/web/src/test/java/org/springframework/security/web/firewall/RequestWrapperTests.java index c9294e4187..df14f37c1c 100644 --- a/web/src/test/java/org/springframework/security/web/firewall/RequestWrapperTests.java +++ b/web/src/test/java/org/springframework/security/web/firewall/RequestWrapperTests.java @@ -73,7 +73,7 @@ public class RequestWrapperTests { String path = entry.getKey(); String expectedResult = entry.getValue(); // Should be null when stripped value is empty - if (expectedResult.length() == 0) { + if (expectedResult.isEmpty()) { expectedResult = null; } request.setPathInfo(path);