Cwikius-Spring/spring-security
1
0
Fork 0
mirror of synced 2026-05-23 13:53:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes for webauthn tests after JSpecify

Browse Source 
Issue gh-17839
This commit is contained in:
Rob Winch
2025-09-03 14:32:07 -05:00
parent 6a84f96930
commit 24ffda28d8
4 changed files with 50 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
webauthn/src/main/java/org/springframework/security/web/webauthn/api/ImmutableCredentialRecord.java
+1 -1
View File
@@ -211,7 +211,7 @@ public final class ImmutableCredentialRecord implements CredentialRecord {
this.label = other.getLabel();
}
public ImmutableCredentialRecordBuilder credentialType(PublicKeyCredentialType credentialType) {
public ImmutableCredentialRecordBuilder credentialType(@Nullable PublicKeyCredentialType credentialType) {
this.credentialType = credentialType;
return this;
}
webauthn/src/main/java/org/springframework/security/web/webauthn/api/PublicKeyCredential.java
+3 -4
View File
@@ -38,7 +38,7 @@ public final class PublicKeyCredential<R extends AuthenticatorResponse> implemen
private final String id;
private final PublicKeyCredentialType type;
private final @Nullable PublicKeyCredentialType type;
private final Bytes rawId;
@@ -48,7 +48,7 @@ public final class PublicKeyCredential<R extends AuthenticatorResponse> implemen
private final @Nullable AuthenticationExtensionsClientOutputs clientExtensionResults;
private PublicKeyCredential(String id, PublicKeyCredentialType type, Bytes rawId, R response,
private PublicKeyCredential(String id, @Nullable PublicKeyCredentialType type, Bytes rawId, R response,
@Nullable AuthenticatorAttachment authenticatorAttachment,
@Nullable AuthenticationExtensionsClientOutputs clientExtensionResults) {
this.id = id;
@@ -77,7 +77,7 @@ public final class PublicKeyCredential<R extends AuthenticatorResponse> implemen
* specifies the credential type represented by this object.
* @return the credential type
*/
public PublicKeyCredentialType getType() {
public @Nullable PublicKeyCredentialType getType() {
return this.type;
}
@@ -228,7 +228,6 @@ public final class PublicKeyCredential<R extends AuthenticatorResponse> implemen
*/
public PublicKeyCredential<R> build() {
Assert.notNull(this.id, "id cannot be null");
Assert.notNull(this.type, "type cannot be null");
Assert.notNull(this.rawId, "rawId cannot be null");
Assert.notNull(this.response, "response cannot be null");
return new PublicKeyCredential(this.id, this.type, this.rawId, this.response, this.authenticatorAttachment,