Cwikius-Spring/spring-security
1
0
Fork 0
mirror of synced 2026-05-22 21:33:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clarify Nullability on Saml2AuthenticationRequestRepository

Browse Source 
Issue gh-17823

Signed-off-by: Josh Cummings <3627351+jzheaux@users.noreply.github.com>
This commit is contained in:
Josh Cummings
2026-03-11 16:51:48 -06:00
parent ddb825f7a5
commit 266d2608f1
3 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/web/CacheSaml2AuthenticationRequestRepository.java
+1 -1
View File
@@ -51,7 +51,7 @@ public final class CacheSaml2AuthenticationRequestRepository
} }
@Override @Override
public void saveAuthenticationRequest(@Nullable AbstractSaml2AuthenticationRequest authenticationRequest, public void saveAuthenticationRequest(AbstractSaml2AuthenticationRequest authenticationRequest,
HttpServletRequest request, HttpServletResponse response) { HttpServletRequest request, HttpServletResponse response) {
Assert.notNull(authenticationRequest, "authenticationRequest must not be null"); Assert.notNull(authenticationRequest, "authenticationRequest must not be null");
String relayState = request.getParameter(Saml2ParameterNames.RELAY_STATE); String relayState = request.getParameter(Saml2ParameterNames.RELAY_STATE);
saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/web/HttpSessionSaml2AuthenticationRequestRepository.java
+1 -1
View File
@@ -50,7 +50,7 @@ public class HttpSessionSaml2AuthenticationRequestRepository
} }
@Override @Override
public void saveAuthenticationRequest(@Nullable AbstractSaml2AuthenticationRequest authenticationRequest, public void saveAuthenticationRequest(AbstractSaml2AuthenticationRequest authenticationRequest,
HttpServletRequest request, HttpServletResponse response) { HttpServletRequest request, HttpServletResponse response) {
if (authenticationRequest == null) { if (authenticationRequest == null) {
removeAuthenticationRequest(request, response); removeAuthenticationRequest(request, response);
saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/web/Saml2AuthenticationRequestRepository.java
+2 -4
View File
@@ -42,13 +42,11 @@ public interface Saml2AuthenticationRequestRepository<T extends AbstractSaml2Aut
/** /**
* Saves the current authentication request using the {@link HttpServletRequest} and * Saves the current authentication request using the {@link HttpServletRequest} and
* {@link HttpServletResponse} * {@link HttpServletResponse}
* @param authenticationRequest the {@link AbstractSaml2AuthenticationRequest}, if * @param authenticationRequest the {@link AbstractSaml2AuthenticationRequest}
* {@code null}, then remove
* @param request the current request * @param request the current request
* @param response the current response * @param response the current response
*/ */
void saveAuthenticationRequest(@Nullable T authenticationRequest, HttpServletRequest request, void saveAuthenticationRequest(T authenticationRequest, HttpServletRequest request, HttpServletResponse response);
HttpServletResponse response);
/** /**
* Removes the authentication request using the {@link HttpServletRequest} and * Removes the authentication request using the {@link HttpServletRequest} and