From 48ff518a41bc1174fac7f5deaa5e5a9c60b37f82 Mon Sep 17 00:00:00 2001 From: Jitendra Singh Date: Tue, 4 Oct 2016 00:59:06 +0530 Subject: [PATCH] Fix Jackson 2.7+ UnmodifiableSetDeserializer added which will ensure Collection$UnmodifiableSet deserialize properly with jackson-databind 2.7+ Fixes gh-4073 --- .../jackson2/UnmodifiableSetDeserializer.java | 61 +++++++++++++++++++ .../jackson2/UnmodifiableSetMixin.java | 3 + 2 files changed, 64 insertions(+) create mode 100644 core/src/main/java/org/springframework/security/jackson2/UnmodifiableSetDeserializer.java diff --git a/core/src/main/java/org/springframework/security/jackson2/UnmodifiableSetDeserializer.java b/core/src/main/java/org/springframework/security/jackson2/UnmodifiableSetDeserializer.java new file mode 100644 index 0000000000..73cba239f7 --- /dev/null +++ b/core/src/main/java/org/springframework/security/jackson2/UnmodifiableSetDeserializer.java @@ -0,0 +1,61 @@ +/* + * Copyright 2015-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.springframework.security.jackson2; + +import com.fasterxml.jackson.core.JsonParser; +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.DeserializationContext; +import com.fasterxml.jackson.databind.JsonDeserializer; +import com.fasterxml.jackson.databind.JsonNode; +import com.fasterxml.jackson.databind.ObjectMapper; +import com.fasterxml.jackson.databind.node.ArrayNode; + +import java.io.IOException; +import java.util.Collections; +import java.util.HashSet; +import java.util.Iterator; +import java.util.Set; + +/** + * Custom deserializer for {@link UnmodifiableSetMixin}. + * + * @author Jitendra Singh + * @see UnmodifiableSetMixin + * @since 4.2 + */ +class UnmodifiableSetDeserializer extends JsonDeserializer { + + @Override + public Set deserialize(JsonParser jp, DeserializationContext ctxt) throws IOException, JsonProcessingException { + ObjectMapper mapper = (ObjectMapper) jp.getCodec(); + JsonNode node = mapper.readTree(jp); + Set resultSet = new HashSet(); + if (node != null) { + if (node instanceof ArrayNode) { + ArrayNode arrayNode = (ArrayNode) node; + Iterator nodeIterator = arrayNode.iterator(); + while (nodeIterator.hasNext()) { + JsonNode elementNode = nodeIterator.next(); + resultSet.add(mapper.readValue(elementNode.toString(), Object.class)); + } + } else { + resultSet.add(mapper.readValue(node.toString(), Object.class)); + } + } + return Collections.unmodifiableSet(resultSet); + } +} diff --git a/core/src/main/java/org/springframework/security/jackson2/UnmodifiableSetMixin.java b/core/src/main/java/org/springframework/security/jackson2/UnmodifiableSetMixin.java index 746160b90b..e2054eb835 100644 --- a/core/src/main/java/org/springframework/security/jackson2/UnmodifiableSetMixin.java +++ b/core/src/main/java/org/springframework/security/jackson2/UnmodifiableSetMixin.java @@ -18,6 +18,7 @@ package org.springframework.security.jackson2; import com.fasterxml.jackson.annotation.JsonCreator; import com.fasterxml.jackson.annotation.JsonTypeInfo; +import com.fasterxml.jackson.databind.annotation.JsonDeserialize; import java.util.Set; @@ -31,11 +32,13 @@ import java.util.Set; * * * @author Jitendra Singh + * @see UnmodifiableSetDeserializer * @see CoreJackson2Module * @see SecurityJacksonModules * @since 4.2 */ @JsonTypeInfo(use = JsonTypeInfo.Id.CLASS, include = JsonTypeInfo.As.PROPERTY) +@JsonDeserialize(using = UnmodifiableSetDeserializer.class) class UnmodifiableSetMixin { /**