diff --git a/core/pom.xml b/core/pom.xml index 97678e8493..f627627c87 100644 --- a/core/pom.xml +++ b/core/pom.xml @@ -44,11 +44,6 @@ 2.0.11 true - - commons-lang - commons-lang - 2.1 - commons-logging commons-logging diff --git a/core/src/main/java/org/acegisecurity/acl/basic/NamedEntityObjectIdentity.java b/core/src/main/java/org/acegisecurity/acl/basic/NamedEntityObjectIdentity.java index 775ee5dc18..5b2e96756e 100644 --- a/core/src/main/java/org/acegisecurity/acl/basic/NamedEntityObjectIdentity.java +++ b/core/src/main/java/org/acegisecurity/acl/basic/NamedEntityObjectIdentity.java @@ -15,9 +15,8 @@ package org.acegisecurity.acl.basic; -import org.apache.commons.lang.ClassUtils; - import org.springframework.util.Assert; +import org.springframework.util.ClassUtils; import java.lang.reflect.InvocationTargetException; import java.lang.reflect.Method; @@ -66,10 +65,10 @@ public class NamedEntityObjectIdentity implements AclObjectIdentity { throws IllegalAccessException, InvocationTargetException { Assert.notNull(object, "object cannot be null"); - this.classname = (object.getClass().getPackage() == null) - ? ClassUtils.getShortClassName(object.getClass()) - : (object.getClass().getPackage().getName() + "." - + ClassUtils.getShortClassName(object.getClass())); + this.classname = (getPackageName(object.getClass().getName()) == null) + ? ClassUtils.getShortName(object.getClass()) + : getPackageName(object.getClass().getName() + "." + + ClassUtils.getShortName(object.getClass())); Class clazz = object.getClass(); @@ -134,6 +133,18 @@ public class NamedEntityObjectIdentity implements AclObjectIdentity { return id; } + private String getPackageName(String className) { + Assert.hasLength(className, "class name must not be empty"); + + int lastDotIndex = className.lastIndexOf("."); + + if (lastDotIndex == -1) { + return null; + } + + return className.substring(0, lastDotIndex); + } + /** * Important so caching operates properly. * diff --git a/project.xml b/project.xml index ab6b67f1c5..8f23f1661d 100644 --- a/project.xml +++ b/project.xml @@ -211,16 +211,6 @@ true - - commons-lang - commons-lang - 2.1 - jar - http://jakarta.apache.org/commons - - true - - commons-logging commons-logging