From 54d0a263de837b4924b49a249e357bbc011e2287 Mon Sep 17 00:00:00 2001
From: Luke Taylor <luke.taylor@springsource.com>
Date: Tue, 2 Nov 2010 19:50:40 +0000
Subject: [PATCH] SEC-1590: Removed
 WebAuthenticatioDetails.doPopulateAdditionalInformation() method which is
 caled from superclass constructor.

---
 .../web/authentication/WebAuthenticationDetails.java   | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/web/src/main/java/org/springframework/security/web/authentication/WebAuthenticationDetails.java b/web/src/main/java/org/springframework/security/web/authentication/WebAuthenticationDetails.java
index 04aa918d9b..291383be50 100644
--- a/web/src/main/java/org/springframework/security/web/authentication/WebAuthenticationDetails.java
+++ b/web/src/main/java/org/springframework/security/web/authentication/WebAuthenticationDetails.java
@@ -24,6 +24,7 @@ import javax.servlet.http.HttpSession;
  * A holder of selected HTTP details related to a web authentication request.
  *
  * @author Ben Alex
+ * @author Luke Taylor
  */
 public class WebAuthenticationDetails implements Serializable {
     //~ Instance fields ================================================================================================
@@ -44,19 +45,10 @@ public class WebAuthenticationDetails implements Serializable {
 
         HttpSession session = request.getSession(false);
         this.sessionId = (session != null) ? session.getId() : null;
-
-        doPopulateAdditionalInformation(request);
     }
 
     //~ Methods ========================================================================================================
 
-    /**
-     * Provided so that subclasses can populate additional information.
-     *
-     * @param request that the authentication request was received from
-     */
-    protected void doPopulateAdditionalInformation(HttpServletRequest request) {}
-
     public boolean equals(Object obj) {
         if (obj instanceof WebAuthenticationDetails) {
             WebAuthenticationDetails rhs = (WebAuthenticationDetails) obj;