From 67c3ceb61145235d68015abdec9a1766eefd20fc Mon Sep 17 00:00:00 2001 From: Joe Grandja <10884212+jgrandja@users.noreply.github.com> Date: Wed, 15 Oct 2025 14:52:55 -0400 Subject: [PATCH] Fix NullAway error Related https://github.com/spring-projects/spring-framework/pull/35629 --- .../springframework/security/web/FormPostRedirectStrategy.java | 2 +- .../security/web/server/FormPostServerRedirectStrategy.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/web/src/main/java/org/springframework/security/web/FormPostRedirectStrategy.java b/web/src/main/java/org/springframework/security/web/FormPostRedirectStrategy.java index e6a2aff459..584730cdcc 100644 --- a/web/src/main/java/org/springframework/security/web/FormPostRedirectStrategy.java +++ b/web/src/main/java/org/springframework/security/web/FormPostRedirectStrategy.java @@ -101,7 +101,7 @@ public final class FormPostRedirectStrategy implements RedirectStrategy { // @formatter:off final String html = REDIRECT_PAGE_TEMPLATE // Clear the query string as we don't want that to be part of the form action URL - .replace("{{action}}", HtmlUtils.htmlEscape(uriComponentsBuilder.query(null).build().toUriString())) + .replace("{{action}}", HtmlUtils.htmlEscape(uriComponentsBuilder.replaceQuery(null).build().toUriString())) .replace("{{params}}", hiddenInputsHtmlBuilder.toString()) .replace("{{nonce}}", HtmlUtils.htmlEscape(nonce)); // @formatter:on diff --git a/web/src/main/java/org/springframework/security/web/server/FormPostServerRedirectStrategy.java b/web/src/main/java/org/springframework/security/web/server/FormPostServerRedirectStrategy.java index 96b36a1d62..9c3988602e 100644 --- a/web/src/main/java/org/springframework/security/web/server/FormPostServerRedirectStrategy.java +++ b/web/src/main/java/org/springframework/security/web/server/FormPostServerRedirectStrategy.java @@ -105,7 +105,7 @@ public final class FormPostServerRedirectStrategy implements ServerRedirectStrat // @formatter:off final String html = REDIRECT_PAGE_TEMPLATE // Clear the query string as we don't want that to be part of the form action URL - .replace("{{action}}", HtmlUtils.htmlEscape(uriComponentsBuilder.query(null).build().toUriString())) + .replace("{{action}}", HtmlUtils.htmlEscape(uriComponentsBuilder.replaceQuery(null).build().toUriString())) .replace("{{params}}", hiddenInputsHtmlBuilder.toString()) .replace("{{nonce}}", HtmlUtils.htmlEscape(nonce)); // @formatter:on