From 7e63fe735745c77a051a71ff089a7edcf0e85725 Mon Sep 17 00:00:00 2001 From: Luke Taylor Date: Wed, 23 Apr 2008 00:41:52 +0000 Subject: [PATCH] SEC-790: DefaultLoginPageGeneratingFilter should be a better HTTP citizen http://jira.springframework.org/browse/SEC-790. Applied submitted patch. --- .../ui/webapp/DefaultLoginPageGeneratingFilter.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/core/src/main/java/org/springframework/security/ui/webapp/DefaultLoginPageGeneratingFilter.java b/core/src/main/java/org/springframework/security/ui/webapp/DefaultLoginPageGeneratingFilter.java index 3cc5965548..07dc428ec5 100644 --- a/core/src/main/java/org/springframework/security/ui/webapp/DefaultLoginPageGeneratingFilter.java +++ b/core/src/main/java/org/springframework/security/ui/webapp/DefaultLoginPageGeneratingFilter.java @@ -23,6 +23,7 @@ import org.springframework.security.ui.rememberme.AbstractRememberMeServices; * * @author Luke Taylor * @version $Id$ + * @since 2.0 */ public class DefaultLoginPageGeneratingFilter extends SpringSecurityFilter { public static final String DEFAULT_LOGIN_PAGE_URL = "/spring_security_login"; @@ -71,11 +72,14 @@ public class DefaultLoginPageGeneratingFilter extends SpringSecurityFilter { } } } - - + protected void doFilterHttp(HttpServletRequest request, HttpServletResponse response, FilterChain chain) throws IOException, ServletException { if (isLoginUrlRequest(request)) { - response.getOutputStream().print(generateLoginPageHtml(request)); + String loginPageHtml = generateLoginPageHtml(request); + response.setCharacterEncoding("UTF-8"); + response.setContentType("text/html"); + response.setContentLength(loginPageHtml.length()); + response.getOutputStream().print(loginPageHtml); return; }