Add missing @Override annotations

This commit also adds MissingOverrideCheck module to Checkstyle configuration.

web/src/main/java/org/springframework/security/web/FilterChainProxy.java

@@ -168,6 +168,7 @@ public class FilterChainProxy extends GenericFilterBean {
 		filterChainValidator.validate(this);
 	}
 
+	@Override
 	public void doFilter(ServletRequest request, ServletResponse response,
 			FilterChain chain) throws IOException, ServletException {
 		boolean clearContext = request.getAttribute(FILTER_APPLIED) == null;
@@ -271,6 +272,7 @@ public class FilterChainProxy extends GenericFilterBean {
 		this.firewall = firewall;
 	}
 
+	@Override
 	public String toString() {
 		StringBuilder sb = new StringBuilder();
 		sb.append("FilterChainProxy[");
@@ -303,6 +305,7 @@ public class FilterChainProxy extends GenericFilterBean {
 			this.firewalledRequest = firewalledRequest;
 		}
 
+		@Override
 		public void doFilter(ServletRequest request, ServletResponse response)
 				throws IOException, ServletException {
 			if (currentPosition == size) {
@@ -338,6 +341,7 @@ public class FilterChainProxy extends GenericFilterBean {
 	}
 
 	private static class NullFilterChainValidator implements FilterChainValidator {
+		@Override
 		public void validate(FilterChainProxy filterChainProxy) {
 		}
 	}

web/src/main/java/org/springframework/security/web/access/intercept/RequestKey.java

@@ -40,6 +40,7 @@ public class RequestKey {
 		return method;
 	}
 
+	@Override
 	public int hashCode() {
 		int code = 31;
 		code ^= url.hashCode();
@@ -51,6 +52,7 @@ public class RequestKey {
 		return code;
 	}
 
+	@Override
 	public boolean equals(Object obj) {
 		if (!(obj instanceof RequestKey)) {
 			return false;
@@ -69,6 +71,7 @@ public class RequestKey {
 		return method.equals(key.method);
 	}
 
+	@Override
 	public String toString() {
 		StringBuilder sb = new StringBuilder(url.length() + 7);
 		sb.append("[");

web/src/main/java/org/springframework/security/web/authentication/DelegatingAuthenticationFailureHandler.java

@@ -65,6 +65,7 @@ public class DelegatingAuthenticationFailureHandler implements
 	/**
 	 * {@inheritDoc}
 	 */
+	@Override
 	public void onAuthenticationFailure(HttpServletRequest request,
 			HttpServletResponse response, AuthenticationException exception)
 			throws IOException, ServletException {

web/src/main/java/org/springframework/security/web/authentication/WebAuthenticationDetails.java

@@ -68,6 +68,7 @@ public class WebAuthenticationDetails implements Serializable {
 	// ~ Methods
 	// ========================================================================================================
 
+	@Override
 	public boolean equals(Object obj) {
 		if (obj instanceof WebAuthenticationDetails) {
 			WebAuthenticationDetails rhs = (WebAuthenticationDetails) obj;
@@ -125,6 +126,7 @@ public class WebAuthenticationDetails implements Serializable {
 		return sessionId;
 	}
 
+	@Override
 	public int hashCode() {
 		int code = 7654;
 
@@ -139,6 +141,7 @@ public class WebAuthenticationDetails implements Serializable {
 		return code;
 	}
 
+	@Override
 	public String toString() {
 		StringBuilder sb = new StringBuilder();
 		sb.append(super.toString()).append(": ");

web/src/main/java/org/springframework/security/web/authentication/preauth/PreAuthenticatedGrantedAuthoritiesWebAuthenticationDetails.java

@@ -47,10 +47,12 @@ public class PreAuthenticatedGrantedAuthoritiesWebAuthenticationDetails extends
 		this.authorities = Collections.unmodifiableList(temp);
 	}
 
+	@Override
 	public List<GrantedAuthority> getGrantedAuthorities() {
 		return authorities;
 	}
 
+	@Override
 	public String toString() {
 		StringBuilder sb = new StringBuilder();
 		sb.append(super.toString()).append("; ");

web/src/main/java/org/springframework/security/web/authentication/rememberme/AbstractRememberMeServices.java

@@ -98,6 +98,7 @@ public abstract class AbstractRememberMeServices implements RememberMeServices,
 				boolean.class);
 	}
 
+	@Override
 	public void afterPropertiesSet() throws Exception {
 		Assert.hasLength(key, "key cannot be empty or null");
 		Assert.notNull(userDetailsService, "A UserDetailsService is required");
@@ -111,6 +112,7 @@ public abstract class AbstractRememberMeServices implements RememberMeServices,
 	 * The returned username is then used to load the UserDetails object for the user,
 	 * which in turn is used to create a valid authentication token.
 	 */
+	@Override
 	public final Authentication autoLogin(HttpServletRequest request,
 			HttpServletResponse response) {
 		String rememberMeCookie = extractRememberMeCookie(request);
@@ -282,6 +284,7 @@ public abstract class AbstractRememberMeServices implements RememberMeServices,
 		return sb.toString();
 	}
 
+	@Override
 	public final void loginFail(HttpServletRequest request, HttpServletResponse response) {
 		logger.debug("Interactive login attempt was unsuccessful.");
 		cancelCookie(request, response);
@@ -300,6 +303,7 @@ public abstract class AbstractRememberMeServices implements RememberMeServices,
 	 * true, calls <tt>onLoginSucces</tt>.
 	 * </p>
 	 */
+	@Override
 	public final void loginSuccess(HttpServletRequest request,
 			HttpServletResponse response, Authentication successfulAuthentication) {
 
@@ -439,6 +443,7 @@ public abstract class AbstractRememberMeServices implements RememberMeServices,
 	 * Implementation of {@code LogoutHandler}. Default behaviour is to call
 	 * {@code cancelCookie()}.
 	 */
+	@Override
 	public void logout(HttpServletRequest request, HttpServletResponse response,
 			Authentication authentication) {
 		if (logger.isDebugEnabled()) {

web/src/main/java/org/springframework/security/web/authentication/switchuser/SwitchUserGrantedAuthority.java

@@ -60,14 +60,17 @@ public final class SwitchUserGrantedAuthority implements GrantedAuthority {
 		return source;
 	}
 
+	@Override
 	public String getAuthority() {
 		return role;
 	}
 
+	@Override
 	public int hashCode() {
 		return 31 ^ source.hashCode() ^ role.hashCode();
 	}
 
+	@Override
 	public boolean equals(Object obj) {
 		if (this == obj) {
 			return true;
@@ -81,6 +84,7 @@ public final class SwitchUserGrantedAuthority implements GrantedAuthority {
 		return false;
 	}
 
+	@Override
 	public String toString() {
 		return "Switch User Authority [" + role + "," + source + "]";
 	}

web/src/main/java/org/springframework/security/web/header/Header.java

@@ -77,10 +77,12 @@ public final class Header {
 		return this.headerValues.equals(header.headerValues);
 	}
 
+	@Override
 	public int hashCode() {
 		return headerName.hashCode() + headerValues.hashCode();
 	}
 
+	@Override
 	public String toString() {
 		return "Header [name: " + headerName + ", values: " + headerValues + "]";
 	}

web/src/main/java/org/springframework/security/web/savedrequest/DefaultSavedRequest.java

@@ -264,6 +264,7 @@ public class DefaultSavedRequest implements SavedRequest {
 		return contextPath;
 	}
 
+	@Override
 	public List<Cookie> getCookies() {
 		List<Cookie> cookieList = new ArrayList<Cookie>(cookies.size());
 
@@ -279,15 +280,18 @@ public class DefaultSavedRequest implements SavedRequest {
 	 *
 	 * @return the full URL of this request
 	 */
+	@Override
 	public String getRedirectUrl() {
 		return UrlUtils.buildFullRequestUrl(scheme, serverName, serverPort, requestURI,
 				queryString);
 	}
 
+	@Override
 	public Collection<String> getHeaderNames() {
 		return headers.keySet();
 	}
 
+	@Override
 	public List<String> getHeaderValues(String name) {
 		List<String> values = headers.get(name);
 
@@ -298,14 +302,17 @@ public class DefaultSavedRequest implements SavedRequest {
 		return values;
 	}
 
+	@Override
 	public List<Locale> getLocales() {
 		return locales;
 	}
 
+	@Override
 	public String getMethod() {
 		return method;
 	}
 
+	@Override
 	public Map<String, String[]> getParameterMap() {
 		return parameters;
 	}
@@ -314,6 +321,7 @@ public class DefaultSavedRequest implements SavedRequest {
 		return parameters.keySet();
 	}
 
+	@Override
 	public String[] getParameterValues(String name) {
 		return parameters.get(name);
 	}
@@ -385,6 +393,7 @@ public class DefaultSavedRequest implements SavedRequest {
 		}
 	}
 
+	@Override
 	public String toString() {
 		return "DefaultSavedRequest[" + getRedirectUrl() + "]";
 	}