Cwikius-Spring/spring-security
1
0
Fork 0
mirror of synced 2026-08-05 01:36:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify boolean returns

Browse Source 
Simplify boolean returns of the form:

	if (b) {
		return true;
	} else {
		return false;
	}

to:

	return b;

Issue gh-8945
This commit is contained in:
Phillip Webb
2020-07-27 20:22:28 -07:00
committed by Rob Winch
parent b69825d925
commit 9a3fa6e812
8 changed files with 8 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/src/main/java/org/springframework/security/access/vote/AuthenticatedVoter.java
+2 -7
View File
@@ -68,14 +68,9 @@ public class AuthenticatedVoter implements AccessDecisionVoter<Object> {
@Override
public boolean supports(ConfigAttribute attribute) {
if ((attribute.getAttribute() != null) && (IS_AUTHENTICATED_FULLY.equals(attribute.getAttribute())
return (attribute.getAttribute() != null) && (IS_AUTHENTICATED_FULLY.equals(attribute.getAttribute())
|| IS_AUTHENTICATED_REMEMBERED.equals(attribute.getAttribute())
|| IS_AUTHENTICATED_ANONYMOUSLY.equals(attribute.getAttribute()))) {
return true;
}
else {
return false;
}
|| IS_AUTHENTICATED_ANONYMOUSLY.equals(attribute.getAttribute()));
}
/**
core/src/main/java/org/springframework/security/access/vote/RoleVoter.java
+1 -6
View File
@@ -68,12 +68,7 @@ public class RoleVoter implements AccessDecisionVoter<Object> {
@Override
public boolean supports(ConfigAttribute attribute) {
if ((attribute.getAttribute() != null) && attribute.getAttribute().startsWith(getRolePrefix())) {
return true;
}
else {
return false;
}
return (attribute.getAttribute() != null) && attribute.getAttribute().startsWith(getRolePrefix());
}
/**
core/src/main/java/org/springframework/security/core/userdetails/memory/UserAttribute.java
+1 -6
View File
@@ -76,12 +76,7 @@ public class UserAttribute {
}
public boolean isValid() {
if ((this.password != null) && (this.authorities.size() > 0)) {
return true;
}
else {
return false;
}
return (this.password != null) && (this.authorities.size() > 0);
}
public void setEnabled(boolean enabled) {
core/src/test/java/org/springframework/security/access/vote/DenyAgainVoter.java
+1 -6
View File
@@ -37,12 +37,7 @@ public class DenyAgainVoter implements AccessDecisionVoter<Object> {
@Override
public boolean supports(ConfigAttribute attribute) {
if ("DENY_AGAIN_FOR_SURE".equals(attribute.getAttribute())) {
return true;
}
else {
return false;
}
return "DENY_AGAIN_FOR_SURE".equals(attribute.getAttribute());
}
@Override
core/src/test/java/org/springframework/security/access/vote/DenyVoter.java
+1 -6
View File
@@ -39,12 +39,7 @@ public class DenyVoter implements AccessDecisionVoter<Object> {
@Override
public boolean supports(ConfigAttribute attribute) {
if ("DENY_FOR_SURE".equals(attribute.getAttribute())) {
return true;
}
else {
return false;
}
return "DENY_FOR_SURE".equals(attribute.getAttribute());
}
@Override