From ab5d416e00d474aa0947deaa849daf9baa9451f0 Mon Sep 17 00:00:00 2001 From: Luke Taylor Date: Sat, 2 Feb 2008 21:41:41 +0000 Subject: [PATCH] SEC-516: Make default SavedRequest a "GET" in test to prevent NPE. --- .../security/ui/AbstractProcessingFilterTests.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/test/java/org/springframework/security/ui/AbstractProcessingFilterTests.java b/core/src/test/java/org/springframework/security/ui/AbstractProcessingFilterTests.java index c0ad502228..5bb301caaa 100644 --- a/core/src/test/java/org/springframework/security/ui/AbstractProcessingFilterTests.java +++ b/core/src/test/java/org/springframework/security/ui/AbstractProcessingFilterTests.java @@ -85,6 +85,7 @@ public class AbstractProcessingFilterTests extends TestCase { private SavedRequest makeSavedRequestForUrl() { MockHttpServletRequest request = createMockRequest(); + request.setMethod("GET"); request.setServletPath("/some_protected_file.html"); request.setScheme("http"); request.setServerName("www.example.com"); @@ -435,8 +436,7 @@ public class AbstractProcessingFilterTests extends TestCase { assertEquals(makeSavedRequestForUrl().getFullRequestUrl(), response.getRedirectedUrl()); assertNotNull(SecurityContextHolder.getContext().getAuthentication()); } - - + public void testSuccessfulAuthenticationCausesRedirectToDefaultTargetUrlOnPOSTSavedRequest() throws Exception { // Setup our HTTP request with a POST method request MockHttpServletRequest request = createMockRequest();