Cwikius-Spring/spring-security
1
0
Fork 0
mirror of synced 2026-08-04 01:07:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor equals method

Browse Source 
Using the accessor method for fields instead of directly access
This commit is contained in:
Seongguk Jeong
2023-07-18 22:11:33 +09:00
committed by Josh Cummings
parent 8df8d4022e
commit bcd4dcc15c
4 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/src/main/java/org/springframework/security/authentication/jaas/JaasGrantedAuthority.java
+2 -3
View File
@@ -58,9 +58,8 @@ public final class JaasGrantedAuthority implements GrantedAuthority {
if (this == obj) {
return true;
}
if (obj instanceof JaasGrantedAuthority) {
JaasGrantedAuthority jga = (JaasGrantedAuthority) obj;
return this.role.equals(jga.role) && this.principal.equals(jga.principal);
if (obj instanceof JaasGrantedAuthority jga) {
return this.role.equals(jga.getAuthority()) && this.principal.equals(jga.getPrincipal());
}
return false;
}
core/src/main/java/org/springframework/security/core/authority/SimpleGrantedAuthority.java
+3 -3
View File
@@ -1,5 +1,5 @@
/*
* Copyright 2002-2016 the original author or authors.
* Copyright 2002-2023 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -50,8 +50,8 @@ public final class SimpleGrantedAuthority implements GrantedAuthority {
if (this == obj) {
return true;
}
if (obj instanceof SimpleGrantedAuthority) {
return this.role.equals(((SimpleGrantedAuthority) obj).role);
if (obj instanceof SimpleGrantedAuthority sga) {
return this.role.equals(sga.getAuthority());
}
return false;
}