diff --git a/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/introspection/SpringOpaqueTokenIntrospector.java b/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/introspection/SpringOpaqueTokenIntrospector.java index 6e6b21ad8f..c289ff294a 100644 --- a/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/introspection/SpringOpaqueTokenIntrospector.java +++ b/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/introspection/SpringOpaqueTokenIntrospector.java @@ -22,6 +22,7 @@ import java.util.ArrayList; import java.util.Arrays; import java.util.Collection; import java.util.Collections; +import java.util.LinkedHashMap; import java.util.List; import java.util.Map; @@ -183,16 +184,17 @@ public class SpringOpaqueTokenIntrospector implements OpaqueTokenIntrospector { } private OAuth2TokenIntrospectionClaimAccessor convertClaimsSet(Map claims) { - claims.computeIfPresent(OAuth2TokenIntrospectionClaimNames.AUD, (k, v) -> { + Map converted = new LinkedHashMap<>(claims); + converted.computeIfPresent(OAuth2TokenIntrospectionClaimNames.AUD, (k, v) -> { if (v instanceof String) { return Collections.singletonList(v); } return v; }); - claims.computeIfPresent(OAuth2TokenIntrospectionClaimNames.CLIENT_ID, (k, v) -> v.toString()); - claims.computeIfPresent(OAuth2TokenIntrospectionClaimNames.EXP, + converted.computeIfPresent(OAuth2TokenIntrospectionClaimNames.CLIENT_ID, (k, v) -> v.toString()); + converted.computeIfPresent(OAuth2TokenIntrospectionClaimNames.EXP, (k, v) -> Instant.ofEpochSecond(((Number) v).longValue())); - claims.computeIfPresent(OAuth2TokenIntrospectionClaimNames.IAT, + converted.computeIfPresent(OAuth2TokenIntrospectionClaimNames.IAT, (k, v) -> Instant.ofEpochSecond(((Number) v).longValue())); // RFC-7662 page 7 directs users to RFC-7519 for defining the values of these // issuer fields. @@ -212,12 +214,12 @@ public class SpringOpaqueTokenIntrospector implements OpaqueTokenIntrospector { // may be awkward to debug, we do not want to manipulate this value. Previous // versions of Spring Security // would *only* allow valid URLs, which is not what we wish to achieve here. - claims.computeIfPresent(OAuth2TokenIntrospectionClaimNames.ISS, (k, v) -> v.toString()); - claims.computeIfPresent(OAuth2TokenIntrospectionClaimNames.NBF, + converted.computeIfPresent(OAuth2TokenIntrospectionClaimNames.ISS, (k, v) -> v.toString()); + converted.computeIfPresent(OAuth2TokenIntrospectionClaimNames.NBF, (k, v) -> Instant.ofEpochSecond(((Number) v).longValue())); - claims.computeIfPresent(OAuth2TokenIntrospectionClaimNames.SCOPE, + converted.computeIfPresent(OAuth2TokenIntrospectionClaimNames.SCOPE, (k, v) -> (v instanceof String s) ? new ArrayListFromString(s.split(" ")) : v); - return () -> claims; + return () -> converted; } /** diff --git a/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/introspection/SpringReactiveOpaqueTokenIntrospector.java b/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/introspection/SpringReactiveOpaqueTokenIntrospector.java index 6db7b92dfa..98fae18dfd 100644 --- a/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/introspection/SpringReactiveOpaqueTokenIntrospector.java +++ b/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/introspection/SpringReactiveOpaqueTokenIntrospector.java @@ -22,6 +22,7 @@ import java.util.ArrayList; import java.util.Arrays; import java.util.Collection; import java.util.Collections; +import java.util.LinkedHashMap; import java.util.List; import java.util.Map; @@ -143,16 +144,17 @@ public class SpringReactiveOpaqueTokenIntrospector implements ReactiveOpaqueToke } private OAuth2TokenIntrospectionClaimAccessor convertClaimsSet(Map claims) { - claims.computeIfPresent(OAuth2TokenIntrospectionClaimNames.AUD, (k, v) -> { + Map converted = new LinkedHashMap<>(claims); + converted.computeIfPresent(OAuth2TokenIntrospectionClaimNames.AUD, (k, v) -> { if (v instanceof String) { return Collections.singletonList(v); } return v; }); - claims.computeIfPresent(OAuth2TokenIntrospectionClaimNames.CLIENT_ID, (k, v) -> v.toString()); - claims.computeIfPresent(OAuth2TokenIntrospectionClaimNames.EXP, + converted.computeIfPresent(OAuth2TokenIntrospectionClaimNames.CLIENT_ID, (k, v) -> v.toString()); + converted.computeIfPresent(OAuth2TokenIntrospectionClaimNames.EXP, (k, v) -> Instant.ofEpochSecond(((Number) v).longValue())); - claims.computeIfPresent(OAuth2TokenIntrospectionClaimNames.IAT, + converted.computeIfPresent(OAuth2TokenIntrospectionClaimNames.IAT, (k, v) -> Instant.ofEpochSecond(((Number) v).longValue())); // RFC-7662 page 7 directs users to RFC-7519 for defining the values of these // issuer fields. @@ -172,12 +174,12 @@ public class SpringReactiveOpaqueTokenIntrospector implements ReactiveOpaqueToke // may be awkward to debug, we do not want to manipulate this value. Previous // versions of Spring Security // would *only* allow valid URLs, which is not what we wish to achieve here. - claims.computeIfPresent(OAuth2TokenIntrospectionClaimNames.ISS, (k, v) -> v.toString()); - claims.computeIfPresent(OAuth2TokenIntrospectionClaimNames.NBF, + converted.computeIfPresent(OAuth2TokenIntrospectionClaimNames.ISS, (k, v) -> v.toString()); + converted.computeIfPresent(OAuth2TokenIntrospectionClaimNames.NBF, (k, v) -> Instant.ofEpochSecond(((Number) v).longValue())); - claims.computeIfPresent(OAuth2TokenIntrospectionClaimNames.SCOPE, + converted.computeIfPresent(OAuth2TokenIntrospectionClaimNames.SCOPE, (k, v) -> (v instanceof String s) ? new ArrayListFromString(s.split(" ")) : v); - return () -> claims; + return () -> converted; } private OAuth2IntrospectionException onError(Throwable ex) {