Fix consistency with Nullability Usage

Issue gh-18564

core/src/main/java/org/springframework/security/authentication/ott/OneTimeTokenAuthenticationToken.java

@@ -36,7 +36,7 @@ public class OneTimeTokenAuthenticationToken extends AbstractAuthenticationToken
 	@Serial
 	private static final long serialVersionUID = -8691636031126328365L;
 
-	private @Nullable final Object principal;
+	private final @Nullable Object principal;
 
 	private @Nullable String tokenValue;
 

core/src/main/java/org/springframework/security/authorization/method/MethodInvocationResult.java

@@ -32,7 +32,7 @@ public class MethodInvocationResult {
 
 	private final MethodInvocation methodInvocation;
 
-	private @Nullable final Object result;
+	private final @Nullable Object result;
 
 	/**
 	 * Construct a {@link MethodInvocationResult} with the provided parameters

core/src/test/java/org/springframework/security/authorization/AuthorizationAdvisorProxyFactoryTests.java

@@ -40,7 +40,6 @@ import tools.jackson.databind.json.JsonMapper;
 
 import org.springframework.aop.Pointcut;
 import org.springframework.core.annotation.AnnotationAwareOrderComparator;
-import org.springframework.lang.NonNull;
 import org.springframework.security.access.AccessDeniedException;
 import org.springframework.security.access.prepost.PreAuthorize;
 import org.springframework.security.authentication.TestAuthentication;
@@ -445,7 +444,7 @@ public class AuthorizationAdvisorProxyFactoryTests {
 		}
 
 		@Override
-		public int compareTo(@NonNull User that) {
+		public int compareTo(User that) {
 			return this.id.compareTo(that.getId());
 		}
 
@@ -455,7 +454,6 @@ public class AuthorizationAdvisorProxyFactoryTests {
 
 		List<User> users = List.of(new User("1", "first", "last"));
 
-		@NonNull
 		@Override
 		public Iterator<User> iterator() {
 			return this.users.iterator();

core/src/test/java/org/springframework/security/authorization/ReactiveAuthorizationAdvisorProxyFactoryTests.java

@@ -25,7 +25,6 @@ import reactor.core.publisher.Mono;
 import reactor.test.StepVerifier;
 
 import org.springframework.aop.Pointcut;
-import org.springframework.lang.NonNull;
 import org.springframework.security.access.AccessDeniedException;
 import org.springframework.security.access.prepost.PreAuthorize;
 import org.springframework.security.authentication.TestAuthentication;
@@ -193,7 +192,7 @@ public class ReactiveAuthorizationAdvisorProxyFactoryTests {
 		}
 
 		@Override
-		public int compareTo(@NonNull User that) {
+		public int compareTo(User that) {
 			return this.id.compareTo(that.getId());
 		}
 
@@ -207,7 +206,6 @@ public class ReactiveAuthorizationAdvisorProxyFactoryTests {
 			return Flux.fromIterable(this.users);
 		}
 
-		@NonNull
 		@Override
 		public Iterator<User> iterator() {
 			return this.users.iterator();