1
0
mirror of synced 2026-08-05 01:36:56 +00:00

Refactor strings to static fields. To facilitate unit testing, package

protected visibility was adopted for all element names, attribute names, 
and attribute default values. A public access modifier was used for all 
bean IDs assigned to bean definitions created by the 
BeanDefinitionParsers.
This commit is contained in:
Ben Alex
2007-12-04 07:12:08 +00:00
parent 4e55bd0117
commit d9ec944579
21 changed files with 227 additions and 179 deletions
@@ -38,7 +38,7 @@ public class CustomUserDetailsTests {
@Test
public void testProviderManagerSetup() {
ProviderManager manager = (ProviderManager) appContext.getBean(ConfigUtils.DEFAULT_AUTH_MANAGER_ID);
ProviderManager manager = (ProviderManager) appContext.getBean(BeanIds.AUTHENTICATION_MANAGER);
List providers = manager.getProviders();
assertTrue(providers.size() == 1);
assertTrue(providers.iterator().next() instanceof DaoAuthenticationProvider);
@@ -44,7 +44,7 @@ public class HttpSecurityBeanDefinitionParserTests {
@Test
public void filterChainProxyShouldReturnEmptyFilterListForUnprotectedUrl() {
FilterChainProxy filterChainProxy =
(FilterChainProxy) appContext.getBean(HttpSecurityBeanDefinitionParser.DEFAULT_FILTER_CHAIN_PROXY_ID);
(FilterChainProxy) appContext.getBean(BeanIds.FILTER_CHAIN_PROXY);
List filters = filterChainProxy.getFilters("/unprotected");
@@ -54,7 +54,7 @@ public class HttpSecurityBeanDefinitionParserTests {
@Test
public void filterChainProxyShouldReturnCorrectFilterListForProtectedUrl() {
FilterChainProxy filterChainProxy =
(FilterChainProxy) appContext.getBean(HttpSecurityBeanDefinitionParser.DEFAULT_FILTER_CHAIN_PROXY_ID);
(FilterChainProxy) appContext.getBean(BeanIds.FILTER_CHAIN_PROXY);
List filterList = filterChainProxy.getFilters("/someurl");
@@ -39,7 +39,7 @@ public class JdbcUserDetailsTests {
@Test
public void testProviderManagerSetup() {
ProviderManager manager = (ProviderManager) appContext.getBean(ConfigUtils.DEFAULT_AUTH_MANAGER_ID);
ProviderManager manager = (ProviderManager) appContext.getBean(BeanIds.AUTHENTICATION_MANAGER);
List providers = manager.getProviders();
assertTrue(providers.size() == 1);
assertTrue(providers.iterator().next() instanceof DaoAuthenticationProvider);