diff --git a/cas/src/main/java/org/springframework/security/ui/cas/ServiceProperties.java b/cas/src/main/java/org/springframework/security/cas/ServiceProperties.java
similarity index 98%
rename from cas/src/main/java/org/springframework/security/ui/cas/ServiceProperties.java
rename to cas/src/main/java/org/springframework/security/cas/ServiceProperties.java
index d964bf3b4c..8da38064bb 100644
--- a/cas/src/main/java/org/springframework/security/ui/cas/ServiceProperties.java
+++ b/cas/src/main/java/org/springframework/security/cas/ServiceProperties.java
@@ -13,7 +13,7 @@
* limitations under the License.
*/
-package org.springframework.security.ui.cas;
+package org.springframework.security.cas;
import org.springframework.beans.factory.InitializingBean;
import org.springframework.util.Assert;
diff --git a/cas/src/main/java/org/springframework/security/providers/cas/CasAuthenticationProvider.java b/cas/src/main/java/org/springframework/security/cas/authentication/CasAuthenticationProvider.java
similarity index 97%
rename from cas/src/main/java/org/springframework/security/providers/cas/CasAuthenticationProvider.java
rename to cas/src/main/java/org/springframework/security/cas/authentication/CasAuthenticationProvider.java
index f2e4cb5a67..049b9cfce5 100644
--- a/cas/src/main/java/org/springframework/security/providers/cas/CasAuthenticationProvider.java
+++ b/cas/src/main/java/org/springframework/security/cas/authentication/CasAuthenticationProvider.java
@@ -13,7 +13,7 @@
* limitations under the License.
*/
-package org.springframework.security.providers.cas;
+package org.springframework.security.cas.authentication;
import org.jasig.cas.client.validation.Assertion;
import org.jasig.cas.client.validation.TicketValidationException;
@@ -26,11 +26,11 @@ import org.springframework.security.Authentication;
import org.springframework.security.AuthenticationException;
import org.springframework.security.BadCredentialsException;
import org.springframework.security.SpringSecurityMessageSource;
+import org.springframework.security.cas.ServiceProperties;
+import org.springframework.security.cas.authentication.cache.NullStatelessTicketCache;
+import org.springframework.security.cas.web.CasProcessingFilter;
import org.springframework.security.providers.AuthenticationProvider;
import org.springframework.security.providers.UsernamePasswordAuthenticationToken;
-import org.springframework.security.providers.cas.cache.NullStatelessTicketCache;
-import org.springframework.security.ui.cas.CasProcessingFilter;
-import org.springframework.security.ui.cas.ServiceProperties;
import org.springframework.security.userdetails.UserDetails;
import org.springframework.security.userdetails.UserDetailsChecker;
import org.springframework.security.userdetails.UserDetailsService;
diff --git a/cas/src/main/java/org/springframework/security/providers/cas/CasAuthenticationToken.java b/cas/src/main/java/org/springframework/security/cas/authentication/CasAuthenticationToken.java
similarity index 98%
rename from cas/src/main/java/org/springframework/security/providers/cas/CasAuthenticationToken.java
rename to cas/src/main/java/org/springframework/security/cas/authentication/CasAuthenticationToken.java
index 1a12df32d9..b03921eb21 100644
--- a/cas/src/main/java/org/springframework/security/providers/cas/CasAuthenticationToken.java
+++ b/cas/src/main/java/org/springframework/security/cas/authentication/CasAuthenticationToken.java
@@ -13,7 +13,7 @@
* limitations under the License.
*/
-package org.springframework.security.providers.cas;
+package org.springframework.security.cas.authentication;
import org.jasig.cas.client.validation.Assertion;
import org.springframework.security.GrantedAuthority;
diff --git a/cas/src/main/java/org/springframework/security/providers/cas/StatelessTicketCache.java b/cas/src/main/java/org/springframework/security/cas/authentication/StatelessTicketCache.java
similarity index 98%
rename from cas/src/main/java/org/springframework/security/providers/cas/StatelessTicketCache.java
rename to cas/src/main/java/org/springframework/security/cas/authentication/StatelessTicketCache.java
index ead02975d0..a0500bcb47 100644
--- a/cas/src/main/java/org/springframework/security/providers/cas/StatelessTicketCache.java
+++ b/cas/src/main/java/org/springframework/security/cas/authentication/StatelessTicketCache.java
@@ -13,7 +13,7 @@
* limitations under the License.
*/
-package org.springframework.security.providers.cas;
+package org.springframework.security.cas.authentication;
/**
* Caches CAS service tickets and CAS proxy tickets for stateless connections.
diff --git a/cas/src/main/java/org/springframework/security/providers/cas/cache/EhCacheBasedTicketCache.java b/cas/src/main/java/org/springframework/security/cas/authentication/cache/EhCacheBasedTicketCache.java
similarity index 93%
rename from cas/src/main/java/org/springframework/security/providers/cas/cache/EhCacheBasedTicketCache.java
rename to cas/src/main/java/org/springframework/security/cas/authentication/cache/EhCacheBasedTicketCache.java
index c2310771b5..a160cdabc4 100644
--- a/cas/src/main/java/org/springframework/security/providers/cas/cache/EhCacheBasedTicketCache.java
+++ b/cas/src/main/java/org/springframework/security/cas/authentication/cache/EhCacheBasedTicketCache.java
@@ -13,14 +13,14 @@
* limitations under the License.
*/
-package org.springframework.security.providers.cas.cache;
+package org.springframework.security.cas.authentication.cache;
import net.sf.ehcache.CacheException;
import net.sf.ehcache.Element;
import net.sf.ehcache.Ehcache;
-import org.springframework.security.providers.cas.CasAuthenticationToken;
-import org.springframework.security.providers.cas.StatelessTicketCache;
+import org.springframework.security.cas.authentication.CasAuthenticationToken;
+import org.springframework.security.cas.authentication.StatelessTicketCache;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/cas/src/main/java/org/springframework/security/providers/cas/cache/NullStatelessTicketCache.java b/cas/src/main/java/org/springframework/security/cas/authentication/cache/NullStatelessTicketCache.java
similarity index 84%
rename from cas/src/main/java/org/springframework/security/providers/cas/cache/NullStatelessTicketCache.java
rename to cas/src/main/java/org/springframework/security/cas/authentication/cache/NullStatelessTicketCache.java
index daa8fe1fbe..cc9f83ecf9 100644
--- a/cas/src/main/java/org/springframework/security/providers/cas/cache/NullStatelessTicketCache.java
+++ b/cas/src/main/java/org/springframework/security/cas/authentication/cache/NullStatelessTicketCache.java
@@ -12,11 +12,11 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.springframework.security.providers.cas.cache;
+package org.springframework.security.cas.authentication.cache;
-import org.springframework.security.providers.cas.CasAuthenticationProvider;
-import org.springframework.security.providers.cas.CasAuthenticationToken;
-import org.springframework.security.providers.cas.StatelessTicketCache;
+import org.springframework.security.cas.authentication.CasAuthenticationProvider;
+import org.springframework.security.cas.authentication.CasAuthenticationToken;
+import org.springframework.security.cas.authentication.StatelessTicketCache;
/**
* Implementation of @link {@link StatelessTicketCache} that has no backing cache. Useful
diff --git a/cas/src/main/java/org/springframework/security/providers/cas/cache/package.html b/cas/src/main/java/org/springframework/security/cas/authentication/cache/package.html
similarity index 100%
rename from cas/src/main/java/org/springframework/security/providers/cas/cache/package.html
rename to cas/src/main/java/org/springframework/security/cas/authentication/cache/package.html
diff --git a/cas/src/main/java/org/springframework/security/providers/cas/package.html b/cas/src/main/java/org/springframework/security/cas/authentication/package.html
similarity index 100%
rename from cas/src/main/java/org/springframework/security/providers/cas/package.html
rename to cas/src/main/java/org/springframework/security/cas/authentication/package.html
diff --git a/cas/src/main/java/org/springframework/security/ui/cas/CasProcessingFilter.java b/cas/src/main/java/org/springframework/security/cas/web/CasProcessingFilter.java
similarity index 97%
rename from cas/src/main/java/org/springframework/security/ui/cas/CasProcessingFilter.java
rename to cas/src/main/java/org/springframework/security/cas/web/CasProcessingFilter.java
index 56456cad21..a2c4923093 100644
--- a/cas/src/main/java/org/springframework/security/ui/cas/CasProcessingFilter.java
+++ b/cas/src/main/java/org/springframework/security/cas/web/CasProcessingFilter.java
@@ -13,7 +13,7 @@
* limitations under the License.
*/
-package org.springframework.security.ui.cas;
+package org.springframework.security.cas.web;
import java.io.IOException;
@@ -23,10 +23,11 @@ import org.jasig.cas.client.validation.TicketValidator;
import org.springframework.security.Authentication;
import org.springframework.security.AuthenticationException;
+import org.springframework.security.cas.ServiceProperties;
import org.springframework.security.providers.UsernamePasswordAuthenticationToken;
-import org.springframework.security.web.FilterChainOrder;
import org.springframework.security.web.authentication.AbstractProcessingFilter;
+import org.springframework.security.web.util.FilterChainOrder;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
diff --git a/cas/src/main/java/org/springframework/security/ui/cas/CasProcessingFilterEntryPoint.java b/cas/src/main/java/org/springframework/security/cas/web/CasProcessingFilterEntryPoint.java
similarity index 97%
rename from cas/src/main/java/org/springframework/security/ui/cas/CasProcessingFilterEntryPoint.java
rename to cas/src/main/java/org/springframework/security/cas/web/CasProcessingFilterEntryPoint.java
index 6bf2507cb4..44b07c3d74 100644
--- a/cas/src/main/java/org/springframework/security/ui/cas/CasProcessingFilterEntryPoint.java
+++ b/cas/src/main/java/org/springframework/security/cas/web/CasProcessingFilterEntryPoint.java
@@ -13,7 +13,7 @@
* limitations under the License.
*/
-package org.springframework.security.ui.cas;
+package org.springframework.security.cas.web;
import java.io.IOException;
@@ -23,6 +23,7 @@ import javax.servlet.http.HttpServletResponse;
import org.jasig.cas.client.util.CommonUtils;
import org.springframework.security.AuthenticationException;
+import org.springframework.security.cas.ServiceProperties;
import org.springframework.security.web.AuthenticationEntryPoint;
import org.springframework.beans.factory.InitializingBean;
import org.springframework.util.Assert;
diff --git a/cas/src/main/java/org/springframework/security/ui/cas/package.html b/cas/src/main/java/org/springframework/security/cas/web/package.html
similarity index 100%
rename from cas/src/main/java/org/springframework/security/ui/cas/package.html
rename to cas/src/main/java/org/springframework/security/cas/web/package.html
diff --git a/cas/src/test/java/org/springframework/security/providers/cas/CasAuthenticationProviderTests.java b/cas/src/test/java/org/springframework/security/cas/authentication/CasAuthenticationProviderTests.java
similarity index 97%
rename from cas/src/test/java/org/springframework/security/providers/cas/CasAuthenticationProviderTests.java
rename to cas/src/test/java/org/springframework/security/cas/authentication/CasAuthenticationProviderTests.java
index 27668640c9..fe7ca4d2b0 100644
--- a/cas/src/test/java/org/springframework/security/providers/cas/CasAuthenticationProviderTests.java
+++ b/cas/src/test/java/org/springframework/security/cas/authentication/CasAuthenticationProviderTests.java
@@ -13,7 +13,7 @@
* limitations under the License.
*/
-package org.springframework.security.providers.cas;
+package org.springframework.security.cas.authentication;
import org.springframework.security.Authentication;
import org.springframework.security.AuthenticationException;
@@ -21,11 +21,14 @@ import org.springframework.security.BadCredentialsException;
import org.springframework.security.GrantedAuthority;
import org.springframework.security.GrantedAuthorityImpl;
+import org.springframework.security.cas.ServiceProperties;
+import org.springframework.security.cas.authentication.CasAuthenticationProvider;
+import org.springframework.security.cas.authentication.CasAuthenticationToken;
+import org.springframework.security.cas.authentication.StatelessTicketCache;
+import org.springframework.security.cas.web.CasProcessingFilter;
import org.springframework.security.providers.TestingAuthenticationToken;
import org.springframework.security.providers.UsernamePasswordAuthenticationToken;
-import org.springframework.security.ui.cas.CasProcessingFilter;
-import org.springframework.security.ui.cas.ServiceProperties;
import org.springframework.security.userdetails.User;
import org.springframework.security.userdetails.UserDetails;
diff --git a/cas/src/test/java/org/springframework/security/providers/cas/CasAuthenticationTokenTests.java b/cas/src/test/java/org/springframework/security/cas/authentication/CasAuthenticationTokenTests.java
similarity index 98%
rename from cas/src/test/java/org/springframework/security/providers/cas/CasAuthenticationTokenTests.java
rename to cas/src/test/java/org/springframework/security/cas/authentication/CasAuthenticationTokenTests.java
index e7dee5d70d..c14e5367c6 100644
--- a/cas/src/test/java/org/springframework/security/providers/cas/CasAuthenticationTokenTests.java
+++ b/cas/src/test/java/org/springframework/security/cas/authentication/CasAuthenticationTokenTests.java
@@ -13,7 +13,7 @@
* limitations under the License.
*/
-package org.springframework.security.providers.cas;
+package org.springframework.security.cas.authentication;
import java.util.List;
@@ -22,6 +22,7 @@ import junit.framework.TestCase;
import org.jasig.cas.client.validation.Assertion;
import org.jasig.cas.client.validation.AssertionImpl;
import org.springframework.security.GrantedAuthority;
+import org.springframework.security.cas.authentication.CasAuthenticationToken;
import org.springframework.security.providers.UsernamePasswordAuthenticationToken;
import org.springframework.security.userdetails.User;
import org.springframework.security.userdetails.UserDetails;
diff --git a/cas/src/test/java/org/springframework/security/providers/cas/cache/AbstractStatelessTicketCacheTests.java b/cas/src/test/java/org/springframework/security/cas/authentication/cache/AbstractStatelessTicketCacheTests.java
similarity index 84%
rename from cas/src/test/java/org/springframework/security/providers/cas/cache/AbstractStatelessTicketCacheTests.java
rename to cas/src/test/java/org/springframework/security/cas/authentication/cache/AbstractStatelessTicketCacheTests.java
index 3a6be6ffaa..7b4d969614 100644
--- a/cas/src/test/java/org/springframework/security/providers/cas/cache/AbstractStatelessTicketCacheTests.java
+++ b/cas/src/test/java/org/springframework/security/cas/authentication/cache/AbstractStatelessTicketCacheTests.java
@@ -1,11 +1,11 @@
-package org.springframework.security.providers.cas.cache;
+package org.springframework.security.cas.authentication.cache;
import java.util.ArrayList;
import java.util.List;
import org.jasig.cas.client.validation.Assertion;
import org.jasig.cas.client.validation.AssertionImpl;
-import org.springframework.security.providers.cas.CasAuthenticationToken;
+import org.springframework.security.cas.authentication.CasAuthenticationToken;
import org.springframework.security.userdetails.User;
import org.springframework.security.util.AuthorityUtils;
diff --git a/cas/src/test/java/org/springframework/security/providers/cas/cache/EhCacheBasedTicketCacheTests.java b/cas/src/test/java/org/springframework/security/cas/authentication/cache/EhCacheBasedTicketCacheTests.java
similarity index 92%
rename from cas/src/test/java/org/springframework/security/providers/cas/cache/EhCacheBasedTicketCacheTests.java
rename to cas/src/test/java/org/springframework/security/cas/authentication/cache/EhCacheBasedTicketCacheTests.java
index e025e2f804..324fcfe064 100644
--- a/cas/src/test/java/org/springframework/security/providers/cas/cache/EhCacheBasedTicketCacheTests.java
+++ b/cas/src/test/java/org/springframework/security/cas/authentication/cache/EhCacheBasedTicketCacheTests.java
@@ -13,7 +13,7 @@
* limitations under the License.
*/
-package org.springframework.security.providers.cas.cache;
+package org.springframework.security.cas.authentication.cache;
import net.sf.ehcache.Ehcache;
import net.sf.ehcache.CacheManager;
@@ -22,7 +22,8 @@ import net.sf.ehcache.Cache;
import org.junit.Test;
import org.junit.BeforeClass;
import org.junit.AfterClass;
-import org.springframework.security.providers.cas.CasAuthenticationToken;
+import org.springframework.security.cas.authentication.CasAuthenticationToken;
+import org.springframework.security.cas.authentication.cache.EhCacheBasedTicketCache;
import static org.junit.Assert.*;
diff --git a/cas/src/test/java/org/springframework/security/providers/cas/cache/NullStatelessTicketCacheTests.java b/cas/src/test/java/org/springframework/security/cas/authentication/cache/NullStatelessTicketCacheTests.java
similarity index 79%
rename from cas/src/test/java/org/springframework/security/providers/cas/cache/NullStatelessTicketCacheTests.java
rename to cas/src/test/java/org/springframework/security/cas/authentication/cache/NullStatelessTicketCacheTests.java
index 7ab118198b..89677bc3e9 100644
--- a/cas/src/test/java/org/springframework/security/providers/cas/cache/NullStatelessTicketCacheTests.java
+++ b/cas/src/test/java/org/springframework/security/cas/authentication/cache/NullStatelessTicketCacheTests.java
@@ -12,12 +12,13 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.springframework.security.providers.cas.cache;
+package org.springframework.security.cas.authentication.cache;
import org.junit.Test;
-import org.springframework.security.providers.cas.CasAuthenticationToken;
-import org.springframework.security.providers.cas.StatelessTicketCache;
+import org.springframework.security.cas.authentication.CasAuthenticationToken;
+import org.springframework.security.cas.authentication.StatelessTicketCache;
+import org.springframework.security.cas.authentication.cache.NullStatelessTicketCache;
import static org.junit.Assert.*;
diff --git a/cas/src/test/java/org/springframework/security/ui/cas/CasProcessingFilterEntryPointTests.java b/cas/src/test/java/org/springframework/security/cas/web/CasProcessingFilterEntryPointTests.java
similarity index 88%
rename from cas/src/test/java/org/springframework/security/ui/cas/CasProcessingFilterEntryPointTests.java
rename to cas/src/test/java/org/springframework/security/cas/web/CasProcessingFilterEntryPointTests.java
index 12c29089d1..a7858d6ce1 100644
--- a/cas/src/test/java/org/springframework/security/ui/cas/CasProcessingFilterEntryPointTests.java
+++ b/cas/src/test/java/org/springframework/security/cas/web/CasProcessingFilterEntryPointTests.java
@@ -13,12 +13,14 @@
* limitations under the License.
*/
-package org.springframework.security.ui.cas;
+package org.springframework.security.cas.web;
import junit.framework.TestCase;
import org.springframework.mock.web.MockHttpServletRequest;
import org.springframework.mock.web.MockHttpServletResponse;
+import org.springframework.security.cas.ServiceProperties;
+import org.springframework.security.cas.web.CasProcessingFilterEntryPoint;
import java.net.URLEncoder;
@@ -30,26 +32,8 @@ import java.net.URLEncoder;
* @version $Id$
*/
public class CasProcessingFilterEntryPointTests extends TestCase {
- //~ Constructors ===================================================================================================
-
- public CasProcessingFilterEntryPointTests() {
- super();
- }
-
- public CasProcessingFilterEntryPointTests(String arg0) {
- super(arg0);
- }
-
//~ Methods ========================================================================================================
- public static void main(String[] args) {
- junit.textui.TestRunner.run(CasProcessingFilterEntryPointTests.class);
- }
-
- public final void setUp() throws Exception {
- super.setUp();
- }
-
public void testDetectsMissingLoginFormUrl() throws Exception {
CasProcessingFilterEntryPoint ep = new CasProcessingFilterEntryPoint();
ep.setServiceProperties(new ServiceProperties());
diff --git a/cas/src/test/java/org/springframework/security/ui/cas/CasProcessingFilterTests.java b/cas/src/test/java/org/springframework/security/cas/web/CasProcessingFilterTests.java
similarity index 95%
rename from cas/src/test/java/org/springframework/security/ui/cas/CasProcessingFilterTests.java
rename to cas/src/test/java/org/springframework/security/cas/web/CasProcessingFilterTests.java
index e4bfcfb04c..bd7271638c 100644
--- a/cas/src/test/java/org/springframework/security/ui/cas/CasProcessingFilterTests.java
+++ b/cas/src/test/java/org/springframework/security/cas/web/CasProcessingFilterTests.java
@@ -13,13 +13,14 @@
* limitations under the License.
*/
-package org.springframework.security.ui.cas;
+package org.springframework.security.cas.web;
import junit.framework.TestCase;
import org.springframework.security.Authentication;
import org.springframework.security.AuthenticationException;
import org.springframework.security.MockAuthenticationManager;
+import org.springframework.security.cas.web.CasProcessingFilter;
import org.springframework.mock.web.MockHttpServletRequest;
import org.springframework.mock.web.MockHttpServletResponse;
diff --git a/cas/src/test/java/org/springframework/security/ui/cas/ServicePropertiesTests.java b/cas/src/test/java/org/springframework/security/cas/web/ServicePropertiesTests.java
similarity index 77%
rename from cas/src/test/java/org/springframework/security/ui/cas/ServicePropertiesTests.java
rename to cas/src/test/java/org/springframework/security/cas/web/ServicePropertiesTests.java
index 2c456254ba..d939239337 100644
--- a/cas/src/test/java/org/springframework/security/ui/cas/ServicePropertiesTests.java
+++ b/cas/src/test/java/org/springframework/security/cas/web/ServicePropertiesTests.java
@@ -13,7 +13,9 @@
* limitations under the License.
*/
-package org.springframework.security.ui.cas;
+package org.springframework.security.cas.web;
+
+import org.springframework.security.cas.ServiceProperties;
import junit.framework.TestCase;
@@ -25,26 +27,8 @@ import junit.framework.TestCase;
* @version $Id$
*/
public class ServicePropertiesTests extends TestCase {
- //~ Constructors ===================================================================================================
-
- public ServicePropertiesTests() {
- super();
- }
-
- public ServicePropertiesTests(String arg0) {
- super(arg0);
- }
-
//~ Methods ========================================================================================================
- public static void main(String[] args) {
- junit.textui.TestRunner.run(ServicePropertiesTests.class);
- }
-
- public final void setUp() throws Exception {
- super.setUp();
- }
-
public void testDetectsMissingLoginFormUrl() throws Exception {
ServiceProperties sp = new ServiceProperties();
diff --git a/config/src/main/java/org/springframework/security/config/LdapProviderBeanDefinitionParser.java b/config/src/main/java/org/springframework/security/config/LdapProviderBeanDefinitionParser.java
index 8db6996d30..ead989303b 100644
--- a/config/src/main/java/org/springframework/security/config/LdapProviderBeanDefinitionParser.java
+++ b/config/src/main/java/org/springframework/security/config/LdapProviderBeanDefinitionParser.java
@@ -27,9 +27,9 @@ public class LdapProviderBeanDefinitionParser implements BeanDefinitionParser {
private static final String DEF_USER_SEARCH_FILTER = "uid={0}";
- private static final String PROVIDER_CLASS = "org.springframework.security.providers.ldap.LdapAuthenticationProvider";
- private static final String BIND_AUTH_CLASS = "org.springframework.security.providers.ldap.authenticator.BindAuthenticator";
- private static final String PASSWD_AUTH_CLASS = "org.springframework.security.providers.ldap.authenticator.PasswordComparisonAuthenticator";
+ static final String PROVIDER_CLASS = "org.springframework.security.ldap.authentication.LdapAuthenticationProvider";
+ static final String BIND_AUTH_CLASS = "org.springframework.security.ldap.authentication.BindAuthenticator";
+ static final String PASSWD_AUTH_CLASS = "org.springframework.security.ldap.authentication.PasswordComparisonAuthenticator";
public BeanDefinition parse(Element elt, ParserContext parserContext) {
RuntimeBeanReference contextSource = LdapUserServiceBeanDefinitionParser.parseServerReference(elt, parserContext);
diff --git a/config/src/main/java/org/springframework/security/config/LdapUserServiceBeanDefinitionParser.java b/config/src/main/java/org/springframework/security/config/LdapUserServiceBeanDefinitionParser.java
index 836ef87893..2d19f0cc00 100644
--- a/config/src/main/java/org/springframework/security/config/LdapUserServiceBeanDefinitionParser.java
+++ b/config/src/main/java/org/springframework/security/config/LdapUserServiceBeanDefinitionParser.java
@@ -33,13 +33,13 @@ public class LdapUserServiceBeanDefinitionParser extends AbstractUserDetailsServ
static final String OPT_INETORGPERSON = "inetOrgPerson";
public static final String LDAP_SEARCH_CLASS = "org.springframework.security.ldap.search.FilterBasedLdapUserSearch";
- public static final String PERSON_MAPPER_CLASS = "org.springframework.security.userdetails.ldap.PersonContextMapper";
- public static final String INET_ORG_PERSON_MAPPER_CLASS = "org.springframework.security.userdetails.ldap.InetOrgPersonContextMapper";
- public static final String LDAP_USER_MAPPER_CLASS = "org.springframework.security.userdetails.ldap.LdapUserDetailsMapper";
+ public static final String PERSON_MAPPER_CLASS = "org.springframework.security.ldap.userdetails.PersonContextMapper";
+ public static final String INET_ORG_PERSON_MAPPER_CLASS = "org.springframework.security.ldap.userdetails.InetOrgPersonContextMapper";
+ public static final String LDAP_USER_MAPPER_CLASS = "org.springframework.security.ldap.userdetails.LdapUserDetailsMapper";
public static final String LDAP_AUTHORITIES_POPULATOR_CLASS = "org.springframework.security.ldap.populator.DefaultLdapAuthoritiesPopulator";
protected String getBeanClassName(Element element) {
- return "org.springframework.security.userdetails.ldap.LdapUserDetailsService";
+ return "org.springframework.security.ldap.userdetails.LdapUserDetailsService";
}
protected void doParse(Element elt, ParserContext parserContext, BeanDefinitionBuilder builder) {
diff --git a/config/src/main/java/org/springframework/security/config/OrderedFilterBeanDefinitionDecorator.java b/config/src/main/java/org/springframework/security/config/OrderedFilterBeanDefinitionDecorator.java
index bfc679c05e..e9e5114232 100644
--- a/config/src/main/java/org/springframework/security/config/OrderedFilterBeanDefinitionDecorator.java
+++ b/config/src/main/java/org/springframework/security/config/OrderedFilterBeanDefinitionDecorator.java
@@ -15,7 +15,7 @@ import org.springframework.beans.factory.support.BeanDefinitionBuilder;
import org.springframework.beans.factory.xml.BeanDefinitionDecorator;
import org.springframework.beans.factory.xml.ParserContext;
import org.springframework.core.Ordered;
-import org.springframework.security.web.FilterChainOrder;
+import org.springframework.security.web.util.FilterChainOrder;
import org.springframework.util.Assert;
import org.springframework.util.StringUtils;
import org.w3c.dom.Element;
diff --git a/config/src/test/java/org/springframework/security/config/LdapProviderBeanDefinitionParserTests.java b/config/src/test/java/org/springframework/security/config/LdapProviderBeanDefinitionParserTests.java
index 6480b4411c..e6ce24bd80 100644
--- a/config/src/test/java/org/springframework/security/config/LdapProviderBeanDefinitionParserTests.java
+++ b/config/src/test/java/org/springframework/security/config/LdapProviderBeanDefinitionParserTests.java
@@ -1,7 +1,7 @@
package org.springframework.security.config;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.*;
+import static org.springframework.security.config.LdapProviderBeanDefinitionParser.*;
import org.junit.After;
import org.junit.Test;
@@ -9,11 +9,13 @@ import org.springframework.security.Authentication;
import org.springframework.security.config.BeanIds;
import org.springframework.security.config.SecurityConfigurationException;
import org.springframework.security.config.util.InMemoryXmlApplicationContext;
+import org.springframework.security.ldap.authentication.BindAuthenticator;
+import org.springframework.security.ldap.authentication.LdapAuthenticationProvider;
+import org.springframework.security.ldap.authentication.PasswordComparisonAuthenticator;
+import org.springframework.security.ldap.userdetails.InetOrgPersonContextMapper;
+import org.springframework.security.ldap.userdetails.LdapUserDetailsImpl;
import org.springframework.security.providers.ProviderManager;
import org.springframework.security.providers.UsernamePasswordAuthenticationToken;
-import org.springframework.security.providers.ldap.LdapAuthenticationProvider;
-import org.springframework.security.userdetails.ldap.InetOrgPersonContextMapper;
-import org.springframework.security.userdetails.ldap.LdapUserDetailsImpl;
import org.springframework.security.util.FieldUtils;
@@ -32,6 +34,13 @@ public class LdapProviderBeanDefinitionParserTests {
}
}
+ @Test
+ public void beanClassNamesAreCorrect() throws Exception {
+ assertEquals(PROVIDER_CLASS, LdapAuthenticationProvider.class.getName());
+ assertEquals(BIND_AUTH_CLASS, BindAuthenticator.class.getName());
+ assertEquals(PASSWD_AUTH_CLASS, PasswordComparisonAuthenticator.class.getName());
+ }
+
@Test
public void simpleProviderAuthenticatesCorrectly() {
setContext("
@@ -124,7 +125,7 @@ import org.apache.commons.logging.LogFactory; * @author Luke Taylor * @version $Id$ * - * @see org.springframework.security.providers.ldap.authenticator.BindAuthenticator + * @see org.springframework.security.ldap.authentication.BindAuthenticator * @see DefaultLdapAuthoritiesPopulator */ public class LdapAuthenticationProvider implements AuthenticationProvider, MessageSourceAware { diff --git a/ldap/src/main/java/org/springframework/security/providers/ldap/authenticator/PasswordComparisonAuthenticator.java b/ldap/src/main/java/org/springframework/security/ldap/authentication/PasswordComparisonAuthenticator.java similarity index 96% rename from ldap/src/main/java/org/springframework/security/providers/ldap/authenticator/PasswordComparisonAuthenticator.java rename to ldap/src/main/java/org/springframework/security/ldap/authentication/PasswordComparisonAuthenticator.java index b5f3a60faf..6244460d59 100644 --- a/ldap/src/main/java/org/springframework/security/providers/ldap/authenticator/PasswordComparisonAuthenticator.java +++ b/ldap/src/main/java/org/springframework/security/ldap/authentication/PasswordComparisonAuthenticator.java @@ -13,7 +13,7 @@ * limitations under the License. */ -package org.springframework.security.providers.ldap.authenticator; +package org.springframework.security.ldap.authentication; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; @@ -32,7 +32,7 @@ import org.springframework.util.Assert; /** - * An {@link org.springframework.security.providers.ldap.LdapAuthenticator LdapAuthenticator} which compares the login + * An {@link org.springframework.security.ldap.LdapAuthenticator LdapAuthenticator} which compares the login * password with the value stored in the directory using a remote LDAP "compare" operation. * *
diff --git a/ldap/src/main/java/org/springframework/security/providers/ldap/package.html b/ldap/src/main/java/org/springframework/security/ldap/authentication/package.html similarity index 100% rename from ldap/src/main/java/org/springframework/security/providers/ldap/package.html rename to ldap/src/main/java/org/springframework/security/ldap/authentication/package.html diff --git a/ldap/src/main/java/org/springframework/security/userdetails/ldap/InetOrgPerson.java b/ldap/src/main/java/org/springframework/security/ldap/userdetails/InetOrgPerson.java similarity index 96% rename from ldap/src/main/java/org/springframework/security/userdetails/ldap/InetOrgPerson.java rename to ldap/src/main/java/org/springframework/security/ldap/userdetails/InetOrgPerson.java index 50a512e00d..5b4fccbcba 100644 --- a/ldap/src/main/java/org/springframework/security/userdetails/ldap/InetOrgPerson.java +++ b/ldap/src/main/java/org/springframework/security/ldap/userdetails/InetOrgPerson.java @@ -12,7 +12,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.springframework.security.userdetails.ldap; +package org.springframework.security.ldap.userdetails; import org.springframework.ldap.core.DirContextAdapter; import org.springframework.ldap.core.DirContextOperations; diff --git a/ldap/src/main/java/org/springframework/security/userdetails/ldap/InetOrgPersonContextMapper.java b/ldap/src/main/java/org/springframework/security/ldap/userdetails/InetOrgPersonContextMapper.java similarity index 96% rename from ldap/src/main/java/org/springframework/security/userdetails/ldap/InetOrgPersonContextMapper.java rename to ldap/src/main/java/org/springframework/security/ldap/userdetails/InetOrgPersonContextMapper.java index 102903d061..0433ae934d 100644 --- a/ldap/src/main/java/org/springframework/security/userdetails/ldap/InetOrgPersonContextMapper.java +++ b/ldap/src/main/java/org/springframework/security/ldap/userdetails/InetOrgPersonContextMapper.java @@ -12,7 +12,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.springframework.security.userdetails.ldap; +package org.springframework.security.ldap.userdetails; import java.util.List; diff --git a/ldap/src/main/java/org/springframework/security/userdetails/ldap/LdapUserDetails.java b/ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetails.java similarity index 92% rename from ldap/src/main/java/org/springframework/security/userdetails/ldap/LdapUserDetails.java rename to ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetails.java index d9e0250853..ad1f5d9c6f 100644 --- a/ldap/src/main/java/org/springframework/security/userdetails/ldap/LdapUserDetails.java +++ b/ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetails.java @@ -13,7 +13,7 @@ * limitations under the License. */ -package org.springframework.security.userdetails.ldap; +package org.springframework.security.ldap.userdetails; import org.springframework.security.userdetails.UserDetails; diff --git a/ldap/src/main/java/org/springframework/security/userdetails/ldap/LdapUserDetailsImpl.java b/ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetailsImpl.java similarity index 96% rename from ldap/src/main/java/org/springframework/security/userdetails/ldap/LdapUserDetailsImpl.java rename to ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetailsImpl.java index b38a7f2861..5bc08ec36f 100644 --- a/ldap/src/main/java/org/springframework/security/userdetails/ldap/LdapUserDetailsImpl.java +++ b/ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetailsImpl.java @@ -13,7 +13,7 @@ * limitations under the License. */ -package org.springframework.security.userdetails.ldap; +package org.springframework.security.ldap.userdetails; import java.util.ArrayList; import java.util.List; diff --git a/ldap/src/main/java/org/springframework/security/userdetails/ldap/LdapUserDetailsManager.java b/ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetailsManager.java similarity index 97% rename from ldap/src/main/java/org/springframework/security/userdetails/ldap/LdapUserDetailsManager.java rename to ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetailsManager.java index ad03cf0076..a370d593c0 100644 --- a/ldap/src/main/java/org/springframework/security/userdetails/ldap/LdapUserDetailsManager.java +++ b/ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetailsManager.java @@ -12,7 +12,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.springframework.security.userdetails.ldap; +package org.springframework.security.ldap.userdetails; import org.springframework.security.Authentication; import org.springframework.security.BadCredentialsException; diff --git a/ldap/src/main/java/org/springframework/security/userdetails/ldap/LdapUserDetailsMapper.java b/ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetailsMapper.java similarity index 96% rename from ldap/src/main/java/org/springframework/security/userdetails/ldap/LdapUserDetailsMapper.java rename to ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetailsMapper.java index fddc4aa700..3f2f18054d 100644 --- a/ldap/src/main/java/org/springframework/security/userdetails/ldap/LdapUserDetailsMapper.java +++ b/ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetailsMapper.java @@ -13,7 +13,7 @@ * limitations under the License. */ -package org.springframework.security.userdetails.ldap; +package org.springframework.security.ldap.userdetails; import java.util.List; diff --git a/ldap/src/main/java/org/springframework/security/userdetails/ldap/LdapUserDetailsService.java b/ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetailsService.java similarity index 97% rename from ldap/src/main/java/org/springframework/security/userdetails/ldap/LdapUserDetailsService.java rename to ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetailsService.java index e0884d723b..69329fe268 100644 --- a/ldap/src/main/java/org/springframework/security/userdetails/ldap/LdapUserDetailsService.java +++ b/ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetailsService.java @@ -1,4 +1,4 @@ -package org.springframework.security.userdetails.ldap; +package org.springframework.security.ldap.userdetails; import org.springframework.ldap.core.DirContextOperations; import org.springframework.security.ldap.LdapAuthoritiesPopulator; diff --git a/ldap/src/main/java/org/springframework/security/userdetails/ldap/Person.java b/ldap/src/main/java/org/springframework/security/ldap/userdetails/Person.java similarity index 98% rename from ldap/src/main/java/org/springframework/security/userdetails/ldap/Person.java rename to ldap/src/main/java/org/springframework/security/ldap/userdetails/Person.java index aaadec18bd..fe1133e971 100644 --- a/ldap/src/main/java/org/springframework/security/userdetails/ldap/Person.java +++ b/ldap/src/main/java/org/springframework/security/ldap/userdetails/Person.java @@ -12,7 +12,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.springframework.security.userdetails.ldap; +package org.springframework.security.ldap.userdetails; import org.springframework.util.Assert; diff --git a/ldap/src/main/java/org/springframework/security/userdetails/ldap/PersonContextMapper.java b/ldap/src/main/java/org/springframework/security/ldap/userdetails/PersonContextMapper.java similarity index 94% rename from ldap/src/main/java/org/springframework/security/userdetails/ldap/PersonContextMapper.java rename to ldap/src/main/java/org/springframework/security/ldap/userdetails/PersonContextMapper.java index a0c60d771c..b4e7b42263 100644 --- a/ldap/src/main/java/org/springframework/security/userdetails/ldap/PersonContextMapper.java +++ b/ldap/src/main/java/org/springframework/security/ldap/userdetails/PersonContextMapper.java @@ -1,4 +1,4 @@ -package org.springframework.security.userdetails.ldap; +package org.springframework.security.ldap.userdetails; import java.util.List; diff --git a/ldap/src/main/java/org/springframework/security/userdetails/ldap/UserDetailsContextMapper.java b/ldap/src/main/java/org/springframework/security/ldap/userdetails/UserDetailsContextMapper.java similarity index 97% rename from ldap/src/main/java/org/springframework/security/userdetails/ldap/UserDetailsContextMapper.java rename to ldap/src/main/java/org/springframework/security/ldap/userdetails/UserDetailsContextMapper.java index 8438b46903..6481bd1756 100644 --- a/ldap/src/main/java/org/springframework/security/userdetails/ldap/UserDetailsContextMapper.java +++ b/ldap/src/main/java/org/springframework/security/ldap/userdetails/UserDetailsContextMapper.java @@ -12,7 +12,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.springframework.security.userdetails.ldap; +package org.springframework.security.ldap.userdetails; import java.util.List; diff --git a/ldap/src/main/java/org/springframework/security/providers/ldap/authenticator/package.html b/ldap/src/main/java/org/springframework/security/providers/ldap/authenticator/package.html deleted file mode 100644 index c97c3889a0..0000000000 --- a/ldap/src/main/java/org/springframework/security/providers/ldap/authenticator/package.html +++ /dev/null @@ -1,5 +0,0 @@ - -
-LDAP authenticator implementations. - - diff --git a/ldap/src/test/java/org/springframework/security/ldap/SpringSecurityAuthenticationSourceTests.java b/ldap/src/test/java/org/springframework/security/ldap/SpringSecurityAuthenticationSourceTests.java index e71e482dd4..da7245b136 100644 --- a/ldap/src/test/java/org/springframework/security/ldap/SpringSecurityAuthenticationSourceTests.java +++ b/ldap/src/test/java/org/springframework/security/ldap/SpringSecurityAuthenticationSourceTests.java @@ -1,9 +1,9 @@ package org.springframework.security.ldap; import org.springframework.security.context.SecurityContextHolder; +import org.springframework.security.ldap.userdetails.LdapUserDetailsImpl; import org.springframework.security.providers.AnonymousAuthenticationToken; import org.springframework.security.providers.TestingAuthenticationToken; -import org.springframework.security.userdetails.ldap.LdapUserDetailsImpl; import org.springframework.security.util.AuthorityUtils; import org.springframework.ldap.core.AuthenticationSource; import org.springframework.ldap.core.DistinguishedName; diff --git a/ldap/src/test/java/org/springframework/security/providers/ldap/authenticator/BindAuthenticatorTests.java b/ldap/src/test/java/org/springframework/security/ldap/authentication/BindAuthenticatorTests.java similarity index 96% rename from ldap/src/test/java/org/springframework/security/providers/ldap/authenticator/BindAuthenticatorTests.java rename to ldap/src/test/java/org/springframework/security/ldap/authentication/BindAuthenticatorTests.java index 934df0481d..f9523db393 100644 --- a/ldap/src/test/java/org/springframework/security/providers/ldap/authenticator/BindAuthenticatorTests.java +++ b/ldap/src/test/java/org/springframework/security/ldap/authentication/BindAuthenticatorTests.java @@ -13,12 +13,13 @@ * limitations under the License. */ -package org.springframework.security.providers.ldap.authenticator; +package org.springframework.security.ldap.authentication; import org.springframework.security.Authentication; import org.springframework.security.BadCredentialsException; import org.springframework.security.SpringSecurityMessageSource; import org.springframework.security.ldap.AbstractLdapIntegrationTests; +import org.springframework.security.ldap.authentication.BindAuthenticator; import org.springframework.security.providers.UsernamePasswordAuthenticationToken; import org.springframework.ldap.core.DirContextAdapter; import org.springframework.ldap.core.DirContextOperations; diff --git a/ldap/src/test/java/org/springframework/security/providers/ldap/LdapAuthenticationProviderTests.java b/ldap/src/test/java/org/springframework/security/ldap/authentication/LdapAuthenticationProviderTests.java similarity index 97% rename from ldap/src/test/java/org/springframework/security/providers/ldap/LdapAuthenticationProviderTests.java rename to ldap/src/test/java/org/springframework/security/ldap/authentication/LdapAuthenticationProviderTests.java index 72b2e4a1d0..4fba0770dd 100644 --- a/ldap/src/test/java/org/springframework/security/providers/ldap/LdapAuthenticationProviderTests.java +++ b/ldap/src/test/java/org/springframework/security/ldap/authentication/LdapAuthenticationProviderTests.java @@ -13,7 +13,7 @@ * limitations under the License. */ -package org.springframework.security.providers.ldap; +package org.springframework.security.ldap.authentication; import static org.junit.Assert.*; @@ -30,11 +30,13 @@ import org.springframework.ldap.core.DistinguishedName; import org.springframework.security.Authentication; import org.springframework.security.BadCredentialsException; import org.springframework.security.GrantedAuthority; +import org.springframework.security.ldap.LdapAuthenticator; import org.springframework.security.ldap.LdapAuthoritiesPopulator; +import org.springframework.security.ldap.authentication.LdapAuthenticationProvider; +import org.springframework.security.ldap.userdetails.LdapUserDetailsMapper; import org.springframework.security.providers.UsernamePasswordAuthenticationToken; import org.springframework.security.userdetails.UserDetails; import org.springframework.security.userdetails.UsernameNotFoundException; -import org.springframework.security.userdetails.ldap.LdapUserDetailsMapper; import org.springframework.security.util.AuthorityUtils; diff --git a/ldap/src/test/java/org/springframework/security/providers/ldap/authenticator/LdapShaPasswordEncoderTests.java b/ldap/src/test/java/org/springframework/security/ldap/authentication/LdapShaPasswordEncoderTests.java similarity index 98% rename from ldap/src/test/java/org/springframework/security/providers/ldap/authenticator/LdapShaPasswordEncoderTests.java rename to ldap/src/test/java/org/springframework/security/ldap/authentication/LdapShaPasswordEncoderTests.java index 402d443644..205e7df8dc 100644 --- a/ldap/src/test/java/org/springframework/security/providers/ldap/authenticator/LdapShaPasswordEncoderTests.java +++ b/ldap/src/test/java/org/springframework/security/ldap/authentication/LdapShaPasswordEncoderTests.java @@ -13,7 +13,7 @@ * limitations under the License. */ -package org.springframework.security.providers.ldap.authenticator; +package org.springframework.security.ldap.authentication; import static org.junit.Assert.*; diff --git a/ldap/src/test/java/org/springframework/security/providers/ldap/authenticator/MockUserSearch.java b/ldap/src/test/java/org/springframework/security/ldap/authentication/MockUserSearch.java similarity index 95% rename from ldap/src/test/java/org/springframework/security/providers/ldap/authenticator/MockUserSearch.java rename to ldap/src/test/java/org/springframework/security/ldap/authentication/MockUserSearch.java index 51f310df9b..53711ba8be 100644 --- a/ldap/src/test/java/org/springframework/security/providers/ldap/authenticator/MockUserSearch.java +++ b/ldap/src/test/java/org/springframework/security/ldap/authentication/MockUserSearch.java @@ -13,7 +13,7 @@ * limitations under the License. */ -package org.springframework.security.providers.ldap.authenticator; +package org.springframework.security.ldap.authentication; import org.springframework.security.ldap.LdapUserSearch; diff --git a/ldap/src/test/java/org/springframework/security/providers/ldap/authenticator/PasswordComparisonAuthenticatorMockTests.java b/ldap/src/test/java/org/springframework/security/ldap/authentication/PasswordComparisonAuthenticatorMockTests.java similarity index 95% rename from ldap/src/test/java/org/springframework/security/providers/ldap/authenticator/PasswordComparisonAuthenticatorMockTests.java rename to ldap/src/test/java/org/springframework/security/ldap/authentication/PasswordComparisonAuthenticatorMockTests.java index 50734cd9d8..5ccffdf712 100644 --- a/ldap/src/test/java/org/springframework/security/providers/ldap/authenticator/PasswordComparisonAuthenticatorMockTests.java +++ b/ldap/src/test/java/org/springframework/security/ldap/authentication/PasswordComparisonAuthenticatorMockTests.java @@ -13,7 +13,7 @@ * limitations under the License. */ -package org.springframework.security.providers.ldap.authenticator; +package org.springframework.security.ldap.authentication; import javax.naming.directory.Attributes; import javax.naming.directory.BasicAttribute; @@ -26,6 +26,7 @@ import org.jmock.Mockery; import org.jmock.integration.junit4.JUnit4Mockery; import org.junit.Test; import org.springframework.ldap.core.support.BaseLdapPathContextSource; +import org.springframework.security.ldap.authentication.PasswordComparisonAuthenticator; import org.springframework.security.providers.UsernamePasswordAuthenticationToken; diff --git a/ldap/src/test/java/org/springframework/security/providers/ldap/authenticator/PasswordComparisonAuthenticatorTests.java b/ldap/src/test/java/org/springframework/security/ldap/authentication/PasswordComparisonAuthenticatorTests.java similarity index 97% rename from ldap/src/test/java/org/springframework/security/providers/ldap/authenticator/PasswordComparisonAuthenticatorTests.java rename to ldap/src/test/java/org/springframework/security/ldap/authentication/PasswordComparisonAuthenticatorTests.java index 10b6e43913..14a10a1fa3 100644 --- a/ldap/src/test/java/org/springframework/security/providers/ldap/authenticator/PasswordComparisonAuthenticatorTests.java +++ b/ldap/src/test/java/org/springframework/security/ldap/authentication/PasswordComparisonAuthenticatorTests.java @@ -13,12 +13,13 @@ * limitations under the License. */ -package org.springframework.security.providers.ldap.authenticator; +package org.springframework.security.ldap.authentication; import org.springframework.security.BadCredentialsException; import org.springframework.security.Authentication; import org.springframework.security.ldap.AbstractLdapIntegrationTests; +import org.springframework.security.ldap.authentication.PasswordComparisonAuthenticator; import org.springframework.security.providers.encoding.LdapShaPasswordEncoder; import org.springframework.security.providers.encoding.PlaintextPasswordEncoder; diff --git a/ldap/src/test/java/org/springframework/security/userdetails/ldap/InetOrgPersonTests.java b/ldap/src/test/java/org/springframework/security/ldap/userdetails/InetOrgPersonTests.java similarity index 97% rename from ldap/src/test/java/org/springframework/security/userdetails/ldap/InetOrgPersonTests.java rename to ldap/src/test/java/org/springframework/security/ldap/userdetails/InetOrgPersonTests.java index 8de992f802..adda7997c7 100644 --- a/ldap/src/test/java/org/springframework/security/userdetails/ldap/InetOrgPersonTests.java +++ b/ldap/src/test/java/org/springframework/security/ldap/userdetails/InetOrgPersonTests.java @@ -1,9 +1,10 @@ -package org.springframework.security.userdetails.ldap; +package org.springframework.security.ldap.userdetails; import junit.framework.TestCase; import org.springframework.ldap.core.DirContextAdapter; import org.springframework.ldap.core.DistinguishedName; +import org.springframework.security.ldap.userdetails.InetOrgPerson; /** * @author Luke Taylor diff --git a/ldap/src/test/java/org/springframework/security/userdetails/ldap/LdapUserDetailsManagerTests.java b/ldap/src/test/java/org/springframework/security/ldap/userdetails/LdapUserDetailsManagerTests.java similarity index 94% rename from ldap/src/test/java/org/springframework/security/userdetails/ldap/LdapUserDetailsManagerTests.java rename to ldap/src/test/java/org/springframework/security/ldap/userdetails/LdapUserDetailsManagerTests.java index f3c0ebdb3b..bc8446f18a 100644 --- a/ldap/src/test/java/org/springframework/security/userdetails/ldap/LdapUserDetailsManagerTests.java +++ b/ldap/src/test/java/org/springframework/security/ldap/userdetails/LdapUserDetailsManagerTests.java @@ -12,7 +12,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.springframework.security.userdetails.ldap; +package org.springframework.security.ldap.userdetails; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; @@ -30,6 +30,11 @@ import org.springframework.security.context.SecurityContextHolder; import org.springframework.security.ldap.AbstractLdapIntegrationTests; import org.springframework.security.ldap.DefaultLdapUsernameToDnMapper; import org.springframework.security.ldap.SpringSecurityLdapTemplate; +import org.springframework.security.ldap.userdetails.InetOrgPerson; +import org.springframework.security.ldap.userdetails.InetOrgPersonContextMapper; +import org.springframework.security.ldap.userdetails.LdapUserDetails; +import org.springframework.security.ldap.userdetails.LdapUserDetailsManager; +import org.springframework.security.ldap.userdetails.PersonContextMapper; import org.springframework.security.providers.UsernamePasswordAuthenticationToken; import org.springframework.security.userdetails.UsernameNotFoundException; import org.springframework.security.util.AuthorityUtils; diff --git a/ldap/src/test/java/org/springframework/security/userdetails/ldap/LdapUserDetailsMapperTests.java b/ldap/src/test/java/org/springframework/security/ldap/userdetails/LdapUserDetailsMapperTests.java similarity index 92% rename from ldap/src/test/java/org/springframework/security/userdetails/ldap/LdapUserDetailsMapperTests.java rename to ldap/src/test/java/org/springframework/security/ldap/userdetails/LdapUserDetailsMapperTests.java index 54dcf41d07..77432e97b6 100644 --- a/ldap/src/test/java/org/springframework/security/userdetails/ldap/LdapUserDetailsMapperTests.java +++ b/ldap/src/test/java/org/springframework/security/ldap/userdetails/LdapUserDetailsMapperTests.java @@ -13,7 +13,7 @@ * limitations under the License. */ -package org.springframework.security.userdetails.ldap; +package org.springframework.security.ldap.userdetails; import javax.naming.directory.BasicAttribute; import javax.naming.directory.BasicAttributes; @@ -22,6 +22,9 @@ import junit.framework.TestCase; import org.springframework.ldap.core.DirContextAdapter; import org.springframework.ldap.core.DistinguishedName; +import org.springframework.security.ldap.userdetails.LdapUserDetails; +import org.springframework.security.ldap.userdetails.LdapUserDetailsImpl; +import org.springframework.security.ldap.userdetails.LdapUserDetailsMapper; import org.springframework.security.util.AuthorityUtils; /** diff --git a/ldap/src/test/java/org/springframework/security/userdetails/ldap/LdapUserDetailsServiceTests.java b/ldap/src/test/java/org/springframework/security/ldap/userdetails/LdapUserDetailsServiceTests.java similarity index 87% rename from ldap/src/test/java/org/springframework/security/userdetails/ldap/LdapUserDetailsServiceTests.java rename to ldap/src/test/java/org/springframework/security/ldap/userdetails/LdapUserDetailsServiceTests.java index 11f69aa04a..00d9f98788 100644 --- a/ldap/src/test/java/org/springframework/security/userdetails/ldap/LdapUserDetailsServiceTests.java +++ b/ldap/src/test/java/org/springframework/security/ldap/userdetails/LdapUserDetailsServiceTests.java @@ -1,4 +1,4 @@ -package org.springframework.security.userdetails.ldap; +package org.springframework.security.ldap.userdetails; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertTrue; @@ -12,7 +12,9 @@ import org.springframework.ldap.core.DirContextOperations; import org.springframework.ldap.core.DistinguishedName; import org.springframework.security.GrantedAuthority; import org.springframework.security.ldap.LdapAuthoritiesPopulator; -import org.springframework.security.providers.ldap.authenticator.MockUserSearch; +import org.springframework.security.ldap.authentication.MockUserSearch; +import org.springframework.security.ldap.userdetails.LdapUserDetailsMapper; +import org.springframework.security.ldap.userdetails.LdapUserDetailsService; import org.springframework.security.userdetails.UserDetails; import org.springframework.security.util.AuthorityUtils; diff --git a/ntlm/src/main/java/org/springframework/security/ui/ntlm/NtlmProcessingFilter.java b/ntlm/src/main/java/org/springframework/security/ui/ntlm/NtlmProcessingFilter.java index 987634f9cd..c1542aafe0 100755 --- a/ntlm/src/main/java/org/springframework/security/ui/ntlm/NtlmProcessingFilter.java +++ b/ntlm/src/main/java/org/springframework/security/ui/ntlm/NtlmProcessingFilter.java @@ -25,10 +25,10 @@ import org.springframework.security.InsufficientAuthenticationException; import org.springframework.security.context.SecurityContextHolder; import org.springframework.security.providers.AnonymousAuthenticationToken; import org.springframework.security.providers.UsernamePasswordAuthenticationToken; -import org.springframework.security.web.FilterChainOrder; import org.springframework.security.web.SpringSecurityFilter; import org.springframework.security.web.WebAuthenticationDetailsSource; import org.springframework.security.web.authentication.AuthenticationProcessingFilter; +import org.springframework.security.web.util.FilterChainOrder; import org.springframework.beans.factory.InitializingBean; import org.springframework.util.Assert; diff --git a/ntlm/src/main/java/org/springframework/security/ui/ntlm/ldap/authenticator/NtlmAwareLdapAuthenticator.java b/ntlm/src/main/java/org/springframework/security/ui/ntlm/ldap/authenticator/NtlmAwareLdapAuthenticator.java index da5067a09f..9ad64a06f8 100755 --- a/ntlm/src/main/java/org/springframework/security/ui/ntlm/ldap/authenticator/NtlmAwareLdapAuthenticator.java +++ b/ntlm/src/main/java/org/springframework/security/ui/ntlm/ldap/authenticator/NtlmAwareLdapAuthenticator.java @@ -13,7 +13,7 @@ import org.springframework.ldap.core.support.BaseLdapPathContextSource; import org.springframework.security.Authentication; import org.springframework.security.BadCredentialsException; import org.springframework.security.ldap.SpringSecurityLdapTemplate; -import org.springframework.security.providers.ldap.authenticator.BindAuthenticator; +import org.springframework.security.ldap.authentication.BindAuthenticator; import org.springframework.security.ui.ntlm.NtlmUsernamePasswordAuthenticationToken; /** diff --git a/openid/src/main/java/org/springframework/security/openid/OpenIDAuthenticationProcessingFilter.java b/openid/src/main/java/org/springframework/security/openid/OpenIDAuthenticationProcessingFilter.java index 7324807e07..2a3e2af940 100644 --- a/openid/src/main/java/org/springframework/security/openid/OpenIDAuthenticationProcessingFilter.java +++ b/openid/src/main/java/org/springframework/security/openid/OpenIDAuthenticationProcessingFilter.java @@ -28,9 +28,9 @@ import javax.servlet.http.HttpSession; import org.springframework.security.Authentication; import org.springframework.security.AuthenticationException; import org.springframework.security.AuthenticationServiceException; -import org.springframework.security.web.FilterChainOrder; import org.springframework.security.web.authentication.AbstractProcessingFilter; import org.springframework.security.web.authentication.AuthenticationProcessingFilter; +import org.springframework.security.web.util.FilterChainOrder; import org.springframework.util.StringUtils; diff --git a/samples/cas/client/src/main/webapp/WEB-INF/applicationContext-security.xml b/samples/cas/client/src/main/webapp/WEB-INF/applicationContext-security.xml index 3fdc3f61e0..bbbb04f8be 100644 --- a/samples/cas/client/src/main/webapp/WEB-INF/applicationContext-security.xml +++ b/samples/cas/client/src/main/webapp/WEB-INF/applicationContext-security.xml @@ -13,16 +13,16 @@