1
0
mirror of synced 2026-05-22 21:33:16 +00:00

StandardCharsets can be used

Reports methods and constructors where constant charset String literal is used (like "UTF-8") which could be replaced with a predefined Charset object like StandardCharsets.UTF_8. This may work a little bit faster, because charset lookup becomes unnecessary. Also catching UnsupportedEncodingException may become unnecessary as well. In this case the catch block will be removed automatically.
This commit is contained in:
Lars Grefer
2019-08-09 00:39:09 +02:00
parent fb39d9c255
commit fe9e454978
3 changed files with 6 additions and 18 deletions
@@ -18,6 +18,7 @@ package org.springframework.security.test.web.servlet.request;
import java.io.IOException;
import java.io.InputStream;
import java.io.UnsupportedEncodingException;
import java.nio.charset.StandardCharsets;
import java.security.cert.CertificateException;
import java.security.cert.CertificateFactory;
import java.security.cert.X509Certificate;
@@ -638,12 +639,7 @@ public final class SecurityMockMvcRequestPostProcessors {
}
private static String md5Hex(String a2) {
try {
return DigestUtils.md5DigestAsHex(a2.getBytes("UTF-8"));
}
catch (UnsupportedEncodingException e) {
throw new RuntimeException(e);
}
return DigestUtils.md5DigestAsHex(a2.getBytes(StandardCharsets.UTF_8));
}
}
@@ -985,12 +981,7 @@ public final class SecurityMockMvcRequestPostProcessors {
private HttpBasicRequestPostProcessor(String username, String password) {
byte[] toEncode;
try {
toEncode = (username + ":" + password).getBytes("UTF-8");
}
catch (UnsupportedEncodingException e) {
throw new RuntimeException(e);
}
toEncode = (username + ":" + password).getBytes(StandardCharsets.UTF_8);
this.headerValue = "Basic " + new String(Base64.getEncoder().encode(toEncode));
}