remove redundant modifiers found by checkstyle

2026-08-04 09:17:02 +00:00 · 2019-08-10 00:18:56 +02:00
parent d9016e52e6
commit ff1070df36
124 changed files with 187 additions and 190 deletions
@@ -193,7 +193,7 @@ public class AuthenticationConfiguration {
 		private static final Log logger = LogFactory
 				.getLog(EnableGlobalAuthenticationAutowiredConfigurer.class);

-		public EnableGlobalAuthenticationAutowiredConfigurer(ApplicationContext context) {
+		EnableGlobalAuthenticationAutowiredConfigurer(ApplicationContext context) {
 			this.context = context;
 		}

@@ -42,7 +42,7 @@ class InitializeAuthenticationProviderBeanManagerConfigurer
 	/**
 	 * @param context the ApplicationContext to look up beans.
 	 */
-	public InitializeAuthenticationProviderBeanManagerConfigurer(
+	InitializeAuthenticationProviderBeanManagerConfigurer(
 			ApplicationContext context) {
 		this.context = context;
 	}
@@ -83,4 +83,4 @@ class InitializeAuthenticationProviderBeanManagerConfigurer
 					.getBean(userDetailsBeanNames[0], type);
 		}
 	}
-}
+}
@@ -43,7 +43,7 @@ class InitializeUserDetailsBeanManagerConfigurer
 	/**
 	 * @param context
 	 */
-	public InitializeUserDetailsBeanManagerConfigurer(ApplicationContext context) {
+	InitializeUserDetailsBeanManagerConfigurer(ApplicationContext context) {
 		this.context = context;
 	}

@@ -44,7 +44,7 @@ final class AutowireBeanFactoryObjectPostProcessor
 	private final List<DisposableBean> disposableBeans = new ArrayList<>();
 	private final List<SmartInitializingSingleton> smartSingletons = new ArrayList<>();

-	public AutowireBeanFactoryObjectPostProcessor(
+	AutowireBeanFactoryObjectPostProcessor(
 			AutowireCapableBeanFactory autowireBeanFactory) {
 		Assert.notNull(autowireBeanFactory, "autowireBeanFactory cannot be null");
 		this.autowireBeanFactory = autowireBeanFactory;
@@ -36,7 +36,7 @@ import org.springframework.util.ClassUtils;
 */
 final class GlobalMethodSecuritySelector implements ImportSelector {

-	public final String[] selectImports(AnnotationMetadata importingClassMetadata) {
+	public String[] selectImports(AnnotationMetadata importingClassMetadata) {
 		Class<EnableGlobalMethodSecurity> annoType = EnableGlobalMethodSecurity.class;
 		Map<String, Object> annotationAttributes = importingClassMetadata
 				.getAnnotationAttributes(annoType.getName(), false);
@@ -40,7 +40,7 @@ final class AutowiredWebSecurityConfigurersIgnoreParents {

 	private final ConfigurableListableBeanFactory beanFactory;

-	public AutowiredWebSecurityConfigurersIgnoreParents(
+	AutowiredWebSecurityConfigurersIgnoreParents(
 			ConfigurableListableBeanFactory beanFactory) {
 		Assert.notNull(beanFactory, "beanFactory cannot be null");
 		this.beanFactory = beanFactory;
@@ -183,7 +183,7 @@ public final class ExpressionUrlAuthorizationConfigurer<H extends HttpSecurityBu

 	@Override
 	@SuppressWarnings("rawtypes")
-	final List<AccessDecisionVoter<?>> getDecisionVoters(H http) {
+	List<AccessDecisionVoter<?>> getDecisionVoters(H http) {
 		List<AccessDecisionVoter<?>> decisionVoters = new ArrayList<>();
 		WebExpressionVoter expressionVoter = new WebExpressionVoter();
 		expressionVoter.setExpressionHandler(getExpressionHandler(http));
@@ -192,7 +192,7 @@ public final class ExpressionUrlAuthorizationConfigurer<H extends HttpSecurityBu
 	}

 	@Override
-	final ExpressionBasedFilterInvocationSecurityMetadataSource createMetadataSource(
+	ExpressionBasedFilterInvocationSecurityMetadataSource createMetadataSource(
 			H http) {
 		LinkedHashMap<RequestMatcher, Collection<ConfigAttribute>> requestMap = REGISTRY
 				.createRequestMap();
@@ -172,7 +172,7 @@ public final class UrlAuthorizationConfigurer<H extends HttpSecurityBuilder<H>>
 	 */
 	@Override
 	@SuppressWarnings("rawtypes")
-	final List<AccessDecisionVoter<?>> getDecisionVoters(H http) {
+	List<AccessDecisionVoter<?>> getDecisionVoters(H http) {
 		List<AccessDecisionVoter<?>> decisionVoters = new ArrayList<>();
 		decisionVoters.add(new RoleVoter());
 		decisionVoters.add(new AuthenticatedVoter());
@@ -133,7 +133,7 @@ public class RsaKeyConversionServicePostProcessor implements BeanFactoryPostProc
 	private static class ConverterPropertyEditorAdapter<T> extends PropertyEditorSupport {
 		private final Converter<String, T> converter;

-		public ConverterPropertyEditorAdapter(Converter<String, T> converter) {
+		ConverterPropertyEditorAdapter(Converter<String, T> converter) {
 			this.converter = converter;
 		}

@@ -138,7 +138,7 @@ final class AuthenticationConfigBuilder {

 	private String openIDLoginPage;

-	public AuthenticationConfigBuilder(Element element, boolean forceAutoConfig,
+	AuthenticationConfigBuilder(Element element, boolean forceAutoConfig,
 			ParserContext pc, SessionCreationPolicy sessionPolicy,
 			BeanReference requestCache, BeanReference authenticationManager,
 			BeanReference sessionStrategy, BeanReference portMapper,
@@ -152,7 +152,7 @@ class HttpConfigurationBuilder {
 	private BeanDefinition invalidSession;
 	private boolean addAllAuth;

-	public HttpConfigurationBuilder(Element element, boolean addAllAuth,
+	HttpConfigurationBuilder(Element element, boolean addAllAuth,
 			ParserContext pc, BeanReference portMapper, BeanReference portResolver,
 			BeanReference authenticationManager) {
 		this.httpElt = element;
@@ -415,12 +415,12 @@ class OrderDecorator implements Ordered {
 	final BeanMetadataElement bean;
 	final int order;

-	public OrderDecorator(BeanMetadataElement bean, SecurityFilters filterOrder) {
+	OrderDecorator(BeanMetadataElement bean, SecurityFilters filterOrder) {
 		this.bean = bean;
 		this.order = filterOrder.getOrder();
 	}

-	public OrderDecorator(BeanMetadataElement bean, int order) {
+	OrderDecorator(BeanMetadataElement bean, int order) {
 		this.bean = bean;
 		this.order = order;
 	}
@@ -48,7 +48,7 @@ class LogoutBeanDefinitionParser implements BeanDefinitionParser {
 	private ManagedList<BeanMetadataElement> logoutHandlers = new ManagedList<>();
 	private boolean csrfEnabled;

-	public LogoutBeanDefinitionParser(String loginPageUrl, String rememberMeServices,
+	LogoutBeanDefinitionParser(String loginPageUrl, String rememberMeServices,
 			BeanMetadataElement csrfLogoutHandler) {
 		this.defaultLogoutUrl = loginPageUrl + "?logout";
 		this.rememberMeServices = rememberMeServices;
@@ -68,7 +68,7 @@ final class ProtectPointcutPostProcessor implements BeanPostProcessor {
 	private final PointcutParser parser;
 	private final Set<String> processedBeans = new HashSet<>();

-	public ProtectPointcutPostProcessor(
+	ProtectPointcutPostProcessor(
 			MapBasedMethodSecurityMetadataSource mapBasedMethodSecurityMetadataSource) {
 		Assert.notNull(mapBasedMethodSecurityMetadataSource,
 				"MapBasedMethodSecurityMetadataSource to populate is required");
@@ -3645,7 +3645,7 @@ public class ServerHttpSecurity {
 		private final WebFilter webFilter;
 		private final int order;

-		public OrderedWebFilter(WebFilter webFilter, int order) {
+		OrderedWebFilter(WebFilter webFilter, int order) {
 			this.webFilter = webFilter;
 			this.order = order;
 		}
@@ -243,8 +243,7 @@ public final class WebSocketMessageBrokerSecurityBeanDefinitionParser implements

 		private final boolean sameOriginDisabled;

-		public MessageSecurityPostProcessor(String inboundSecurityInterceptorId,
-				boolean sameOriginDisabled) {
+		MessageSecurityPostProcessor(String inboundSecurityInterceptorId, boolean sameOriginDisabled) {
 			this.inboundSecurityInterceptorId = inboundSecurityInterceptorId;
 			this.sameOriginDisabled = sameOriginDisabled;
 		}
@@ -41,7 +41,7 @@ public class SecurityConfigurerAdapterTests {
 	static class OrderedObjectPostProcessor implements ObjectPostProcessor<String>, Ordered {
 		private final int order;

-		public OrderedObjectPostProcessor(int order) {
+		OrderedObjectPostProcessor(int order) {
 			this.order = order;
 		}

@@ -847,7 +847,7 @@ public class ExpressionUrlAuthorizationConfigurerTests {

 		static class CustomExpressionRoot extends WebSecurityExpressionRoot {

-			public CustomExpressionRoot(Authentication a, FilterInvocation fi) {
+			CustomExpressionRoot(Authentication a, FilterInvocation fi) {
 				super(a, fi);
 			}

@@ -73,7 +73,7 @@ public class NamespaceHttpExpressionHandlerTests {
 	@EnableWebMvc
 	@EnableWebSecurity
 	private static class ExpressionHandlerConfig extends WebSecurityConfigurerAdapter {
-		public ExpressionHandlerConfig() {}
+		ExpressionHandlerConfig() {}

 		@Override
 		protected void configure(AuthenticationManagerBuilder auth) throws Exception {
@@ -129,7 +129,7 @@ public class SecurityContextConfigurerTests {
 	@Configuration
 	@EnableWebSecurity
 	static class SecurityContextRepositoryDefaultsSecurityContextRepositoryConfig extends WebSecurityConfigurerAdapter {
-		public SecurityContextRepositoryDefaultsSecurityContextRepositoryConfig() {
+		SecurityContextRepositoryDefaultsSecurityContextRepositoryConfig() {
 			super(true);
 		}

@@ -2133,7 +2133,7 @@ public class OAuth2ResourceServerConfigurerTests {

 		private class MockWebServerPropertySource extends PropertySource {

-			public MockWebServerPropertySource() {
+			MockWebServerPropertySource() {
 				super("mockwebserver");
 			}

@@ -2178,7 +2178,7 @@ public class OAuth2ResourceServerConfigurerTests {

 		private String token;

-		public BearerTokenRequestPostProcessor(String token) {
+		BearerTokenRequestPostProcessor(String token) {
 			this.token = token;
 		}

@@ -631,7 +631,7 @@ public class CsrfConfigTests {
 	static class CsrfReturnedResultMatcher implements ResultMatcher {
 		ExceptionalFunction<MvcResult, String> token;

-		public CsrfReturnedResultMatcher(ExceptionalFunction<MvcResult, String> token) {
+		CsrfReturnedResultMatcher(ExceptionalFunction<MvcResult, String> token) {
 			this.token = token;
 		}

@@ -83,7 +83,7 @@ public class HttpConfigTests {
 	private static class EncodeUrlDenyingHttpServletResponseWrapper
 			extends HttpServletResponseWrapper {

-		public EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) {
+		EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) {
 			super(response);
 		}

@@ -907,7 +907,7 @@ public class MiscHttpConfigTests {
 	static class EncodeUrlDenyingHttpServletResponseWrapper
 			extends HttpServletResponseWrapper {

-		public EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) {
+		EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) {
 			super(response);
 		}

@@ -610,7 +610,7 @@ public class SessionManagementConfigTests {
 	private static class EncodeUrlDenyingHttpServletResponseWrapper
 			extends HttpServletResponseWrapper {

-		public EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) {
+		EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) {
 			super(response);
 		}

@@ -51,7 +51,7 @@ final class HtmlUnitWebTestClient {

 	private final WebTestClient webTestClient;

-	public HtmlUnitWebTestClient(WebClient webClient, WebTestClient webTestClient) {
+	HtmlUnitWebTestClient(WebClient webClient, WebTestClient webTestClient) {
 		Assert.notNull(webClient, "WebClient must not be null");
 		Assert.notNull(webTestClient, "WebTestClient must not be null");
 		this.webClient = webClient;
@@ -42,7 +42,7 @@ final class MockWebResponseBuilder {
 	private final FluxExchangeResult<String> exchangeResult;


-	public MockWebResponseBuilder(long startTime, WebRequest webRequest, FluxExchangeResult<String> exchangeResult) {
+	MockWebResponseBuilder(long startTime, WebRequest webRequest, FluxExchangeResult<String> exchangeResult) {
 		Assert.notNull(webRequest, "WebRequest must not be null");
 		Assert.notNull(exchangeResult, "FluxExchangeResult must not be null");
 		this.startTime = startTime;