remove redundant modifiers found by checkstyle
This commit is contained in:
Lars Grefer
@@ -158,7 +158,7 @@ class DummyRequest extends HttpServletRequestWrapper {
|
||||
private String queryString;
|
||||
private String method;
|
||||
|
||||
public DummyRequest() {
|
||||
DummyRequest() {
|
||||
super(UNSUPPORTED_REQUEST);
|
||||
}
|
||||
|
||||
|
||||
+1
-1
@@ -38,7 +38,7 @@ import org.springframework.expression.TypedValue;
|
||||
class DelegatingEvaluationContext implements EvaluationContext {
|
||||
private final EvaluationContext delegate;
|
||||
|
||||
public DelegatingEvaluationContext(EvaluationContext delegate) {
|
||||
DelegatingEvaluationContext(EvaluationContext delegate) {
|
||||
this.delegate = delegate;
|
||||
}
|
||||
|
||||
|
||||
+2
-2
@@ -99,7 +99,7 @@ public final class ExpressionBasedFilterInvocationSecurityMetadataSource
|
||||
extends AbstractVariableEvaluationContextPostProcessor {
|
||||
private final AntPathRequestMatcher matcher;
|
||||
|
||||
public AntPathMatcherEvaluationContextPostProcessor(
|
||||
AntPathMatcherEvaluationContextPostProcessor(
|
||||
AntPathRequestMatcher matcher) {
|
||||
this.matcher = matcher;
|
||||
}
|
||||
@@ -114,7 +114,7 @@ public final class ExpressionBasedFilterInvocationSecurityMetadataSource
|
||||
extends AbstractVariableEvaluationContextPostProcessor {
|
||||
private final RequestMatcher matcher;
|
||||
|
||||
public RequestVariablesExtractorEvaluationContextPostProcessor(
|
||||
RequestVariablesExtractorEvaluationContextPostProcessor(
|
||||
RequestMatcher matcher) {
|
||||
this.matcher = matcher;
|
||||
}
|
||||
|
||||
+1
-1
@@ -31,7 +31,7 @@ class WebExpressionConfigAttribute implements ConfigAttribute,
|
||||
private final Expression authorizeExpression;
|
||||
private final EvaluationContextPostProcessor<FilterInvocation> postProcessor;
|
||||
|
||||
public WebExpressionConfigAttribute(Expression authorizeExpression,
|
||||
WebExpressionConfigAttribute(Expression authorizeExpression,
|
||||
EvaluationContextPostProcessor<FilterInvocation> postProcessor) {
|
||||
this.authorizeExpression = authorizeExpression;
|
||||
this.postProcessor = postProcessor;
|
||||
|
||||
+2
-2
@@ -58,11 +58,11 @@ final class DefaultWASUsernameAndGroupsExtractor implements WASUsernameAndGroups
|
||||
// SEC-803
|
||||
private static Class<?> wsCredentialClass = null;
|
||||
|
||||
public final List<String> getGroupsForCurrentUser() {
|
||||
public List<String> getGroupsForCurrentUser() {
|
||||
return getWebSphereGroups(getRunAsSubject());
|
||||
}
|
||||
|
||||
public final String getCurrentUserName() {
|
||||
public String getCurrentUserName() {
|
||||
return getSecurityName(getRunAsSubject());
|
||||
}
|
||||
|
||||
|
||||
+2
-2
@@ -210,8 +210,8 @@ public abstract class AbstractSecurityWebApplicationInitializer
|
||||
* @param filterName
|
||||
* @param filter
|
||||
*/
|
||||
private final void registerFilter(ServletContext servletContext,
|
||||
boolean insertBeforeOtherFilters, String filterName, Filter filter) {
|
||||
private void registerFilter(ServletContext servletContext,
|
||||
boolean insertBeforeOtherFilters, String filterName, Filter filter) {
|
||||
Dynamic registration = servletContext.addFilter(filterName, filter);
|
||||
if (registration == null) {
|
||||
throw new IllegalStateException(
|
||||
|
||||
+1
-1
@@ -269,7 +269,7 @@ public class HttpSessionSecurityContextRepository implements SecurityContextRepo
|
||||
HttpServletRequestWrapper {
|
||||
private final SaveContextOnUpdateOrErrorResponseWrapper response;
|
||||
|
||||
public SaveToSessionRequestWrapper(HttpServletRequest request,
|
||||
SaveToSessionRequestWrapper(HttpServletRequest request,
|
||||
SaveContextOnUpdateOrErrorResponseWrapper response) {
|
||||
super(request);
|
||||
this.response = response;
|
||||
|
||||
@@ -55,7 +55,7 @@ public final class DebugFilter implements Filter {
|
||||
this.fcp = fcp;
|
||||
}
|
||||
|
||||
public final void doFilter(ServletRequest srvltRequest,
|
||||
public void doFilter(ServletRequest srvltRequest,
|
||||
ServletResponse srvltResponse, FilterChain filterChain)
|
||||
throws ServletException, IOException {
|
||||
|
||||
@@ -153,7 +153,7 @@ public final class DebugFilter implements Filter {
|
||||
class DebugRequestWrapper extends HttpServletRequestWrapper {
|
||||
private static final Logger logger = new Logger();
|
||||
|
||||
public DebugRequestWrapper(HttpServletRequest request) {
|
||||
DebugRequestWrapper(HttpServletRequest request) {
|
||||
super(request);
|
||||
}
|
||||
|
||||
|
||||
@@ -31,7 +31,7 @@ class FirewalledResponse extends HttpServletResponseWrapper {
|
||||
private static final String LOCATION_HEADER = "Location";
|
||||
private static final String SET_COOKIE_HEADER = "Set-Cookie";
|
||||
|
||||
public FirewalledResponse(HttpServletResponse response) {
|
||||
FirewalledResponse(HttpServletResponse response) {
|
||||
super(response);
|
||||
}
|
||||
|
||||
|
||||
@@ -48,7 +48,7 @@ final class RequestWrapper extends FirewalledRequest {
|
||||
private final String strippedPathInfo;
|
||||
private boolean stripPaths = true;
|
||||
|
||||
public RequestWrapper(HttpServletRequest request) {
|
||||
RequestWrapper(HttpServletRequest request) {
|
||||
super(request);
|
||||
strippedServletPath = strip(request.getServletPath());
|
||||
String pathInfo = strip(request.getPathInfo());
|
||||
@@ -144,7 +144,7 @@ final class RequestWrapper extends FirewalledRequest {
|
||||
* @param path the {@code path} that will be used to obtain the delegate
|
||||
* {@link RequestDispatcher} from the original {@link HttpServletRequest}.
|
||||
*/
|
||||
public FirewalledRequestAwareRequestDispatcher(String path) {
|
||||
FirewalledRequestAwareRequestDispatcher(String path) {
|
||||
this.path = path;
|
||||
}
|
||||
|
||||
|
||||
+1
-1
@@ -48,7 +48,7 @@ class DefaultCsrfTokenMixin {
|
||||
* @param token the CSRF token value
|
||||
*/
|
||||
@JsonCreator
|
||||
public DefaultCsrfTokenMixin(@JsonProperty("headerName") String headerName,
|
||||
DefaultCsrfTokenMixin(@JsonProperty("headerName") String headerName,
|
||||
@JsonProperty("parameterName") String parameterName, @JsonProperty("token") String token) {
|
||||
}
|
||||
}
|
||||
|
||||
@@ -39,7 +39,7 @@ import com.fasterxml.jackson.annotation.*;
|
||||
abstract class SavedCookieMixin {
|
||||
|
||||
@JsonCreator
|
||||
public SavedCookieMixin(@JsonProperty("name") String name, @JsonProperty("value") String value,
|
||||
SavedCookieMixin(@JsonProperty("name") String name, @JsonProperty("value") String value,
|
||||
@JsonProperty("comment") String comment, @JsonProperty("domain") String domain,
|
||||
@JsonProperty("maxAge") int maxAge, @JsonProperty("path") String path,
|
||||
@JsonProperty("secure") boolean secure, @JsonProperty("version") int version) {
|
||||
|
||||
+1
-1
@@ -77,7 +77,7 @@ class SavedRequestAwareWrapper extends HttpServletRequestWrapper {
|
||||
// ~ Constructors
|
||||
// ===================================================================================================
|
||||
|
||||
public SavedRequestAwareWrapper(SavedRequest saved, HttpServletRequest request) {
|
||||
SavedRequestAwareWrapper(SavedRequest saved, HttpServletRequest request) {
|
||||
super(request);
|
||||
savedRequest = saved;
|
||||
|
||||
|
||||
+1
-1
@@ -47,7 +47,7 @@ class DefaultCsrfServerTokenMixin {
|
||||
* @param token the CSRF token value
|
||||
*/
|
||||
@JsonCreator
|
||||
public DefaultCsrfServerTokenMixin(@JsonProperty("headerName") String headerName,
|
||||
DefaultCsrfServerTokenMixin(@JsonProperty("headerName") String headerName,
|
||||
@JsonProperty("parameterName") String parameterName, @JsonProperty("token") String token) {
|
||||
}
|
||||
}
|
||||
|
||||
+2
-2
@@ -170,7 +170,7 @@ final class HttpServlet3RequestFactory implements HttpServletRequestFactory {
|
||||
extends SecurityContextHolderAwareRequestWrapper {
|
||||
private final HttpServletResponse response;
|
||||
|
||||
public Servlet3SecurityContextHolderAwareRequestWrapper(
|
||||
Servlet3SecurityContextHolderAwareRequestWrapper(
|
||||
HttpServletRequest request, String rolePrefix,
|
||||
HttpServletResponse response) {
|
||||
super(request, HttpServlet3RequestFactory.this.trustResolver, rolePrefix);
|
||||
@@ -265,7 +265,7 @@ final class HttpServlet3RequestFactory implements HttpServletRequestFactory {
|
||||
private static class SecurityContextAsyncContext implements AsyncContext {
|
||||
private final AsyncContext asyncContext;
|
||||
|
||||
public SecurityContextAsyncContext(AsyncContext asyncContext) {
|
||||
SecurityContextAsyncContext(AsyncContext asyncContext) {
|
||||
this.asyncContext = asyncContext;
|
||||
}
|
||||
|
||||
|
||||
+3
-3
@@ -258,7 +258,7 @@ public abstract class OnCommittedResponseWrapper extends HttpServletResponseWrap
|
||||
private class SaveContextPrintWriter extends PrintWriter {
|
||||
private final PrintWriter delegate;
|
||||
|
||||
public SaveContextPrintWriter(PrintWriter delegate) {
|
||||
SaveContextPrintWriter(PrintWriter delegate) {
|
||||
super(delegate);
|
||||
this.delegate = delegate;
|
||||
}
|
||||
@@ -498,7 +498,7 @@ public abstract class OnCommittedResponseWrapper extends HttpServletResponseWrap
|
||||
private class SaveContextServletOutputStream extends ServletOutputStream {
|
||||
private final ServletOutputStream delegate;
|
||||
|
||||
public SaveContextServletOutputStream(ServletOutputStream delegate) {
|
||||
SaveContextServletOutputStream(ServletOutputStream delegate) {
|
||||
this.delegate = delegate;
|
||||
}
|
||||
|
||||
@@ -652,4 +652,4 @@ public abstract class OnCommittedResponseWrapper extends HttpServletResponseWrap
|
||||
return getClass().getName() + "[delegate=" + this.delegate.toString() + "]";
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
+1
-1
@@ -23,7 +23,7 @@ class ELRequestMatcherContext {
|
||||
|
||||
private final HttpServletRequest request;
|
||||
|
||||
public ELRequestMatcherContext(HttpServletRequest request) {
|
||||
ELRequestMatcherContext(HttpServletRequest request) {
|
||||
this.request = request;
|
||||
}
|
||||
|
||||
|
||||
+1
-1
@@ -204,7 +204,7 @@ public class ChannelDecisionManagerImplTests {
|
||||
private String configAttribute;
|
||||
private boolean failIfCalled;
|
||||
|
||||
public MockChannelProcessor(String configAttribute, boolean failIfCalled) {
|
||||
MockChannelProcessor(String configAttribute, boolean failIfCalled) {
|
||||
this.configAttribute = configAttribute;
|
||||
this.failIfCalled = failIfCalled;
|
||||
}
|
||||
|
||||
+2
-2
@@ -169,7 +169,7 @@ public class ChannelProcessingFilterTests {
|
||||
private String supportAttribute;
|
||||
private boolean commitAResponse;
|
||||
|
||||
public MockChannelDecisionManager(boolean commitAResponse, String supportAttribute) {
|
||||
MockChannelDecisionManager(boolean commitAResponse, String supportAttribute) {
|
||||
this.commitAResponse = commitAResponse;
|
||||
this.supportAttribute = supportAttribute;
|
||||
}
|
||||
@@ -197,7 +197,7 @@ public class ChannelProcessingFilterTests {
|
||||
private String servletPath;
|
||||
private boolean provideIterator;
|
||||
|
||||
public MockFilterInvocationDefinitionMap(String servletPath,
|
||||
MockFilterInvocationDefinitionMap(String servletPath,
|
||||
boolean provideIterator, String... toReturn) {
|
||||
this.servletPath = servletPath;
|
||||
this.toReturn = SecurityConfig.createList(toReturn);
|
||||
|
||||
+1
-1
@@ -101,7 +101,7 @@ public class WebExpressionVoterTests {
|
||||
|
||||
private static class FilterInvocationChild extends FilterInvocation {
|
||||
|
||||
public FilterInvocationChild(ServletRequest request, ServletResponse response,
|
||||
FilterInvocationChild(ServletRequest request, ServletResponse response,
|
||||
FilterChain chain) {
|
||||
super(request, response, chain);
|
||||
}
|
||||
|
||||
+2
-2
@@ -437,7 +437,7 @@ public class AbstractAuthenticationProcessingFilterTests {
|
||||
|
||||
private boolean grantAccess;
|
||||
|
||||
public MockAuthenticationFilter(boolean grantAccess) {
|
||||
MockAuthenticationFilter(boolean grantAccess) {
|
||||
this();
|
||||
setRememberMeServices(new NullRememberMeServices());
|
||||
this.grantAccess = grantAccess;
|
||||
@@ -465,7 +465,7 @@ public class AbstractAuthenticationProcessingFilterTests {
|
||||
|
||||
private boolean expectToProceed;
|
||||
|
||||
public MockFilterChain(boolean expectToProceed) {
|
||||
MockFilterChain(boolean expectToProceed) {
|
||||
this.expectToProceed = expectToProceed;
|
||||
}
|
||||
|
||||
|
||||
+1
-1
@@ -120,7 +120,7 @@ public class AnonymousAuthenticationFilterTests {
|
||||
private class MockFilterChain implements FilterChain {
|
||||
private boolean expectToProceed;
|
||||
|
||||
public MockFilterChain(boolean expectToProceed) {
|
||||
MockFilterChain(boolean expectToProceed) {
|
||||
this.expectToProceed = expectToProceed;
|
||||
}
|
||||
|
||||
|
||||
+1
-1
@@ -48,7 +48,7 @@ public class J2eePreAuthenticatedProcessingFilterTests {
|
||||
getRequest("testUser", new String[] {})));
|
||||
}
|
||||
|
||||
private final HttpServletRequest getRequest(final String aUserName,
|
||||
private HttpServletRequest getRequest(final String aUserName,
|
||||
final String[] aRoles) {
|
||||
MockHttpServletRequest req = new MockHttpServletRequest() {
|
||||
|
||||
|
||||
+1
-1
@@ -168,7 +168,7 @@ public class RememberMeAuthenticationFilterTests {
|
||||
private class MockRememberMeServices implements RememberMeServices {
|
||||
private Authentication authToReturn;
|
||||
|
||||
public MockRememberMeServices(Authentication authToReturn) {
|
||||
MockRememberMeServices(Authentication authToReturn) {
|
||||
this.authToReturn = authToReturn;
|
||||
}
|
||||
|
||||
|
||||
+2
-2
@@ -676,7 +676,7 @@ public class HttpSessionSecurityContextRepositoryTests {
|
||||
|
||||
@Transient
|
||||
private static class SomeTransientAuthentication extends AbstractAuthenticationToken {
|
||||
public SomeTransientAuthentication() {
|
||||
SomeTransientAuthentication() {
|
||||
super(null);
|
||||
}
|
||||
|
||||
@@ -703,7 +703,7 @@ public class HttpSessionSecurityContextRepositoryTests {
|
||||
|
||||
@TestTransientAuthentication
|
||||
private static class SomeOtherTransientAuthentication extends AbstractAuthenticationToken {
|
||||
public SomeOtherTransientAuthentication() {
|
||||
SomeOtherTransientAuthentication() {
|
||||
super(null);
|
||||
}
|
||||
|
||||
|
||||
+1
-1
@@ -180,7 +180,7 @@ public class SaveContextOnUpdateOrErrorResponseWrapperTests {
|
||||
SaveContextOnUpdateOrErrorResponseWrapper {
|
||||
private SecurityContext securityContext;
|
||||
|
||||
public SaveContextOnUpdateOrErrorResponseWrapperStub(
|
||||
SaveContextOnUpdateOrErrorResponseWrapperStub(
|
||||
HttpServletResponse response, boolean disableUrlRewriting) {
|
||||
super(response, disableUrlRewriting);
|
||||
}
|
||||
|
||||
@@ -400,7 +400,7 @@ public class CsrfFilterTests {
|
||||
this.filter.setAccessDeniedHandler(null);
|
||||
}
|
||||
|
||||
private static final CsrfTokenAssert assertToken(Object token) {
|
||||
private static CsrfTokenAssert assertToken(Object token) {
|
||||
return new CsrfTokenAssert((CsrfToken) token);
|
||||
}
|
||||
|
||||
|
||||
+1
-1
@@ -271,7 +271,7 @@ public class AuthenticationPrincipalArgumentResolverTests {
|
||||
this.property = property;
|
||||
}
|
||||
|
||||
public CopyUserPrincipal(CopyUserPrincipal toCopy) {
|
||||
CopyUserPrincipal(CopyUserPrincipal toCopy) {
|
||||
this.property = toCopy.property;
|
||||
}
|
||||
|
||||
|
||||
+1
-1
@@ -314,7 +314,7 @@ public class CurrentSecurityContextArgumentResolverTests {
|
||||
|
||||
static class CustomSecurityContext implements SecurityContext {
|
||||
private Authentication authentication;
|
||||
public CustomSecurityContext(Authentication authentication) {
|
||||
CustomSecurityContext(Authentication authentication) {
|
||||
this.authentication = authentication;
|
||||
}
|
||||
@Override
|
||||
|
||||
Reference in New Issue
Block a user