8d80166aaf
Update exception variable names
...
Consistently use `ex` for caught exception and `cause` for Exception
constructor arguments.
Issue gh-8945
2020-08-24 17:33:08 -05:00
e9130489a6
Remove restricted static imports
...
Replace static imports with class referenced methods. With the exception
of a few well known static imports, checkstyle restricts the static
imports that a class can use. For example, `asList(...)` would be
replaced with `Arrays.asList(...)`.
Issue gh-8945
2020-08-24 17:33:08 -05:00
db55ef4b3b
Migrate to BDD Mockito
...
Migrate Mockito imports to use the BDD variant. This aligns better with
the "given" / "when" / "then" style used in most tests since the "given"
block now uses Mockito `given(...)` calls.
The commit also updates a few tests that were accidentally using
Power Mockito when regular Mockito could be used.
Issue gh-8945
2020-08-24 17:33:08 -05:00
f1cee9500f
Ensure classes are defined in their own files
...
Ensure that all classes are defined in their own files. Mostly classes
have been changed to inner-types.
Issue gh-8945
2020-08-24 17:33:08 -05:00
053af720a4
Ensure no whitespace before lines
...
Fix a few issues cause by the automatic formatting that meant additional
leading whitespace was present.
Issue gh-8945
2020-08-24 17:33:08 -05:00
4d487e8dc3
Ensure all files end with a new line
...
Update all files to ensure that they always end with a new-line
character.
Issue gh-8945
2020-08-24 17:33:07 -05:00
a0b9442265
Use consistent modifier order
...
Update code to use a consistent modifier order that aligns with that
used in the "Java Language specification".
Issue gh-8945
2020-08-24 17:33:07 -05:00
9e08b51ed3
Apply code cleanup rules to projects
...
Apply automated cleanup rules to add `@Override` and `@Deprecated`
annotations and to fix class references used with static methods.
Issue gh-8945
2020-08-24 17:33:07 -05:00
8866fa6fb0
Always use 'this.' when accessing fields
...
Apply an Eclipse cleanup rules to ensure that fields are always accessed
using `this.`. This aligns with the style used by Spring Framework and
helps users quickly see the difference between a local and member
variable.
Issue gh-8945
2020-08-24 17:33:07 -05:00
6894ff5d12
Make classes final where possible
...
Update classes that have private constructors so that they are also
declared final. In a few cases, inner-classes used private constructors
but were subclassed. These have now been changed to have package-private
constructors.
Issue gh-8945
2020-08-24 17:33:07 -05:00
37fa94fafc
Organize imports
...
Use "organize imports" from Eclipse to cleanup import statements so
that they appear in a consistent and well defined order.
Issue gh-8945
2020-08-24 17:33:07 -05:00
5f64f53c3f
Use consistent "@" tag order in Javadoc
...
Ensure that Javadoc "@" tags appear in a consistent and well defined
order.
Issue gh-8945
2020-08-24 17:33:07 -05:00
71bc145ae4
Remove superfluous comments
...
Use '^\s+//\ \~\ .*$' and '^\s+//\ ============+$' regular expression
searches to remove superfluous comments.
Prior to this commit, many classes would have comments to indicate
blocks of code (such as constructors/methods/instance fields). These
added a lot of noise and weren't all that helpful, especially given
the outline views available in most modern IDEs.
Issue gh-8945
2020-08-24 17:33:07 -05:00
b7fc18262d
Reformat code using spring-javaformat
...
Run `./gradlew format` to reformat all java files.
Issue gh-8945
2020-08-24 17:32:56 -05:00
27ac046d8a
Rename *Test.java -> *Tests.java
...
Rename a few test classes that accidentally ended in `Test` instead of
`Tests`.
Issue gh-8945
2020-08-10 16:24:44 -05:00
1d74d556c2
Revert "Lock Dependency Versions for 5.4.0-RC1"
...
This reverts commit f3a1e5d40c
2020-08-05 14:59:11 -04:00
f3a1e5d40c
Lock Dependency Versions for 5.4.0-RC1
2020-08-05 13:46:11 -04:00
146d0b6358
Revert "Lock Dependency Versions for 5.4.0-M2"
...
This reverts commit 68538897c8
2020-07-01 13:11:50 -06:00
68538897c8
Lock Dependency Versions for 5.4.0-M2
2020-07-01 12:40:29 -06:00
06254a4fd4
Remove unused field 'digester' in Md4PasswordEncoder
...
`private Digester digester;` defined in Md4PasswordEncoder is never used. So remove it.
2020-05-21 11:19:03 -05:00
db4ca1f756
Document NoOpPasswordEncoder will not be removed
...
This commit adds extension to deprecation notice.
Fixes gh-8506
2020-05-13 12:54:13 -05:00
86ca6b013c
Unlock dependencies
...
This reverts commit 206960cf44
2020-05-06 17:27:35 -04:00
206960cf44
Lock dependencies for 5.4.0-M1
2020-05-06 17:13:04 -04:00
db155b3094
Clean up Javadoc
...
Fixes gh-8480
2020-05-05 17:31:54 -04:00
4d63e2f332
AesBytesEncryptor constructor that uses secret key
...
Fixes: gh-8402
2020-04-28 11:16:44 -04:00
4b2afdf825
BCryptPasswordEncoder rawPassword cannot be null
...
Closes gh-8317
2020-04-07 13:44:23 -05:00
7c0023ecc9
Update Encryptors documentation
...
Fixes gh-8208
2020-03-27 09:50:46 -04:00
d9f7422c2c
Update BouncyCastleAesBytesEncryptorEquivalencyTest.java
2020-03-16 08:21:20 -05:00
6eadf7b140
Unlock dependencies for 5.3.0.RELEASE
...
This reverts commit 147d7dadd7
2020-03-04 12:02:48 -07:00
147d7dadd7
Lock dependencies for 5.3.0.RELEASE
2020-03-04 10:28:39 -07:00
84b8a5abd7
Unlock dependencies for next development version
...
This reverts commit 064616f1ef
2020-02-05 15:53:04 +01:00
064616f1ef
Lock dependencies for 5.3.0.RC1
2020-02-05 10:20:05 +01:00
fcc6457bef
Unlock dependencies for next development version
...
This reverts commit 93acf8f0f1
2020-01-08 22:15:17 +01:00
93acf8f0f1
Lock dependencies for 5.3.0.M1
2020-01-08 19:41:10 +01:00
65f5c29316
Check hashes of byte array passwords
...
Fixes gh-7661
2019-12-13 17:57:49 +01:00
c71e84bdac
Replace test vectors with list of objects
2019-12-12 12:42:44 +01:00
34dd5fea30
Remove redundant throws clauses
...
Removes exceptions that are declared in a method's signature but never thrown by the method itself or its implementations/derivatives.
2019-08-23 01:03:54 +02:00
ff1070df36
remove redundant modifiers found by checkstyle
2019-08-10 00:18:56 +02:00
b388976ac8
fix checkstyle
2019-08-09 02:46:20 +02:00
40bee457f9
Unnecessary enum modifier
2019-08-09 00:42:07 +02:00
fe9e454978
StandardCharsets can be used
...
Reports methods and constructors where constant charset String literal is used (like "UTF-8") which could be replaced with a predefined Charset object like StandardCharsets.UTF_8. This may work a little bit faster, because charset lookup becomes unnecessary. Also catching UnsupportedEncodingException may become unnecessary as well. In this case the catch block will be removed automatically.
2019-08-09 00:39:09 +02:00
b3da1e466b
Add Argon2PasswordEncoder
...
Add PasswordEncoder for the Argon2 hashing algorithm (Password Hashing
Competition (PHC) winner).
This implementation uses the BouncyCastle-implementation of Argon2.
Fixes gh-5354
2019-08-05 13:54:29 -05:00
522d118aca
Fix typo in SCryptPasswordEncoder Javadoc
...
Fixes: gh-4004
2019-08-02 13:48:46 -04:00
c5b5cc507c
Cleanup redundant type casts
2019-07-10 09:31:09 -05:00
43737a56bd
Use foreach where possible
2019-07-09 06:11:45 -06:00
e1f155ba89
Polish SCrypt Upgrade Support
...
* Break up tests
* Rename test methods to follow conventions
* Fix checkstyle
Issue gh-7057
2019-07-03 15:50:51 -05:00
e95effc839
Allow upgrading between different SCrypt encodings
...
Fixes gh-7057
2019-07-03 15:48:42 -05:00
742df2cd1d
Polish BCrypt upgrade
...
Issue gh-7042
2019-07-03 14:08:21 -05:00
d3d6a8743e
Allow upgrading between different BCrypt encodings
...
Fixes gh-7042
2019-07-03 14:08:04 -05:00
4b0fb19fff
Use MessageDigest.isEqual() where possible
...
fixes #7058
2019-07-03 05:40:20 -06:00
Phillip Webb