DEV: Update linting (#227)

admin/assets/javascripts/discourse/components/house-ads-list-setting.hbs

@@ -1,13 +1,13 @@
-<label for={{name}}>{{title}}</label>
+<label for={{this.name}}>{{this.title}}</label>
 {{house-ads-chooser
-  settingValue=adValue
-  choices=adNames
-  onChange=(action (mut adValue))
+  settingValue=this.adValue
+  choices=this.adNames
+  onChange=(action (mut this.adValue))
 }}
 <div class="setting-controls">
-  {{#if changed}}
+  {{#if this.changed}}
     <DButton class="ok" @action={{action "save"}} @icon="check" />
     <DButton class="cancel" @action={{action "cancel"}} @icon="times" />
   {{/if}}
 </div>
-<p class="help">{{help}}</p>
+<p class="help">{{this.help}}</p>

admin/assets/javascripts/discourse/components/house-ads-setting.hbs

@@ -1,9 +1,9 @@
-<label for={{name}}>{{title}}</label>
-<TextField @value={{adValue}} @classNames="house-ads-text-input" />
+<label for={{this.name}}>{{this.title}}</label>
+<TextField @value={{this.adValue}} @classNames="house-ads-text-input" />
 <div class="setting-controls">
-  {{#if changed}}
+  {{#if this.changed}}
     <DButton class="ok" @action={{action "save"}} @icon="check" />
     <DButton class="cancel" @action={{action "cancel"}} @icon="times" />
   {{/if}}
 </div>
-<p class="help">{{help}}</p>
+<p class="help">{{this.help}}</p>

admin/assets/javascripts/discourse/templates/admin/plugins-house-ads-index.hbs

@@ -1,37 +1,37 @@
 <section class="house-ads-settings content-body">
   <div>{{i18n "admin.adplugin.house_ads.description"}}</div>
 
-  {{#if houseAds.length}}
+  {{#if this.houseAds.length}}
     <form class="form-horizontal">
       {{house-ads-list-setting
         name="topic_list_top"
-        value=adSettings.topic_list_top
-        allAds=houseAds
-        adSettings=adSettings
+        value=this.adSettings.topic_list_top
+        allAds=this.houseAds
+        adSettings=this.adSettings
       }}
       {{house-ads-list-setting
         name="topic_above_post_stream"
-        value=adSettings.topic_above_post_stream
-        allAds=houseAds
-        adSettings=adSettings
+        value=this.adSettings.topic_above_post_stream
+        allAds=this.houseAds
+        adSettings=this.adSettings
       }}
       {{house-ads-list-setting
         name="topic_above_suggested"
-        value=adSettings.topic_above_suggested
-        allAds=houseAds
-        adSettings=adSettings
+        value=this.adSettings.topic_above_suggested
+        allAds=this.houseAds
+        adSettings=this.adSettings
       }}
       {{house-ads-list-setting
         name="post_bottom"
-        value=adSettings.post_bottom
-        allAds=houseAds
-        adSettings=adSettings
+        value=this.adSettings.post_bottom
+        allAds=this.houseAds
+        adSettings=this.adSettings
       }}
       {{house-ads-list-setting
         name="topic_list_between"
-        value=adSettings.topic_list_between
-        allAds=houseAds
-        adSettings=adSettings
+        value=this.adSettings.topic_list_between
+        allAds=this.houseAds
+        adSettings=this.adSettings
       }}
 
       <DButton

admin/assets/javascripts/discourse/templates/admin/plugins-house-ads.hbs

@@ -1,6 +1,6 @@
 <div class="adplugin-mgmt">
   <h1>{{i18n "admin.adplugin.house_ads.title"}}</h1>
-  {{#if model.length}}
+  {{#if this.model.length}}
     <div class="content-list">
       <div class="house-ads-actions">
         <LinkTo
@@ -17,7 +17,7 @@
         </LinkTo>
       </div>
       <ul class="house-ads-list">
-        {{#each model as |ad|}}
+        {{#each this.model as |ad|}}
           <li class="house-ads-list-item">
             {{#link-to route="adminPlugins.houseAds.show" model=ad.id}}
               {{ad.name}}