Discourse/discourse-adplugin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FIX: show non-restricted ads instead of not showing ads at all (#213)

Browse Source 
In some cases where there were category restricted house ads we were not
showing ads on reload. This commit filter out all the ads that should
not be shown on current page, leaving only allowed ads. So now we'll
show ads on every reload in all the cases.

Internal ticket: t130920
This commit is contained in:
Arpit Jalan
2024-06-27 22:13:54 +05:30
committed by GitHub
parent a38fbd0935
commit 9b72130fdf
2 changed files with 60 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/javascripts/acceptance/house-ad-test.js
+35 -4
View File
@@ -197,7 +197,7 @@ acceptance(
assert
.dom(".h-topic-list")
.doesNotExist(
"ad is not displayed because the current category id is included in the ad category_ids"
"ad is not displayed because the current category id is not included in the ad category_ids"
);
});
}
@@ -229,7 +229,7 @@ acceptance(
assert
.dom(".h-topic-list")
.doesNotExist(
"ad is not displayed because the current category id is included in the ad category_ids"
"ad is not displayed because the current category id is not included in the ad category_ids"
);
});
}
@@ -261,7 +261,7 @@ acceptance(
assert
.dom(".h-topic-list")
.doesNotExist(
"ad is not displayed because the current category id is included in the ad category_ids"
"ad is not displayed because the current category id is not included in the ad category_ids"
);
});
}
@@ -288,7 +288,7 @@ acceptance(
},
});
test("hides ad to anon users when current category id is not included in ad category_ids", async (assert) => {
test("shows ad to anon users when current category id is included in ad category_ids", async (assert) => {
await visit("/c/bug/1");
assert
.dom(".h-topic-list")
@@ -298,3 +298,34 @@ acceptance(
});
}
);
acceptance(
"House Ads | Category and Group Permissions | Anonymous | Show non-restricted ads",
function (needs) {
needs.settings({
no_ads_for_categories: "",
});
needs.site({
house_creatives: {
settings: {
topic_list_top: "Topic List Top One|Topic List Top Two",
},
creatives: {
"Topic List Top One": {
html: "<div class='h-topic-list-one'>TOPIC LIST TOP ONE</div>",
category_ids: [2],
},
"Topic List Top Two": {
html: "<div class='h-topic-list-two'>TOPIC LIST TOP TWO</div>",
category_ids: [],
},
},
},
});
test("shows non-restricted ad to anon users", async (assert) => {
await visit("/c/bug/1");
assert.dom(".h-topic-list-two").exists("non-restricted ad is displayed");
});
}
);