62 Commits
Author SHA1 Message Date
Joffrey JAFFEUX 75a56891d2 Reverts Ember.String.prototype.w monkey patching causing exception
The git blame of the commit is unclear on the reasons leading to this, and how to reproduce a failure.
2019-01-09 21:18:06 +01:00
David Taylor 2e36e2c656 DEV: Apply prettier 2018-10-22 19:49:32 +01:00
Jeff Wong 136cceb1e3 FIX: resolve collision on ember's builtin w string function 2018-05-16 13:37:50 -07:00
Neil Lalonde da1d4e0063 FIX: when dfp/adsense publisher id is missing, don't render blank ad units 2016-11-21 15:55:03 -05:00
Neil Lalonde 8ce3acfb3b add ad sizes settings for mobile DFP 2016-06-21 13:13:37 -04:00
Neil Lalonde f930aa14ec FIX: too much memory used by long topics 2016-05-16 14:26:14 -04:00
Neil Lalonde e4405dd486 Add support for showing ad after every nth post, not only after the nth post 2016-04-21 18:53:39 -04:00
Neil Lalonde cee3f66009 Render nth post dfp ads in position where post would be 2016-04-21 18:53:39 -04:00
Neil Lalonde 13b5d21565 Fix dfp ad dimensioned undefined. Refactor dfp ad component to remove unnecessary variables and rewrite copy-pasted code. 2016-04-21 18:53:39 -04:00
Robin Ward 4ab0f0fab8 Upgrade to new Plugin API 2016-02-22 12:16:09 -05:00
Ken Cooper ffbd69688e Fixed: mobile viewport was too large when presenting ads, making for a sloppy mobile experience. Restricted length of "Advertisement" label to fix it. 2015-10-28 16:51:53 -07:00
Neil Lalonde 85d357b007 DFP: send a 0 value for discourse-category targeting on /latest, /categories, etc so that ads can show there while targeting categories 2015-10-28 12:20:16 -04:00
Neil Lalonde c5b9392ae5 FIX: ads not refreshing when going from one topic list to another 2015-10-27 17:44:03 -04:00
Neil Lalonde e13a6ecdce DFP: send key discourse-category and value as category slug when loading ads 2015-10-27 16:42:36 -04:00
Neil Lalonde cf850b273d FIX: refresh DFP ads after navigating between topics and lists 2015-10-15 13:58:49 -04:00
Sarah Ni fe9c53ce58 removed all disable boxes and changed trust levels for amazon 2015-09-21 10:44:37 +10:00
Sarah Ni 647eecd95b master - more consistent naming for dfp settings and removed test folder 2015-09-10 12:07:36 +10:00
Sarah Ni fa3d25e4fd Working mobile ads that follow desktop custom targeting 2015-09-03 21:08:21 +10:00
Sarah Ni 916e53884c working custom targeting for all locations 2015-09-02 15:23:17 +10:00
Sarah Ni b0a97df0da Fixed merge conflicts 2015-09-02 14:28:33 +10:00
Sarah Ni d656795bc1 Added all desktop slots to custom targeting 2015-09-02 14:21:17 +10:00
Sarah Ni dbb7d1a784 Refactored trust levels 2015-09-02 13:50:47 +10:00
Sarah Ni 14bd843ac1 Merged mobile slots and trust levels to multiple targeting keys branch 2015-09-02 13:33:49 +10:00
Sarah Ni 060c5d1b7a Added publisher id to mobile slots for dfp 2015-09-02 13:21:44 +10:00
Sarah Ni afa2262b1c Topic list top custom targeting multiple keys working 2015-09-02 13:13:53 +10:00
vi e255a65e32 Custom targeting working for one key and associated values for that one key per ad slot available - problem in multiple keys 2015-09-01 16:04:21 +10:00
vi 5eecf0d731 Fixed up properties in ad mobile sizes for dfp and adsense 2015-09-01 13:44:56 +10:00
vi 67141dd884 Added mobile code to topic list top position to test 2015-09-01 13:20:52 +10:00
vi 6452c9c5b1 Added trust levels to site settings for dfp 2015-09-01 11:27:31 +10:00
ladydanger 7f13e0a1fb Merge pull request #8 from team-melbourne-rgsoc2015/mobile-works
Successful mobile slots - default to 320*50
2015-09-01 10:10:09 +10:00
Sarah Ni c38eb3134e Fixed post-bottom if statement and reduced duplication in connectors 2015-08-31 16:10:26 +10:00
Sarah Ni a7258f4848 For loop replaces while loop but line 50 doesn't work 2015-08-31 15:25:42 +10:00
Sarah Ni cdb4c50eff Added custom targeting function error on line 50 when calling f.bar 2015-08-31 14:44:47 +10:00
Sarah Ni 8989d9c5ea fixed up with Jo's help setTargeting base method 2015-08-31 13:49:09 +10:00
Sarah Ni 6d8cbb72e4 Added key slots via url_list and created prototype setTargeting function 2015-08-31 12:21:43 +10:00
Sarah Ni 6d93faf871 Successful mobile slots - default to 320*50 2015-08-28 15:34:14 +10:00
vi e3dded27d9 how to approach the .setTargeting issue 2015-08-28 15:25:11 +10:00
vi f94bf79192 Added custom targeting to all slots and Sebastian fixed the variable issue in adsense - thanks Seb! 2015-08-28 12:21:40 +10:00
vi 514fed55c9 custom targeting multiple values working 2015-08-26 16:03:15 +10:00
Sarah Ni 010d11f969 key working, value not working 2015-08-26 15:35:30 +10:00
Sarah Ni 67d3504296 Added working custom targeting to topic list top for one key and one value 2015-08-26 12:04:03 +10:00
vi d272a71b08 Working ads however, on change url dfp plain ad not displaying 2015-08-25 15:53:22 +10:00
vi a67e02368e Removed console log and dfp code working without adsense - conflict when together 2015-08-25 14:40:03 +10:00
vi d179ed4fe9 Successfully merge with bug in cmd push 2015-08-25 14:30:23 +10:00
vi 3808410ac2 Master branch working with dfp and wrapper 2015-08-24 12:36:40 +10:00
vi 5fba1ad4d1 Merge branch 'adding-custom-targeting' 2015-08-24 12:34:14 +10:00
vi d75190c027 Removed custom targeting 2015-08-24 12:33:54 +10:00
vi 83389e2a83 Fixed merge conflicts with addition of google publisher id 2015-08-24 10:33:29 +10:00
vi 86054c5164 Added input slots for custom targeting in dfp 2015-08-21 11:19:18 +10:00
vi 9e56fae22a Added gender inventory level slot targeting to be tested 2015-08-20 21:14:50 +10:00