David Taylor
c88bb59d81
In the past, the ad plugin relied on two side-effects to achieve this behaviour:
1. Components being fully destroyed/rendered when navigating between pages. This stopped working when Discourse core moved to the more efficient 'loading slider' UI
2. The `listLoading` argument. This was an implementation detail of the old discovery routing infrastructure. Core recently overhauled this and removed the `listLoading` argument, because loading is now handled properly by the Ember router.
Instead of these two properties, we can use the `currentRoute` property of Ember's router service to trigger changes when navigating between pages. A common `{{#each` trick is used to fully destroy/re-render components even if the ad network is unchanged.
13 lines
361 B
Handlebars
13 lines
361 B
Handlebars
{{#each adComponents as |adComponent|}}
|
|
{{! Trick to force full destroy/re-render of component when route changes }}
|
|
{{#each (array this.router.currentRoute)}}
|
|
{{component
|
|
adComponent
|
|
placement=placement
|
|
category=category
|
|
postNumber=postNumber
|
|
indexNumber=indexNumber
|
|
tagName=childTagName
|
|
}}
|
|
{{/each}}
|
|
{{/each}} |