From 2e7c5f047d4889658a1ce6aa3938dc3a30b25ee6 Mon Sep 17 00:00:00 2001 From: Roman Rizzi Date: Tue, 28 Nov 2023 11:15:12 -0300 Subject: [PATCH] DEV: Don't attempt to update log if completion request fails. (#321) We already log the request failure when we raise the exception. --- lib/completions/endpoints/base.rb | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lib/completions/endpoints/base.rb b/lib/completions/endpoints/base.rb index bfe9c741..5b86f1b1 100644 --- a/lib/completions/endpoints/base.rb +++ b/lib/completions/endpoints/base.rb @@ -105,12 +105,14 @@ module DiscourseAi return response_data ensure - log.raw_response_payload = response_raw - log.response_tokens = tokenizer.size(response_data) - log.save! + if log + log.raw_response_payload = response_raw + log.response_tokens = tokenizer.size(response_data) + log.save! - if Rails.env.development? && log - puts "#{self.class.name}: request_tokens #{log.request_tokens} response_tokens #{log.response_tokens}" + if Rails.env.development? + puts "#{self.class.name}: request_tokens #{log.request_tokens} response_tokens #{log.response_tokens}" + end end end end