From ac7df5e3d075499d010765c90910144ad4c24076 Mon Sep 17 00:00:00 2001
From: Natalie Tay <natalie.tay@gmail.com>
Date: Thu, 7 Dec 2023 16:09:06 +0800
Subject: [PATCH] DEV: Use plugin name appropriately in warning (#270)

Use plugin name appropriately in warning
---
 .../discourse/controllers/admin-plugins-explorer.js           | 1 -
 assets/javascripts/discourse/routes/group-reports-index.js    | 2 +-
 assets/javascripts/discourse/routes/group-reports-show.js     | 2 +-
 plugin.rb                                                     | 4 ++--
 4 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/assets/javascripts/discourse/controllers/admin-plugins-explorer.js b/assets/javascripts/discourse/controllers/admin-plugins-explorer.js
index da79afe..17b1197 100644
--- a/assets/javascripts/discourse/controllers/admin-plugins-explorer.js
+++ b/assets/javascripts/discourse/controllers/admin-plugins-explorer.js
@@ -13,7 +13,6 @@ import Query from "discourse/plugins/discourse-data-explorer/discourse/models/qu
 const NoQuery = Query.create({ name: "No queries", fake: true, group_ids: [] });
 
 export default class PluginsExplorerController extends Controller {
-  @service("router") router;
   @service dialog;
   @service appEvents;
   @service router;
diff --git a/assets/javascripts/discourse/routes/group-reports-index.js b/assets/javascripts/discourse/routes/group-reports-index.js
index 1aa3961..c351f08 100644
--- a/assets/javascripts/discourse/routes/group-reports-index.js
+++ b/assets/javascripts/discourse/routes/group-reports-index.js
@@ -1,6 +1,6 @@
+import { inject as service } from "@ember/service";
 import { ajax } from "discourse/lib/ajax";
 import DiscourseRoute from "discourse/routes/discourse";
-import { inject as service } from "@ember/service";
 
 export default class GroupReportsIndexRoute extends DiscourseRoute {
   @service router;
diff --git a/assets/javascripts/discourse/routes/group-reports-show.js b/assets/javascripts/discourse/routes/group-reports-show.js
index 3b25b12..5cded3e 100644
--- a/assets/javascripts/discourse/routes/group-reports-show.js
+++ b/assets/javascripts/discourse/routes/group-reports-show.js
@@ -1,6 +1,6 @@
+import { inject as service } from "@ember/service";
 import { ajax } from "discourse/lib/ajax";
 import DiscourseRoute from "discourse/routes/discourse";
-import { inject as service } from "@ember/service";
 
 export default class GroupReportsShowRoute extends DiscourseRoute {
   @service router;
diff --git a/plugin.rb b/plugin.rb
index e600378..8646250 100644
--- a/plugin.rb
+++ b/plugin.rb
@@ -103,12 +103,12 @@ after_initialize do
           query_params = fields.dig("query_params", "value") || {}
 
           unless SiteSetting.data_explorer_enabled
-            Rails.logger.warn "#{DiscourseDataExplorer.plugin_name} - plugin must be enabled to run automation #{automation.id}"
+            Rails.logger.warn "#{DiscourseDataExplorer::PLUGIN_NAME} - plugin must be enabled to run automation #{automation.id}"
             next
           end
 
           unless recipients.present?
-            Rails.logger.warn "#{DiscourseDataExplorer.plugin_name} - couldn't find any recipients for automation #{automation.id}"
+            Rails.logger.warn "#{DiscourseDataExplorer::PLUGIN_NAME} - couldn't find any recipients for automation #{automation.id}"
             next
           end