Isaac Janzen
ac6b0467a1
DEV: Update params for group reports ( #207 )
...
During the upgrade to Octane group reports did not have the necessary 'updateParams' function added to have the param input changes bubble up to the parent. This PR adds the missing function as well as a small test to check that params can be inputted as expected (inserting a param would error previously).
2022-12-28 09:50:55 -06:00
Isaac Janzen
3e7605d8a0
DEV: Update params to use previously ran values on reload ( #206 )
...
After running a query with a non-default query param (inserting the new param into the url) we want to have the same params available after reloading the page. To do this we need to pass the updated params back up to the parent due to Octane's one direction data stream. I went over this with @pmusaraj and we both agreed this was extremely difficult to test due to needing to reload the page in a test, so we opted to move forward without one. A system test could be helpful in this case... I will investigate in a follow up PR.
- Move param-input tests to a dedicated file
2022-12-27 12:10:29 -06:00
Isaac Janzen
85c88c5d80
DEV: Better handling of no results ( #205 )
...
When there were no query results it would throw an error due to `this.resultCount` always passing as it is in the format of
```
"INTEGER - results returned"
```
so we need to grab the first index of the string and check if the integer is great than 0
2022-12-20 16:55:11 -06:00
Isaac Janzen
4c70cfa100
Upgrade query-result to Octane ( #204 )
...
* Upgrade query-result to Octane
2022-12-20 12:09:37 -06:00
Isaac Janzen
cf365f7df2
Upgrade explorer-schema onetable/enum to Octane ( #203 )
...
* Upgrade explorer-schema onetable/enum to Octane
2022-12-20 10:30:43 -06:00
Isaac Janzen
147bfec207
Upgrade data-explorer-bar-chart to Octane ( #201 )
...
* Upgrade `data-explorer-bar-chart` to Octane
2022-12-16 11:52:00 -06:00
Isaac Janzen
7d1a9d487d
Upgrade explorer-schema to Octane ( #202 )
...
* Upgrade `explorer-schema` to Octane
2022-12-16 11:51:36 -06:00
Isaac Janzen
8028b9f16a
Upgrade param-input to Octane ( #196 )
...
* Convert `param-input` to glimmer components
2022-12-16 11:41:03 -06:00
Isaac Janzen
9025646dc9
Hotfix category_id lookup ( #199 )
...
https://github.com/discourse/discourse-data-explorer/blob/74dfc39530201ea2afc9b7bb8e43d109e5752514/assets/javascripts/discourse/components/query-row-content.js#L34-L35
needed to pass the site object to 'lookup' parent functions and was erroring on category lookup.
2022-12-15 08:26:40 -06:00
Isaac Janzen
2934cc2129
Hotfix displaying posts ( #197 )
2022-12-14 09:06:36 -06:00
Isaac Janzen
74dfc39530
Upgrade query-row-content to Octane ( #194 )
...
* Upgrade query-row-content to octane
2022-12-13 09:21:01 -06:00
Isaac Janzen
fea231f200
Upgrade share-report to Octane ( #195 )
...
* Upgrade share-report to Octane
* add requested changes
2022-12-13 08:49:39 -06:00
Sam and Osama Sayegh
2313237a95
FIX: better handling of edge cases ( #187 )
...
- Require query name is present
- Ensure all routes are treated by default as .json, so errors flow correctly
- Remove superflous save/cancel controls from group settings
- Remove group control when item is destroyed
- Disable editing of query when it is deleted
Co-authored-by: Osama Sayegh <[email protected] >
2022-11-18 07:09:50 +11:00
Martin Brennan
bf1a79c9ad
FIX: Click not opening query ( #191 )
...
Due to recent core changes for Ember in
https://github.com/discourse/discourse/commit/0221855ba783c6d96d2dbf2ec9f7e92b5297499b
and https://github.com/discourse/discourse/commit/952b033165c2b77872d8cc79b0678dc4293c5ee1
the correct way of calling these actions must be observed,
otherwise clicking on a query did nothing.
This commit fixes the click and also makes scrollTop
work with the new {{on X}} Ember syntax.
2022-10-28 14:56:01 +10:00
Penar Musaraj
0deecbe2ae
DEV: Replace bootbox alert dialogs ( #190 )
2022-10-18 14:13:00 -04:00
Frank
82ec10d844
FIX: fixed the blueing of the bookmark icon ( #186 )
2022-08-19 00:07:35 +08:00
Jarek Radosz
07e009e862
DEV: Update linting setup and fix issues ( #179 )
2022-06-17 15:01:34 +02:00
Isaac Janzen
780232c902
DEV: Remove use of run-loop-and-computed-dot-access ( #178 )
...
Context: https://deprecations.emberjs.com/v3.x/#toc_deprecated-run-loop-and-computed-dot-access
2022-06-17 14:18:36 +02:00
Frank
45b6e7eb4f
FEATURE: Bookmarkable QueryGroups. ( #177 )
...
Adds the ability for non-Admin users to bookmark Queries from inside Group > Reports > Query view.
2022-06-14 23:07:02 +08:00
Isaac Janzen
92bdea38b2
DEV: Remove 'htmlSafe' string prototype extensions ( #176 )
...
Context: https://deprecations.emberjs.com/v3.x/#toc_ember-string-prototype_extensions
2022-06-01 11:42:50 -05:00
Gerhard Schlager
65a112c8d2
FIX: Edit button shouldn't be visible for seeded queries ( #174 )
2022-05-17 18:05:05 +02:00
Isaac Janzen
01f52dc5c5
DEV: Remove 'dasherize' string prototype extensions ( #173 )
...
Context: https://deprecations.emberjs.com/v3.x/#toc_ember-string-prototype_extensions
2022-05-13 12:43:37 -05:00
Isaac Janzen
d5e11a2c65
DEV: Remove 'capitalize' string prototype extensions ( #172 )
...
Context: https://deprecations.emberjs.com/v3.x/#toc_ember-string-prototype_extensions
2022-05-13 12:33:38 -05:00
Martin Brennan
50e9242d61
FIX: Use new properties for pick-files-button ( #167 )
...
Companion commit to core discourse/discourse#16375
2022-04-06 12:48:02 +10:00
Jarek Radosz
86cda5f213
DEV: Lose the es6 suffix ( #165 )
2022-03-05 17:21:01 +01:00
David Taylor
2a17f49f66
DEV: Bump eslint-config-discourse and correct violations
2022-01-26 14:44:10 +00:00
Bianca Nenciu
c6dd79c805
FIX: Do not stringify null parameters ( #151 )
...
Sometimes the query page did not load if one of the query was null
because it called null.toString() and raised an exception.
2022-01-17 13:45:40 +02:00
Andrei Prigorshnev
58cfe737f7
DEV: migrate routes to the new @action pattern ( #149 )
2022-01-06 15:16:51 +04:00
Jarek Radosz
3ce778ec6d
DEV: Fix store:main deprecation ( #145 )
2021-11-24 15:28:12 +01:00
Guhyoun Nam and Mark VanLandingham
286b5b5fe7
FEATURE: Add Data Explorer Params to the URL on run ( #128 )
...
Co-authored-by: Mark VanLandingham <[email protected] >
2021-09-14 10:10:16 -05:00