锦心 and Natalie
b47ba7ea60
DEV: Use Category's async method in param-input ( #310 )
...
This commit refactors the category id normalization of param-input to
use `Category.asyncFindBySlugPath`.
Now, the category id input will use an async query when the
default/initial value is category slug.
Co-authored-by: Natalie <[email protected] >
2024-08-21 15:41:02 +08:00
锦心
6d179745ec
FIX: Empty param-inout form should reject submit ( #309 )
...
The `onSubmit` hook will only be triggered when the form is valid, so we
need to clear the contents of `serializedData` in advance in `submit`.
Otherwise, it may not throw a validation error.
2024-08-20 10:09:48 +08:00
锦心
5080ce9b1f
UX: Rewrite param-input using FormKit ( #307 )
...
What does this PR do?
=====================
This PR refactors param-input to use FormKit. FormKit is a structured
form tool in the core. After the rewrite, we will be able to get semantic
parameter error prompts, etc.
meta link: https://meta.discourse.org/t/wishlist-param-dropdown-for-data-explorer-query/253883/28?u=lhc_fl
2024-08-20 09:42:50 +08:00
锦心
6d975d7e90
FEATURE: Add Data Explorer Params to the URL for group queries ( #298 )
...
We have introduced a URL param mechanism for data explorer queries for administrators
in https://github.com/discourse/discourse-data-explorer/pull/128/
However, for data explorer queries in group page, URL params are not yet introduced.
This PR introduces this missing piece.
Related meta topic: https://meta.discourse.org/t/populate-data-explorer-params-with-url-params/169404/8
2024-07-05 17:49:18 +08:00
Martin Brennan
87d7958db8
FIX: Bookmarking group reports ( #291 )
...
Since https://github.com/discourse/discourse/commit/67a8080e338aa62afbd02efc98178b4a67751775
in core, the functionality to bookmark a report from the group
Reports tab has been broken. This commit fixes the issue and adds
system spec coverage to prevent regression.
2024-05-22 09:18:09 +10:00
Isaac Janzen
70458df7cc
DEV: Convert ajax functions to async ( #273 )
2024-01-02 12:38:22 -07:00
Isaac Janzen
3dd5ad0f9c
DEV: Update modal to component API ( #269 )
...
<img width="622" alt="Screenshot 2023-12-06 at 12 10 09 PM" src="https://github.com/discourse/discourse-data-explorer/assets/50783505/5a6fb0b2-829c-4af3-93c9-91676b78ab59 ">
2023-12-07 11:49:35 -07:00
Natalie Tay
ac7df5e3d0
DEV: Use plugin name appropriately in warning ( #270 )
...
Use plugin name appropriately in warning
2023-12-07 16:09:06 +08:00
David Taylor
a6341627d0
DEV: Resolve transitionTo deprecation ( #268 )
2023-12-01 16:02:52 +00:00
Jarek Radosz
e067df0b43
DEV: Update linting ( #267 )
2023-12-01 16:47:54 +01:00
Martin Brennan
b8b66ded0e
DEV: Use new bookmark modal ( #252 )
...
The new glimmer bookmark modal using d-modal is introduced
in:
https://github.com/discourse/discourse/pull/22532
2023-07-17 10:28:00 +10:00
Bianca Nenciu
206d937a78
DEV: Update plugin to match latest guidelines ( #229 )
...
This commit updates the plugin to the latest guidelines, as shown in
discourse-plugin-skeleton, which involves moving a lot of the code to
dedicated files, use proper namespaces, use the autoloader as much as
possible, etc.
2023-03-22 23:29:08 +02:00
Isaac Janzen
075a508e52
FIX: Special attributes not working ( #232 )
...
# Context
Data explorer gives you the ability to use special attributes such as 👇
> SELECT TIMESTAMP 'yesterday' as reltime$time
# Problem
During the upgrade to ember octane these were neglected and did not work. This PR updates them to working condition.
# Additional
- Drop unused action of `saveDefaults`
2023-03-10 11:41:59 -06:00
Isaac Janzen
556d12ac50
FIX: Maintain editing state after saving query changes ( #223 )
...
In the widget version of the data-explorer we would maintain the `editing` state after saving query changes. This was lost in upgrade to glimmer.
# Current State
https://user-images.githubusercontent.com/50783505/217622464-79adaab6-84ed-4b64-93ae-c889aa8fb1bd.mp4
# Updated State
https://user-images.githubusercontent.com/50783505/217623475-1998fab6-0b70-42d2-923d-574efb9d5601.mov
# Other Changes
- `createProperties` was added back to the `query` model as it is being utilized in the creation of a new data explorer query. This was accidentally removed and was causing errors when trying to create a new query.
- Add new-query test
2023-02-08 13:40:53 -06:00
Isaac Janzen
332ae394e8
DEV: Upgrade group-reports to Octane ( #218 )
2023-02-06 11:20:03 -06:00
Isaac Janzen
4d26cf78f0
DEV: Upgrade admin-plugins-explorer to Octane ( #209 )
...
- Drop `explorer-container` and move its logic to `admin-plugin-explorer` container
- Convert resizing of the query edit pane from jquery -> draggable modifier
2023-01-05 09:27:10 -06:00
Isaac Janzen
ac6b0467a1
DEV: Update params for group reports ( #207 )
...
During the upgrade to Octane group reports did not have the necessary 'updateParams' function added to have the param input changes bubble up to the parent. This PR adds the missing function as well as a small test to check that params can be inputted as expected (inserting a param would error previously).
2022-12-28 09:50:55 -06:00
Isaac Janzen
7d1a9d487d
Upgrade explorer-schema to Octane ( #202 )
...
* Upgrade `explorer-schema` to Octane
2022-12-16 11:51:36 -06:00
Isaac Janzen
8028b9f16a
Upgrade param-input to Octane ( #196 )
...
* Convert `param-input` to glimmer components
2022-12-16 11:41:03 -06:00
Martin Brennan
bf1a79c9ad
FIX: Click not opening query ( #191 )
...
Due to recent core changes for Ember in
https://github.com/discourse/discourse/commit/0221855ba783c6d96d2dbf2ec9f7e92b5297499b
and https://github.com/discourse/discourse/commit/952b033165c2b77872d8cc79b0678dc4293c5ee1
the correct way of calling these actions must be observed,
otherwise clicking on a query did nothing.
This commit fixes the click and also makes scrollTop
work with the new {{on X}} Ember syntax.
2022-10-28 14:56:01 +10:00
Penar Musaraj
0deecbe2ae
DEV: Replace bootbox alert dialogs ( #190 )
2022-10-18 14:13:00 -04:00
Frank
82ec10d844
FIX: fixed the blueing of the bookmark icon ( #186 )
2022-08-19 00:07:35 +08:00
Jarek Radosz
07e009e862
DEV: Update linting setup and fix issues ( #179 )
2022-06-17 15:01:34 +02:00
Isaac Janzen
780232c902
DEV: Remove use of run-loop-and-computed-dot-access ( #178 )
...
Context: https://deprecations.emberjs.com/v3.x/#toc_deprecated-run-loop-and-computed-dot-access
2022-06-17 14:18:36 +02:00
Frank
45b6e7eb4f
FEATURE: Bookmarkable QueryGroups. ( #177 )
...
Adds the ability for non-Admin users to bookmark Queries from inside Group > Reports > Query view.
2022-06-14 23:07:02 +08:00
Gerhard Schlager
65a112c8d2
FIX: Edit button shouldn't be visible for seeded queries ( #174 )
2022-05-17 18:05:05 +02:00
Jarek Radosz
86cda5f213
DEV: Lose the es6 suffix ( #165 )
2022-03-05 17:21:01 +01:00
David Taylor
2a17f49f66
DEV: Bump eslint-config-discourse and correct violations
2022-01-26 14:44:10 +00:00
Guhyoun Nam and Mark VanLandingham
286b5b5fe7
FEATURE: Add Data Explorer Params to the URL on run ( #128 )
...
Co-authored-by: Mark VanLandingham <[email protected] >
2021-09-14 10:10:16 -05:00
Andrei Prigorshnev
4a98cc8af8
FEATURE: get rid of the import a query modal ( #127 )
...
This is the new version of #126 . Now the pick-files-button moved to core. To import a query into Data Explorer, you need to push the button and then deal with the import modal. Instead, we want just to be triggering a system file picker directly. This PR makes it happen.
2021-08-20 14:26:48 +04:00