discourse-table-builder

Discourse/discourse-table-builder

Fork 0

mirror of https://github.com/discourse/discourse-table-builder.git synced 2026-09-17 23:32:14 -04:00

Commit Graph

Author	SHA1	Message	Date
Penar Musaraj	b45ffe48b7	FIX: Allow headings to have the same label (#46 ) Fixes an issue where multiple headings with the same value would remove columns from displaying.	2023-02-16 21:16:48 -05:00
Penar Musaraj	fdc79d0cbf	FIX: do not edit wrong table when post has uploads (#37 ) Previously, the regex was catching uploads as well as tables. This change ensures only strict tables are matched by requiring that matches start with the pipe character. Also adds a unit test for `findTableRegex` to describe the expected behaviour of the helper.	2023-01-04 08:06:25 +01:00
Keegan GeorgeandPenar Musaraj	7b37c6acc1	FIX: Special character alignment issue (#10 ) * DEV: Use alternate fork of `array-to-table` * DEV: Add unit test for `arrayToTable()` method * Move `arrayToTable` so it is available for unit tests * DEV: Add assertion for creating a markdown table with special chars When a table with special characters (such as `$`) is inserted in a cell to the right of a blank cell. The alignment of the table gets ruined if the table doesn't have surrounding pipes. This check ensures this alignment is correct. Co-authored-by: Penar Musaraj <[email protected]>	2022-08-11 11:33:34 -07:00

Author

SHA1

Message

Date

Penar Musaraj

b45ffe48b7

FIX: Allow headings to have the same label (#46 )

Fixes an issue where multiple headings with the same value would remove
columns from displaying.

2023-02-16 21:16:48 -05:00

Penar Musaraj

fdc79d0cbf

FIX: do not edit wrong table when post has uploads (#37 )

Previously, the regex was catching uploads as well as tables.

This change ensures only strict tables are matched by requiring that
matches start with the pipe character.

Also adds a unit test for `findTableRegex` to describe the expected
behaviour of the helper.

2023-01-04 08:06:25 +01:00

Keegan GeorgeandPenar Musaraj

7b37c6acc1

FIX: Special character alignment issue (#10 )

* DEV: Use alternate fork of `array-to-table`

* DEV: Add unit test for `arrayToTable()` method

* Move `arrayToTable` so it is available for unit tests

* DEV: Add assertion for creating a markdown table with special chars

When a table with special characters (such as `$`) is inserted in a cell to the right of a blank cell. The alignment of the table gets ruined if the table doesn't have surrounding pipes. This check ensures this alignment is correct.

Co-authored-by: Penar Musaraj <[email protected]>

2022-08-11 11:33:34 -07:00