From 27b30b5efbf8081f63b67a36d0b11a15e06e8f07 Mon Sep 17 00:00:00 2001 From: Isaac Janzen <50783505+janzenisaac@users.noreply.github.com> Date: Fri, 30 Dec 2022 10:26:14 -0600 Subject: [PATCH] FIX: Group reports downloads (#213) We were not passing the correct arguments through in the group reports template causing the download url to default to an admin route. This made downloads unavailable to non-admin users. Fixed by passing the correct values through. --- assets/javascripts/discourse/components/query-result.js | 4 ++-- assets/javascripts/discourse/templates/group-reports-show.hbs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/assets/javascripts/discourse/components/query-result.js b/assets/javascripts/discourse/components/query-result.js index d7f8b08..412e4b7 100644 --- a/assets/javascripts/discourse/components/query-result.js +++ b/assets/javascripts/discourse/components/query-result.js @@ -210,8 +210,8 @@ export default class QueryResult extends Component { } _download_url() { - return this.group - ? `/g/${this.group.name}/reports/` + return this.args.group + ? `/g/${this.args.group.name}/reports/` : "/admin/plugins/explorer/queries/"; } diff --git a/assets/javascripts/discourse/templates/group-reports-show.hbs b/assets/javascripts/discourse/templates/group-reports-show.hbs index b700c4f..7d49798 100644 --- a/assets/javascripts/discourse/templates/group-reports-show.hbs +++ b/assets/javascripts/discourse/templates/group-reports-show.hbs @@ -31,7 +31,7 @@ {{#if results}}
{{#if showResults}} - {{query-result query=model content=results group=group}} + {{else}} {{#each results.errors as |err|}} 
{{~err}}