From b011f3ef8aa5f8e2710349c178bb960c8219e88b Mon Sep 17 00:00:00 2001 From: Martin Brennan Date: Thu, 15 Jun 2023 09:39:08 +1000 Subject: [PATCH] DEV: Remove usages of RateLimiter.clear_all! (#247) c.f. https://github.com/discourse/discourse/pull/22103 --- spec/requests/query_controller_spec.rb | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/spec/requests/query_controller_spec.rb b/spec/requests/query_controller_spec.rb index 20029b2..d589818 100644 --- a/spec/requests/query_controller_spec.rb +++ b/spec/requests/query_controller_spec.rb @@ -194,13 +194,14 @@ describe DiscourseDataExplorer::QueryController do ) end + before { RateLimiter.enable } + + use_redis_snapshotting + it "limits query runs from API when using block mode" do global_setting :max_data_explorer_api_reqs_per_10_seconds, 1 global_setting :max_data_explorer_api_req_mode, "block" - RateLimiter.enable - RateLimiter.clear_all! - admin = Fabricate(:admin) api_key = Fabricate(:api_key, user: admin) @@ -226,9 +227,6 @@ describe DiscourseDataExplorer::QueryController do global_setting :max_data_explorer_api_reqs_per_10_seconds, 1 global_setting :max_data_explorer_api_req_mode, "warn" - RateLimiter.enable - RateLimiter.clear_all! - admin = Fabricate(:admin) api_key = Fabricate(:api_key, user: admin) @@ -249,9 +247,6 @@ describe DiscourseDataExplorer::QueryController do global_setting :max_data_explorer_api_reqs_per_10_seconds, 1 global_setting :max_data_explorer_api_req_mode, "block" - RateLimiter.enable - RateLimiter.clear_all! - query = make_query("SELECT 23 as my_value") freeze_time