discourse/discourse-data-explorer
1
0
Fork 0
mirror of synced 2026-09-13 14:15:11 +00:00
Code Issues Packages Projects Releases Wiki Activity
436 Commits 1 Branch 0 Tags
467b6c8a91a08ca71080b9bbff2e0cd45dc4efe5
Commit Graph
197 Commits
Author SHA1 Message Date
SamandOsama Sayegh 2313237a95 FIX: better handling of edge cases (#187) 
- Require query name is present
- Ensure all routes are treated by default as .json, so errors flow correctly
- Remove superflous save/cancel controls from group settings
- Remove group control when item is destroyed
- Disable editing of query when it is deleted

Co-authored-by: Osama Sayegh <[email protected]>
 2022-11-18 07:09:50 +11:00
Martin Brennan bf1a79c9ad FIX: Click not opening query (#191) 
Due to recent core changes for Ember in
https://github.com/discourse/discourse/commit/0221855ba783c6d96d2dbf2ec9f7e92b5297499b
and https://github.com/discourse/discourse/commit/952b033165c2b77872d8cc79b0678dc4293c5ee1
the correct way of calling these actions must be observed,
otherwise clicking on a query did nothing.

This commit fixes the click and also makes scrollTop
work with the new {{on X}} Ember syntax.
 2022-10-28 14:56:01 +10:00
Penar Musaraj 0deecbe2ae DEV: Replace bootbox alert dialogs (#190) 2022-10-18 14:13:00 -04:00
Frank 82ec10d844 FIX: fixed the blueing of the bookmark icon (#186) 2022-08-19 00:07:35 +08:00
Jarek Radosz 07e009e862 DEV: Update linting setup and fix issues (#179) 2022-06-17 15:01:34 +02:00
Isaac Janzen 780232c902 DEV: Remove use of run-loop-and-computed-dot-access (#178) 
Context: https://deprecations.emberjs.com/v3.x/#toc_deprecated-run-loop-and-computed-dot-access
 2022-06-17 14:18:36 +02:00
Frank 45b6e7eb4f FEATURE: Bookmarkable QueryGroups. (#177) 
Adds the ability for non-Admin users to bookmark Queries from inside Group > Reports > Query view.
 2022-06-14 23:07:02 +08:00
Isaac Janzen 92bdea38b2 DEV: Remove 'htmlSafe' string prototype extensions (#176) 
Context: https://deprecations.emberjs.com/v3.x/#toc_ember-string-prototype_extensions
 2022-06-01 11:42:50 -05:00
Gerhard Schlager 65a112c8d2 FIX: Edit button shouldn't be visible for seeded queries (#174) 2022-05-17 18:05:05 +02:00
Isaac Janzen 01f52dc5c5 DEV: Remove 'dasherize' string prototype extensions (#173) 
Context: https://deprecations.emberjs.com/v3.x/#toc_ember-string-prototype_extensions
 2022-05-13 12:43:37 -05:00
Isaac Janzen d5e11a2c65 DEV: Remove 'capitalize' string prototype extensions (#172) 
Context: https://deprecations.emberjs.com/v3.x/#toc_ember-string-prototype_extensions
 2022-05-13 12:33:38 -05:00
Martin Brennan 50e9242d61 FIX: Use new properties for pick-files-button (#167) 
Companion commit to core discourse/discourse#16375
 2022-04-06 12:48:02 +10:00
Jarek Radosz 86cda5f213 DEV: Lose the es6 suffix (#165) 2022-03-05 17:21:01 +01:00
David Taylor 2a17f49f66 DEV: Bump eslint-config-discourse and correct violations 2022-01-26 14:44:10 +00:00
Bianca Nenciu c6dd79c805 FIX: Do not stringify null parameters (#151) 
Sometimes the query page did not load if one of the query was null
because it called null.toString() and raised an exception.
 2022-01-17 13:45:40 +02:00
Andrei Prigorshnev 58cfe737f7 DEV: migrate routes to the new @action pattern (#149) 2022-01-06 15:16:51 +04:00
Jarek Radosz 3ce778ec6d DEV: Fix store:main deprecation (#145) 2021-11-24 15:28:12 +01:00
Guhyoun NamandMark VanLandingham 286b5b5fe7 FEATURE: Add Data Explorer Params to the URL on run (#128) 
Co-authored-by: Mark VanLandingham <[email protected]>
 2021-09-14 10:10:16 -05:00
Penar Musaraj 0c9005513a UX: Fix button alignment following core changes (#137) 2021-09-14 09:44:32 -04:00
Andrei Prigorshnev 4a98cc8af8 FEATURE: get rid of the import a query modal (#127) 
This is the new version of #126. Now the pick-files-button moved to core. To import a query into Data Explorer, you need to push the button and then deal with the import modal. Instead, we want just to be triggering a system file picker directly. This PR makes it happen.
 2021-08-20 14:26:48 +04:00
Andrei Prigorshnev e85aab4b33 FIX: the back button (#130) 
Back button wasn't working when running in Ember CLI. This PR fixes it by doing the transition to the same route but without URL parameter properly. This works in both our environments (legacy-3.12.0, and ember-cli-3.15.0).
 2021-08-11 14:13:39 +04:00
Jarek Radosz cf2735162a DEV: Fix template linting issues (#124) 
* Update test
* Remove the empty line in table
 2021-07-05 23:15:57 +02:00
David Taylor 4354e1b766 DEV: Resolve some template linting issues (#123) 
Some larger issues still remain, but this is a good first step
 2021-07-02 16:35:50 +01:00
Andrei Prigorshnev 814ec14636 FIX: add missing string (#121) 2021-07-02 14:22:40 +04:00
Mark VanLandingham f3b2011ae1 FIX: Translation of column headers in query table (#122) 2021-07-01 08:58:45 -05:00
Andrei Prigorshnev 782dc09d96 UX: Add a help modal dialog (#109) 2021-04-15 19:17:07 +04:00
David Taylor 216dff3ed9 DEV: Improve logic for showing/hiding the reports tab in group screens (#107) 
Previously this was adding an extra AJAX request to check if the group had any queries available. Now a boolean is included in the group serializer, so there is no need for the extra request.

Removing this ajax request will also stop other plugin JS integration tests from failing when the data-explorer plugin is installed.

This commit also fixes the HTML markup of the tab, so that it doesn't have a <ul> nested inside the existing <ul>. Also adds an icon for good measure.
 2021-04-08 17:47:44 +01:00
David Taylor 563251d608 DEV: Remove String.endsWith polyfill (#106) 
Discourse no longer supports internet explorer. This function is supported natively on all browsers Discourse currently targets.
 2021-04-08 17:46:43 +01:00
Grayden 82cb3ac2fe Allow admins to see the group reports nav item (#101) 
Previously, the report tab would appear only if the user was a member of the group. With this change, admins can see the reports in any group.
 2021-04-08 15:50:49 +01:00
Osama Sayegh 8ef3fa38d6 Revert "Revert "DEV: Migrate from {{user-selector}} to {{email-group-user-chooser}} (#94)" (#102)" (#103) 
Follow-up to https://github.com/discourse/discourse-data-explorer/pull/102. This is essentially a revert of that PR, the only difference is that the `.discourse-compatibility` file now pins the plugin to https://github.com/discourse/discourse-data-explorer/commit/60ffd4bc4d357b365cdb8a6764cec621f2edcf81 for sites ≤ `2.7.0.beta3`.
 2021-03-06 20:16:49 +03:00
Osama Sayegh 60ffd4bc4d Revert "DEV: Migrate from {{user-selector}} to {{email-group-user-chooser}} (#94)" (#102) 
The reverted commit pinned the plugin version on stable because the changes in that commit aren't compatible with stable. However, the version that we pinned the plugin to has a bug on stable and https://github.com/discourse/discourse-data-explorer/commit/50e62d84e854b8980e2201f729573f5ce5a8d2fc fixes that bug. So we need to temporarily revert https://github.com/discourse/discourse-data-explorer/commit/5e24556b24f76fe664a732339c773d58ab106fbe to unpin the plugin and I'll create another PR to undo this revert and re-pin the plugin version to this commit for sites on stable.

Meta topic: https://meta.discourse.org/t/data-explorer-editing-broken-on-stable/181274/11?u=osama.
 2021-03-06 14:48:58 +03:00
Joffrey JAFFEUX 69f1e5d13b DEV: uses discourse-common/lib/raw-templates (#98) 2021-02-24 19:49:26 +01:00
Roman Rizzi 50e62d84e8 FIX: Use Ember's debounce on stable. (#96) 
We need to wrap the new debounce function inside a try block to avoid throwing a "module not found" exception.
 2021-02-22 12:55:11 -03:00
Andrew Prigorshnev 4f33c22344 FEATURE: Add a graph report to query results (#93) 2021-02-18 12:06:22 +01:00
Kris 3151fde1e7 UX: allow horizontal overflow scroll, fix button (#95) 2021-02-18 10:36:37 +01:00
Osama Sayegh 5e24556b24 DEV: Migrate from {{user-selector}} to {{email-group-user-chooser}} (#94) 2021-02-16 13:37:30 +03:00
Andrew Prigorshnev 9d86b8b653 FIX: Show badge names in query results (#92) 
* FIX: Show badge names in query results
 2021-02-12 10:01:16 +01:00
Joffrey JAFFEUX 8ab94e334c DEV: prettier 2.2.1 (#89) 2021-01-27 10:38:56 +01:00
Roman Rizzi c6a11d9280 DEV: Use the new discourseDebounce function wrapper. (#85) 
We recently merged a Discourse core's PR to replace usages of Ember's debounce and discourseDebounce with a new debounce wrapper. The new wrapper works exactly like Ember's debounce but internally calls "run" when called in test mode.

This PR replaces all usages of other debounce functions with the new wrapper and fallbacks to Ember's debounce for backward-compatibility.
 2021-01-05 13:09:21 -03:00
Kane York 4506cf6a11 FIX: Use standard error handling for requests, special-case moderators (#84) 
By removing the catch and letting the error propagate to the top-level error handler, we can receive more detailed error reports including exactly which request failed.

The assumption that any request failure is a permissions error is replaced by an explicit client-side check before making any requests.
 2020-12-07 15:13:14 -08:00
tshenry f1785326a8 FIX: Permitted groups should display on group query access picker (#77) 
The toString() that was introduced in 80ffc45 was preventing any actively permitted groups from displaying in the group picker when entering a query page.
 2020-10-19 12:03:03 -07:00
jjaffeux e0e639e70f Revert "DEV: enforces no-var (#74)" 
This reverts commit 94c1ef21c8.
 2020-10-13 15:40:56 +02:00
Joffrey JAFFEUX 94c1ef21c8 DEV: enforces no-var (#74) 2020-10-13 15:17:33 +02:00
Martin Brennan 26ccc36b5b FIX: Resolve yarn lint complaint 2020-10-07 14:08:26 +10:00
Martin Brennan a4665c27e8 Revert "Import getURL to fix deprecation warnings (#52)" 
This reverts commit d643cf742e.

A previous change was already made in this repo to import getURL,
this causes a double import which breaks the build.
 2020-10-07 13:13:38 +10:00
Mark VanLandingham d643cf742e Import getURL to fix deprecation warnings (#52) 2020-10-07 12:58:52 +11:00
Ricky Chon 80ffc4582f UI: Don't show 'everyone' group for query access (#59) 
* Query access for 'everyone' does not work, but trust level 0 does,
and it works the same
 2020-10-07 12:56:51 +11:00
Joffrey JAFFEUX 685b5a45c1 FIX: the filtered array was not being used (#69) 2020-09-23 09:53:14 -04:00
jjaffeux 6205bb8569 DEV: linting 2020-09-22 17:11:41 +02:00
Joffrey JAFFEUX e0a3ad12a6 DEV: apply coding standards (#66) 2020-09-04 13:23:11 +02:00