With https://github.com/discourse/discourse-signatures/pull/105 we had an issue where the character count would show NaN when the signature was empty.
For some reason it was not being auto tracked so when you hit the keys now it should update the UI as expected.
* FEATURE: Add group, category, and display restrictions for signatures
Adds five new site settings to control signature behavior:
- signatures_allowed_groups: restrict signatures to specific groups
(server-side enforced in both serializers and user update hook)
- signatures_show_in_categories: limit signature display to specific categories
- signatures_first_post_only: only show signatures on the OP
- signatures_max_length: cap advanced mode signature length
- signatures_max_image_height: constrain signature image height
Also hardens URL validation (HTTP/HTTPS only) and reduces
signature_url max_length from 32KB to 2048.
All defaults are backward-compatible (empty/false = no change).
Using an external URL was causing the browser to actually attempt to
connect to it. Sometimes, a response from the external URL will take
more than 30 seconds to return a response causing the page to never fire
the load event before playwright's timeout is reached.
Creating the post ahead of time ensures it's ready when we want to visit it. There's also no need to reload the user as we do a visit which triggers a full page refresh.
register_editable_user_custom_field is "singular" and only access one
"custom field" as a parameter.
the fix was to call register_editable_user_custom_field for each custom
fields this plugin uses.
also added a bunch of system specs to ensure the basics of the plugin
actually works.
Internal ref - t/161823
Gabriel Grubba