From 8dbd2204c302ea915a47c7c320fbf0652d2c7d3b Mon Sep 17 00:00:00 2001 From: Andrew Kushnir Date: Wed, 16 Dec 2020 14:51:10 -0800 Subject: [PATCH] fix(dev-infra): fix `yarn symbol-extractor` command (#40163) The `yarn symbol-extractor:check` and `yarn symbol-extractor:update` commands don't seem to work currently - the script is unable to calculate the list of relevant targets. Running the `bazel query ...` command used in the script fails due to the missing quotes around the query argument. This commit fixes the problem by updating the script to wrap query argument into single quotes. PR Close #40163 --- tools/symbol-extractor/run_all_symbols_extractor_tests.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/symbol-extractor/run_all_symbols_extractor_tests.js b/tools/symbol-extractor/run_all_symbols_extractor_tests.js index dc53de8255..b4b53b1846 100644 --- a/tools/symbol-extractor/run_all_symbols_extractor_tests.js +++ b/tools/symbol-extractor/run_all_symbols_extractor_tests.js @@ -23,7 +23,7 @@ const ALL_TEST_TARGETS = 'yarn', [ '-s', 'bazel', 'query', '--output', 'label', - `kind(nodejs_test, ...) intersect attr("tags", "symbol_extractor", ...)` + `'kind(nodejs_test, ...) intersect attr("tags", "symbol_extractor", ...)'` ], {encoding: 'utf8', shell: true, cwd: path.resolve(__dirname, '../..')}) .stdout.trim()