honeymoose/jclouds
1
0
Fork 0
mirror of https://github.com/apache/jclouds.git synced 2026-08-06 20:26:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address error-prone errors

Browse Source 
Mostly of the form, Collection.size() >= 0.
This commit is contained in:
Andrew Gaul
2015-07-30 15:21:42 -07:00
parent ba55ab4b12
commit 98b3105669
20 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/AddressApiLiveTest.java
+1 -1
View File
@@ -71,7 +71,7 @@ public class AddressApiLiveTest extends BaseCloudStackApiLiveTest {
return;
Set<PublicIPAddress> response = client.getAddressApi().listPublicIPAddresses();
assert null != response;
assertTrue(response.size() >= 0);
assertTrue(response.size() > 0);
for (PublicIPAddress ip : response) {
PublicIPAddress newDetails = getOnlyElement(client.getAddressApi().listPublicIPAddresses(
ListPublicIPAddressesOptions.Builder.id(ip.getId())));
apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/EventApiLiveTest.java
+2 -2
View File
@@ -33,7 +33,7 @@ public class EventApiLiveTest extends BaseCloudStackApiLiveTest {
public void testlistEventTypes() throws Exception {
final Set<String> response = client.getEventApi().listEventTypes();
assert null != response;
assertTrue(response.size() >= 0);
assertTrue(response.size() > 0);
for (String type : response) {
checkEventType(type);
}
@@ -42,7 +42,7 @@ public class EventApiLiveTest extends BaseCloudStackApiLiveTest {
public void testlistEvents() throws Exception {
final Set<Event> response = client.getEventApi().listEvents();
assert null != response;
assertTrue(response.size() >= 0);
assertTrue(response.size() > 0);
for (Event event : response) {
checkEvent(event);
}
apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/FirewallApiLiveTest.java
+1 -1
View File
@@ -115,7 +115,7 @@ public class FirewallApiLiveTest extends BaseCloudStackApiLiveTest {
public void testListPortForwardingRules() throws Exception {
Set<PortForwardingRule> response = client.getFirewallApi().listPortForwardingRules();
assert null != response;
assertTrue(response.size() >= 0);
assertTrue(response.size() > 0);
for (final PortForwardingRule rule : response) {
checkPortForwardingRule(rule);
}
apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GlobalAlertApiLiveTest.java
+1 -1
View File
@@ -38,7 +38,7 @@ public class GlobalAlertApiLiveTest extends BaseCloudStackApiLiveTest {
final Set<Alert> response = globalAdminClient.getAlertClient().listAlerts();
assert null != response;
assertTrue(response.size() >= 0);
assertTrue(response.size() > 0);
int count = 0;
for (Alert alert : response) {
assertNotNull(alert.getDescription());
apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GlobalUsageApiLiveTest.java
+1 -1
View File
@@ -52,7 +52,7 @@ public class GlobalUsageApiLiveTest extends BaseCloudStackApiLiveTest {
Set<UsageRecord> records = globalAdminClient.getUsageClient().listUsageRecords(start, end, ListUsageRecordsOptions.NONE);
assertNotNull(records);
assertTrue(records.size() >= 0);
assertTrue(records.size() > 0);
}
}
apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GuestOSApiLiveTest.java
+2 -2
View File
@@ -38,7 +38,7 @@ public class GuestOSApiLiveTest extends BaseCloudStackApiLiveTest {
public void testListOSTypes() throws Exception {
Set<OSType> response = client.getGuestOSApi().listOSTypes();
assert null != response;
assertTrue(response.size() >= 0);
assertTrue(response.size() > 0);
for (OSType type : response) {
OSType newDetails = getOnlyElement(client.getGuestOSApi().listOSTypes(
ListOSTypesOptions.Builder.id(type.getId())));
@@ -50,7 +50,7 @@ public class GuestOSApiLiveTest extends BaseCloudStackApiLiveTest {
public void testListOSCategories() throws Exception {
Map<String, String> response = client.getGuestOSApi().listOSCategories();
assert null != response;
assertTrue(response.size() >= 0);
assertTrue(response.size() > 0);
for (Entry<String, String> category : response.entrySet()) {
checkOSCategory(category);
}
apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/HypervisorApiLiveTest.java
+1 -1
View File
@@ -33,7 +33,7 @@ public class HypervisorApiLiveTest extends BaseCloudStackApiLiveTest {
public void testListHypervisors() throws Exception {
Set<String> response = client.getHypervisorApi().listHypervisors();
assert null != response;
assertTrue(response.size() >= 0);
assertTrue(response.size() > 0);
for (Zone zone : client.getZoneApi().listZones()) {
Set<String> zoneHype = client.getHypervisorApi().listHypervisorsInZone(zone.getId());
assert response.containsAll(zoneHype);
apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/LoadBalancerApiLiveTest.java
+1 -1
View File
@@ -191,7 +191,7 @@ public class LoadBalancerApiLiveTest extends BaseCloudStackApiLiveTest {
public void testListLoadBalancerRules() throws Exception {
Set<LoadBalancerRule> response = client.getLoadBalancerApi().listLoadBalancerRules();
assert null != response;
assertTrue(response.size() >= 0);
assertTrue(response.size() > 0);
for (LoadBalancerRule rule : response) {
LoadBalancerRule newDetails = findRuleWithId(rule.getId());
assertEquals(rule.getId(), newDetails.getId());
apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/NATApiLiveTest.java
+1 -1
View File
@@ -38,7 +38,7 @@ public class NATApiLiveTest extends BaseCloudStackApiLiveTest {
public void testListIPForwardingRules() throws Exception {
Set<IPForwardingRule> response = client.getNATApi().listIPForwardingRules();
assert null != response;
assertTrue(response.size() >= 0);
assertTrue(response.size() > 0);
for (IPForwardingRule rule : response) {
IPForwardingRule newDetails = getOnlyElement(client.getNATApi().listIPForwardingRules(
ListIPForwardingRulesOptions.Builder.id(rule.getId())));
apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/VirtualMachineApiLiveTest.java
+2 -2
View File
@@ -335,7 +335,7 @@ public class VirtualMachineApiLiveTest extends BaseCloudStackApiLiveTest {
public void testListVirtualMachines() throws Exception {
Set<VirtualMachine> response = client.getVirtualMachineApi().listVirtualMachines();
assert null != response;
assertTrue(response.size() >= 0);
assertTrue(response.size() > 0);
for (VirtualMachine vm : response) {
VirtualMachine newDetails = getOnlyElement(client.getVirtualMachineApi().listVirtualMachines(
ListVirtualMachinesOptions.Builder.id(vm.getId())));
@@ -392,7 +392,7 @@ public class VirtualMachineApiLiveTest extends BaseCloudStackApiLiveTest {
}
}
assert vm.getSecurityGroups() != null && vm.getSecurityGroups().size() >= 0 : vm;
assert vm.getSecurityGroups() != null && vm.getSecurityGroups().size() > 0 : vm;
assert vm.getHypervisor() != null : vm;
}
}
apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/ZoneApiLiveTest.java
+2 -2
View File
@@ -58,8 +58,8 @@ public class ZoneApiLiveTest extends BaseCloudStackApiLiveTest {
break;
case BASIC:
assert zone.getVLAN() == null : zone;
assert zone.getDNS().size() >= 0 : zone;
assert zone.getInternalDNS().size() >= 0 : zone;
assert zone.getDNS().size() > 0 : zone;
assert zone.getInternalDNS().size() > 0 : zone;
assert zone.getDomain() == null : zone;
assert zone.getDomainId() == null : zone;
assert zone.getGuestCIDRAddress() == null : zone;