From 43da8b23e1a3914562bb8b54128e94c862a5cf48 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Tue, 5 Oct 2021 11:30:26 -0700 Subject: [PATCH] chore: roll to 1.15.2-1633455481000 (#637) --- .../com/microsoft/playwright/impl/RequestImpl.java | 9 ++------- .../com/microsoft/playwright/TestNetworkRequest.java | 12 ++++++++++++ scripts/CLI_VERSION | 2 +- 3 files changed, 15 insertions(+), 8 deletions(-) diff --git a/playwright/src/main/java/com/microsoft/playwright/impl/RequestImpl.java b/playwright/src/main/java/com/microsoft/playwright/impl/RequestImpl.java index 67461256..41633861 100644 --- a/playwright/src/main/java/com/microsoft/playwright/impl/RequestImpl.java +++ b/playwright/src/main/java/com/microsoft/playwright/impl/RequestImpl.java @@ -167,13 +167,8 @@ public class RequestImpl extends ChannelOwner implements Request { if (rawHeaders != null) { return rawHeaders; } - ResponseImpl response = response(); - // there is no response, so should we return the headers we have now? - if (response == null) { - return headers; - } - JsonArray rawHeadersJson = response.withLogging("Request.allHeaders", () -> { - JsonObject result = response.sendMessage("rawRequestHeaders").getAsJsonObject(); + JsonArray rawHeadersJson = withLogging("Request.allHeaders", () -> { + JsonObject result = sendMessage("rawRequestHeaders").getAsJsonObject(); return result.getAsJsonArray("headers"); }); diff --git a/playwright/src/test/java/com/microsoft/playwright/TestNetworkRequest.java b/playwright/src/test/java/com/microsoft/playwright/TestNetworkRequest.java index bfccbec0..f79c3db7 100644 --- a/playwright/src/test/java/com/microsoft/playwright/TestNetworkRequest.java +++ b/playwright/src/test/java/com/microsoft/playwright/TestNetworkRequest.java @@ -73,6 +73,18 @@ public class TestNetworkRequest extends TestBase { assertEquals(server.PREFIX + "/empty.html", requests.get(1).url()); } + @Test + void shouldWorkAllHeadersInsideRoute() { + List requests = new ArrayList<>(); + page.route("**", route -> { + assertTrue(route.request().allHeaders().get("accept").length() > 5); + requests.add(route.request()); + route.resume(); + }); + page.navigate(server.PREFIX + "/empty.html"); + assertEquals(1, requests.size()); + } + // https://github.com/microsoft/playwright/issues/3993 @Test void shouldNotWorkForARedirectAndInterception() { diff --git a/scripts/CLI_VERSION b/scripts/CLI_VERSION index dbccc443..e1ac7892 100644 --- a/scripts/CLI_VERSION +++ b/scripts/CLI_VERSION @@ -1 +1 @@ -1.15.0-1633020276000 +1.15.2-1633455481000