From 518f117fb0cbe35424f1644238ba8de18c9e290c Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Tue, 15 Jun 2021 14:29:30 -0700 Subject: [PATCH] chore: roll driver to 1.13.0-next-1623789547000 (#493) --- .../com/microsoft/playwright/Download.java | 7 ++++++ .../com/microsoft/playwright/Playwright.java | 4 ++-- .../com/microsoft/playwright/Tracing.java | 24 +++++++++---------- .../playwright/impl/DownloadImpl.java | 5 ++++ scripts/CLI_VERSION | 2 +- 5 files changed, 27 insertions(+), 15 deletions(-) diff --git a/playwright/src/main/java/com/microsoft/playwright/Download.java b/playwright/src/main/java/com/microsoft/playwright/Download.java index 9b4be980..e9e7ba03 100644 --- a/playwright/src/main/java/com/microsoft/playwright/Download.java +++ b/playwright/src/main/java/com/microsoft/playwright/Download.java @@ -47,6 +47,13 @@ import java.util.*; * has no access to the downloaded files. */ public interface Download { + /** + * **Chromium-only** Cancels a download. Will not fail if the download is already finished or canceled. Upon successful + * cancellations, {@code download.failure()} would resolve to {@code "canceled"}. + * + *

Currently **experimental** and may subject to further changes. + */ + void _cancel(); /** * Returns readable stream for current download or {@code null} if download failed. */ diff --git a/playwright/src/main/java/com/microsoft/playwright/Playwright.java b/playwright/src/main/java/com/microsoft/playwright/Playwright.java index 3a3e6167..0498e78c 100644 --- a/playwright/src/main/java/com/microsoft/playwright/Playwright.java +++ b/playwright/src/main/java/com/microsoft/playwright/Playwright.java @@ -42,8 +42,8 @@ import java.util.*; public interface Playwright extends AutoCloseable { class CreateOptions { /** - * Specify environment variables that will be passed to the driver process. By default driver process inherits environment - * variables of the Playwright process. + * Additional environment variables that will be passed to the driver process. By default driver process inherits + * environment variables of the Playwright process. */ public Map env; diff --git a/playwright/src/main/java/com/microsoft/playwright/Tracing.java b/playwright/src/main/java/com/microsoft/playwright/Tracing.java index feff48ed..8f622ce1 100644 --- a/playwright/src/main/java/com/microsoft/playwright/Tracing.java +++ b/playwright/src/main/java/com/microsoft/playwright/Tracing.java @@ -27,12 +27,12 @@ import java.util.*; *

{@code
  * Browser browser = chromium.launch();
  * BrowserContext context = browser.newContext();
- * context.tracing.start(new Tracing.StartOptions()
+ * context.tracing().start(new Tracing.StartOptions()
  *   .setScreenshots(true)
- *   .setSnapshots(true);
+ *   .setSnapshots(true));
  * Page page = context.newPage();
- * page.goto("https://playwright.dev");
- * context.tracing.stop(new Tracing.StopOptions()
+ * page.navigate("https://playwright.dev");
+ * context.tracing().stop(new Tracing.StopOptions()
  *   .setPath(Paths.get("trace.zip")));
  * }
*/ @@ -79,12 +79,12 @@ public interface Tracing { /** * Start tracing. *
{@code
-   * context.tracing.start(new Tracing.StartOptions()
+   * context.tracing().start(new Tracing.StartOptions()
    *   .setScreenshots(true)
-   *   .setSnapshots(true);
+   *   .setSnapshots(true));
    * Page page = context.newPage();
-   * page.goto('https://playwright.dev');
-   * context.tracing.stop(new Tracing.StopOptions()
+   * page.navigate("https://playwright.dev");
+   * context.tracing().stop(new Tracing.StopOptions()
    *   .setPath(Paths.get("trace.zip")));
    * }
*/ @@ -94,12 +94,12 @@ public interface Tracing { /** * Start tracing. *
{@code
-   * context.tracing.start(new Tracing.StartOptions()
+   * context.tracing().start(new Tracing.StartOptions()
    *   .setScreenshots(true)
-   *   .setSnapshots(true);
+   *   .setSnapshots(true));
    * Page page = context.newPage();
-   * page.goto('https://playwright.dev');
-   * context.tracing.stop(new Tracing.StopOptions()
+   * page.navigate("https://playwright.dev");
+   * context.tracing().stop(new Tracing.StopOptions()
    *   .setPath(Paths.get("trace.zip")));
    * }
*/ diff --git a/playwright/src/main/java/com/microsoft/playwright/impl/DownloadImpl.java b/playwright/src/main/java/com/microsoft/playwright/impl/DownloadImpl.java index 69a9c568..d075f113 100644 --- a/playwright/src/main/java/com/microsoft/playwright/impl/DownloadImpl.java +++ b/playwright/src/main/java/com/microsoft/playwright/impl/DownloadImpl.java @@ -44,6 +44,11 @@ class DownloadImpl extends LoggingSupport implements Download { return initializer.get("suggestedFilename").getAsString(); } + @Override + public void _cancel() { + throw new UnsupportedOperationException("Not implemented"); + } + @Override public InputStream createReadStream() { return withLogging("Download.createReadStream", () -> artifact.createReadStream()); diff --git a/scripts/CLI_VERSION b/scripts/CLI_VERSION index b15106ba..e126ba5f 100644 --- a/scripts/CLI_VERSION +++ b/scripts/CLI_VERSION @@ -1 +1 @@ -1.13.0-next-1623183015000 +1.13.0-next-1623789547000