honeymoose/playwright-java
1
0
Fork 0
mirror of synced 2026-08-05 15:06:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: rename builder methods from with* to set* (#324)

Browse Source
This commit is contained in:
Yury Semikhatsky
2021-03-05 13:38:26 -08:00
committed by GitHub
parent 86c06c4fd3
commit 617822fa18
64 changed files with 705 additions and 705 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/api-generator/src/main/java/com/microsoft/playwright/tools/ApiGenerator.java
+3 -3
View File
@@ -785,8 +785,8 @@ class Field extends Element {
args.add(f.name);
}
if (!params.isEmpty()) {
output.add(offset + "public " + parentClass + " with" + toTitle(name) + "(" + String.join(", ", params) + ") {");
output.add(offset + " return with" + toTitle(name) + "(new " + type.toJava() + "(" + String.join(", ", args) + "));");
output.add(offset + "public " + parentClass + " set" + toTitle(name) + "(" + String.join(", ", params) + ") {");
output.add(offset + " return set" + toTitle(name) + "(new " + type.toJava() + "(" + String.join(", ", args) + "));");
output.add(offset + "}");
}
}
@@ -795,7 +795,7 @@ class Field extends Element {
}
private void writeGenericBuilderMethod(List<String> output, String offset, String parentClass, String paramType) {
output.add(offset + "public " + parentClass + " with" + toTitle(name) + "(" + paramType + " " + name + ") {");
output.add(offset + "public " + parentClass + " set" + toTitle(name) + "(" + paramType + " " + name + ") {");
String rvalue = type.isNullable() ? "Optional.ofNullable(" + name + ")" : name;
output.add(offset + " this." + name + " = " + rvalue + ";");
output.add(offset + " return this;");